* [PATCH] tracecmd extract: Allow using --compression.
@ 2022-09-01 20:56 Zebediah Figura
2022-09-22 1:49 ` Steven Rostedt
2022-09-22 15:25 ` Zebediah Figura
0 siblings, 2 replies; 8+ messages in thread
From: Zebediah Figura @ 2022-09-01 20:56 UTC (permalink / raw)
To: linux-trace-devel; +Cc: Zeb Figura
From: Zeb Figura <zfigura@codeweavers.com>
This is already supported and works as expected; allow the option to be
specified.
---
tracecmd/trace-record.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 3442e9b..70fb187 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -6648,7 +6648,6 @@ static void parse_record_options(int argc,
case OPT_compression:
cmd_check_die(ctx, CMD_start, *(argv+1), "--compression");
cmd_check_die(ctx, CMD_set, *(argv+1), "--compression");
- cmd_check_die(ctx, CMD_extract, *(argv+1), "--compression");
cmd_check_die(ctx, CMD_stream, *(argv+1), "--compression");
cmd_check_die(ctx, CMD_profile, *(argv+1), "--compression");
if (strcmp(optarg, "any") && strcmp(optarg, "none") &&
--
2.37.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-01 20:56 [PATCH] tracecmd extract: Allow using --compression Zebediah Figura
@ 2022-09-22 1:49 ` Steven Rostedt
2022-09-22 2:20 ` Zebediah Figura
2022-09-22 15:25 ` Zebediah Figura
1 sibling, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2022-09-22 1:49 UTC (permalink / raw)
To: Zebediah Figura; +Cc: linux-trace-devel
On Thu, 1 Sep 2022 15:56:38 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> From: Zeb Figura <zfigura@codeweavers.com>
>
> This is already supported and works as expected; allow the option to be
> specified.
Hi Zeb,
I'd love to accept this patch, but I need you to add your "Signed-off-by"
tag.
See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO
You can either resend the patch, or reply with it here.
Thanks!
-- Steve
> ---
> tracecmd/trace-record.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
> index 3442e9b..70fb187 100644
> --- a/tracecmd/trace-record.c
> +++ b/tracecmd/trace-record.c
> @@ -6648,7 +6648,6 @@ static void parse_record_options(int argc,
> case OPT_compression:
> cmd_check_die(ctx, CMD_start, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_set, *(argv+1), "--compression");
> - cmd_check_die(ctx, CMD_extract, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_stream, *(argv+1), "--compression");
> cmd_check_die(ctx, CMD_profile, *(argv+1), "--compression");
> if (strcmp(optarg, "any") && strcmp(optarg, "none") &&
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-22 1:49 ` Steven Rostedt
@ 2022-09-22 2:20 ` Zebediah Figura
2022-09-22 12:39 ` Steven Rostedt
0 siblings, 1 reply; 8+ messages in thread
From: Zebediah Figura @ 2022-09-22 2:20 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-trace-devel
On 9/21/22 20:49, Steven Rostedt wrote:
> On Thu, 1 Sep 2022 15:56:38 -0500
> Zebediah Figura <zfigura@codeweavers.com> wrote:
>
>> From: Zeb Figura <zfigura@codeweavers.com>
>>
>> This is already supported and works as expected; allow the option to be
>> specified.
>
> Hi Zeb,
>
> I'd love to accept this patch, but I need you to add your "Signed-off-by"
> tag.
>
> See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO
>
> You can either resend the patch, or reply with it here.
Oops, I swear I even specifically remember seeing that in the
contribution instructions, but forgot to actually add it :-(
Sent as reply.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-22 2:20 ` Zebediah Figura
@ 2022-09-22 12:39 ` Steven Rostedt
2022-09-22 15:26 ` Zebediah Figura
0 siblings, 1 reply; 8+ messages in thread
From: Steven Rostedt @ 2022-09-22 12:39 UTC (permalink / raw)
To: Zebediah Figura; +Cc: linux-trace-devel
On Wed, 21 Sep 2022 21:20:57 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> On 9/21/22 20:49, Steven Rostedt wrote:
> > On Thu, 1 Sep 2022 15:56:38 -0500
> > Zebediah Figura <zfigura@codeweavers.com> wrote:
> >
> >> From: Zeb Figura <zfigura@codeweavers.com>
> >>
> >> This is already supported and works as expected; allow the option to be
> >> specified.
> >
> > Hi Zeb,
> >
> > I'd love to accept this patch, but I need you to add your "Signed-off-by"
> > tag.
> >
> > See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO
> >
> > You can either resend the patch, or reply with it here.
>
> Oops, I swear I even specifically remember seeing that in the
> contribution instructions, but forgot to actually add it :-(
>
> Sent as reply.
I still, need you to write the "Signed-off-by: Name <email>" part. As I'm
not allowed to do it for you.
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-01 20:56 [PATCH] tracecmd extract: Allow using --compression Zebediah Figura
2022-09-22 1:49 ` Steven Rostedt
@ 2022-09-22 15:25 ` Zebediah Figura
2022-09-22 15:27 ` Steven Rostedt
1 sibling, 1 reply; 8+ messages in thread
From: Zebediah Figura @ 2022-09-22 15:25 UTC (permalink / raw)
To: linux-trace-devel
Signed-off-by: Zeb Figura <zfigura@codeweavers.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-22 12:39 ` Steven Rostedt
@ 2022-09-22 15:26 ` Zebediah Figura
2022-09-22 15:40 ` Steven Rostedt
0 siblings, 1 reply; 8+ messages in thread
From: Zebediah Figura @ 2022-09-22 15:26 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-trace-devel
On 9/22/22 07:39, Steven Rostedt wrote:
> On Wed, 21 Sep 2022 21:20:57 -0500
> Zebediah Figura <zfigura@codeweavers.com> wrote:
>
>> On 9/21/22 20:49, Steven Rostedt wrote:
>>> On Thu, 1 Sep 2022 15:56:38 -0500
>>> Zebediah Figura <zfigura@codeweavers.com> wrote:
>>>
>>>> From: Zeb Figura <zfigura@codeweavers.com>
>>>>
>>>> This is already supported and works as expected; allow the option to be
>>>> specified.
>>>
>>> Hi Zeb,
>>>
>>> I'd love to accept this patch, but I need you to add your "Signed-off-by"
>>> tag.
>>>
>>> See https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/tree/DCO
>>>
>>> You can either resend the patch, or reply with it here.
>>
>> Oops, I swear I even specifically remember seeing that in the
>> contribution instructions, but forgot to actually add it :-(
>>
>> Sent as reply.
>
> I still, need you to write the "Signed-off-by: Name <email>" part. As I'm
> not allowed to do it for you.
Gah, I managed to send it as a reply to myself. Sorry about this, I
swear I usually am more capable of sending sign-offs...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-22 15:25 ` Zebediah Figura
@ 2022-09-22 15:27 ` Steven Rostedt
0 siblings, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2022-09-22 15:27 UTC (permalink / raw)
To: Zebediah Figura; +Cc: linux-trace-devel
On Thu, 22 Sep 2022 10:25:23 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> Signed-off-by: Zeb Figura <zfigura@codeweavers.com>
Thanks!
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] tracecmd extract: Allow using --compression.
2022-09-22 15:26 ` Zebediah Figura
@ 2022-09-22 15:40 ` Steven Rostedt
0 siblings, 0 replies; 8+ messages in thread
From: Steven Rostedt @ 2022-09-22 15:40 UTC (permalink / raw)
To: Zebediah Figura; +Cc: linux-trace-devel
On Thu, 22 Sep 2022 10:26:40 -0500
Zebediah Figura <zfigura@codeweavers.com> wrote:
> > I still, need you to write the "Signed-off-by: Name <email>" part. As I'm
> > not allowed to do it for you.
>
> Gah, I managed to send it as a reply to myself. Sorry about this, I
> swear I usually am more capable of sending sign-offs...
No problem.
I applied it. Thanks Zeb!
-- Steve
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-22 15:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 20:56 [PATCH] tracecmd extract: Allow using --compression Zebediah Figura
2022-09-22 1:49 ` Steven Rostedt
2022-09-22 2:20 ` Zebediah Figura
2022-09-22 12:39 ` Steven Rostedt
2022-09-22 15:26 ` Zebediah Figura
2022-09-22 15:40 ` Steven Rostedt
2022-09-22 15:25 ` Zebediah Figura
2022-09-22 15:27 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.