* [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper
@ 2022-09-22 13:48 Yang Yingliang
2022-09-22 14:19 ` Heikki Krogerus
2022-09-22 14:42 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-09-22 13:48 UTC (permalink / raw)
To: linux-usb; +Cc: linux, heikki.krogerus, gregkh
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/usb/typec/tcpm/fusb302.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index db83b377b2f6..721b2a548084 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
if (IS_ERR(chip->tcpm_port)) {
fwnode_handle_put(chip->tcpc_dev.fwnode);
- ret = PTR_ERR(chip->tcpm_port);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "cannot register tcpm port, ret=%d", ret);
+ ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
+ "cannot register tcpm port\n");
goto destroy_workqueue;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper
2022-09-22 13:48 [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-09-22 14:19 ` Heikki Krogerus
2022-09-22 14:42 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2022-09-22 14:19 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-usb, linux, gregkh
On Thu, Sep 22, 2022 at 09:48:06PM +0800, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index db83b377b2f6..721b2a548084 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
> chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
> if (IS_ERR(chip->tcpm_port)) {
> fwnode_handle_put(chip->tcpc_dev.fwnode);
> - ret = PTR_ERR(chip->tcpm_port);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "cannot register tcpm port, ret=%d", ret);
> + ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
> + "cannot register tcpm port\n");
> goto destroy_workqueue;
> }
>
> --
> 2.25.1
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper
2022-09-22 13:48 [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-22 14:19 ` Heikki Krogerus
@ 2022-09-22 14:42 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-09-22 14:42 UTC (permalink / raw)
To: Yang Yingliang, linux-usb; +Cc: heikki.krogerus, gregkh
On 9/22/22 06:48, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index db83b377b2f6..721b2a548084 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1743,9 +1743,8 @@ static int fusb302_probe(struct i2c_client *client,
> chip->tcpm_port = tcpm_register_port(&client->dev, &chip->tcpc_dev);
> if (IS_ERR(chip->tcpm_port)) {
> fwnode_handle_put(chip->tcpc_dev.fwnode);
> - ret = PTR_ERR(chip->tcpm_port);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "cannot register tcpm port, ret=%d", ret);
> + ret = dev_err_probe(dev, PTR_ERR(chip->tcpm_port),
> + "cannot register tcpm port\n");
> goto destroy_workqueue;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-22 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 13:48 [PATCH -next] usb: typec: fusb302: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-22 14:19 ` Heikki Krogerus
2022-09-22 14:42 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.