All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings
@ 2022-09-22 14:11 Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning Wei Yongjun
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Thierry Reding, Linus Walleij, Markuss Broks, Sam Ravnborg,
	David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree.

Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT
compatible") added a test to check that every SPI driver has a
spi_device_id for each DT compatiable string defined by driver
and warns if the spi_device_id is missing.

This series add spi_device_id entries to silence the warnings, and
ensure driver module autoloading works.

v1 -> v2:
 - post as patch series
 - add more detail to commit message
 - format spi ids the same format as of ids
 - remove unused driver_data from spi_device_id

Wei Yongjun (10):
  drm/panel: db7430: Silence no spi_device_id warning
  drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings
  drm/panel: innolux-ej030na: Silence no spi_device_id warning
  drm/panel: novatek,nt39016: Silence no spi_device_id warning
  drm/panel: nv3052c: Silence no spi_device_id warning
  drm/panel: s6d27a1: Silence no spi_device_id warning
  drm/panel: s6e63m0: Silence no spi_device_id warning
  drm/panel: tpg110: Silence no spi_device_id warning
  drm/panel: ws2401: Silence no spi_device_id warning
  drm/panel: y030xx067a: Silence no spi_device_id warning

 drivers/gpu/drm/panel/panel-abt-y030xx067a.c      | 7 +++++++
 drivers/gpu/drm/panel/panel-ilitek-ili9322.c      | 8 ++++++++
 drivers/gpu/drm/panel/panel-innolux-ej030na.c     | 7 +++++++
 drivers/gpu/drm/panel/panel-newvision-nv3052c.c   | 7 +++++++
 drivers/gpu/drm/panel/panel-novatek-nt39016.c     | 7 +++++++
 drivers/gpu/drm/panel/panel-samsung-db7430.c      | 7 +++++++
 drivers/gpu/drm/panel/panel-samsung-s6d27a1.c     | 7 +++++++
 drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c | 7 +++++++
 drivers/gpu/drm/panel/panel-tpo-tpg110.c          | 7 +++++++
 drivers/gpu/drm/panel/panel-widechips-ws2401.c    | 7 +++++++
 10 files changed, 71 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 02/10] drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings Wei Yongjun
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Linus Walleij, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver db7430-panel has no spi_device_id for samsung,lms397kf04

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-samsung-db7430.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-db7430.c b/drivers/gpu/drm/panel/panel-samsung-db7430.c
index 04640c5256a8..c341b45c8a36 100644
--- a/drivers/gpu/drm/panel/panel-samsung-db7430.c
+++ b/drivers/gpu/drm/panel/panel-samsung-db7430.c
@@ -331,9 +331,16 @@ static const struct of_device_id db7430_match[] = {
 };
 MODULE_DEVICE_TABLE(of, db7430_match);
 
+static const struct spi_device_id db7430_ids[] = {
+	{ "lms397kf04" },
+	{},
+};
+MODULE_DEVICE_TABLE(spi, db7430_ids);
+
 static struct spi_driver db7430_driver = {
 	.probe		= db7430_probe,
 	.remove		= db7430_remove,
+	.id_table	= db7430_ids,
 	.driver		= {
 		.name	= "db7430-panel",
 		.of_match_table = db7430_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 02/10] drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning Wei Yongjun
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver panel-ilitek-ili9322 has no spi_device_id for dlink,dir-685-panel
SPI driver panel-ilitek-ili9322 has no spi_device_id for ilitek,ili9322

Add spi_device_id entries to silence the warnings, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
index 3dfafa585127..768721be4240 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
@@ -933,9 +933,17 @@ static const struct of_device_id ili9322_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ili9322_of_match);
 
+static const struct spi_device_id ili9322_ids[] = {
+	{ "dir-685-panel" },
+	{ "ili9322" },
+	{ }
+};
+MODULE_DEVICE_TABLE(spi, ili9322_ids);
+
 static struct spi_driver ili9322_driver = {
 	.probe = ili9322_probe,
 	.remove = ili9322_remove,
+	.id_table = ili9322_ids,
 	.driver = {
 		.name = "panel-ilitek-ili9322",
 		.of_match_table = ili9322_of_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 02/10] drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 04/10] drm/panel: novatek, nt39016: " Wei Yongjun
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver panel-innolux-ej030na has no spi_device_id for innolux,ej030na

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-innolux-ej030na.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c b/drivers/gpu/drm/panel/panel-innolux-ej030na.c
index b2b0ebc9e943..331735bb2b4c 100644
--- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c
+++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c
@@ -293,6 +293,12 @@ static const struct of_device_id ej030na_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ej030na_of_match);
 
+static const struct spi_device_id ej030na_ids[] = {
+	{ "ej030na" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, ej030na_ids);
+
 static struct spi_driver ej030na_driver = {
 	.driver = {
 		.name = "panel-innolux-ej030na",
@@ -300,6 +306,7 @@ static struct spi_driver ej030na_driver = {
 	},
 	.probe = ej030na_probe,
 	.remove = ej030na_remove,
+	.id_table = ej030na_ids,
 };
 module_spi_driver(ej030na_driver);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 04/10] drm/panel: novatek, nt39016: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (2 preceding siblings ...)
  2022-09-22 14:11 ` [PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 05/10] drm/panel: nv3052c: " Wei Yongjun
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver nt39016 has no spi_device_id for kingdisplay,kd035g6-54nt

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-novatek-nt39016.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
index f58cfb10b58a..88a892b103e6 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c
@@ -344,6 +344,12 @@ static const struct of_device_id nt39016_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, nt39016_of_match);
 
+static const struct spi_device_id nt39016_ids[] = {
+	{ "kd035g6-54nt" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, nt39016_ids);
+
 static struct spi_driver nt39016_driver = {
 	.driver = {
 		.name = "nt39016",
@@ -351,6 +357,7 @@ static struct spi_driver nt39016_driver = {
 	},
 	.probe = nt39016_probe,
 	.remove = nt39016_remove,
+	.id_table = nt39016_ids,
 };
 
 module_spi_driver(nt39016_driver);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 05/10] drm/panel: nv3052c: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (3 preceding siblings ...)
  2022-09-22 14:11 ` [PATCH v2 04/10] drm/panel: novatek, nt39016: " Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:11 ` [PATCH v2 06/10] drm/panel: s6d27a1: " Wei Yongjun
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver nv3052c has no spi_device_id for leadtek,ltk035c5444t

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
index cf078f0d3cd3..a523e1dd2b4c 100644
--- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
+++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
@@ -467,6 +467,12 @@ static const struct of_device_id nv3052c_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, nv3052c_of_match);
 
+static const struct spi_device_id nv3052c_ids[] = {
+	{ "ltk035c5444t" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, nv3052c_ids);
+
 static struct spi_driver nv3052c_driver = {
 	.driver = {
 		.name = "nv3052c",
@@ -474,6 +480,7 @@ static struct spi_driver nv3052c_driver = {
 	},
 	.probe = nv3052c_probe,
 	.remove = nv3052c_remove,
+	.id_table = nv3052c_ids,
 };
 module_spi_driver(nv3052c_driver);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 06/10] drm/panel: s6d27a1: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (4 preceding siblings ...)
  2022-09-22 14:11 ` [PATCH v2 05/10] drm/panel: nv3052c: " Wei Yongjun
@ 2022-09-22 14:11 ` Wei Yongjun
  2022-09-22 14:12 ` [PATCH v2 07/10] drm/panel: s6e63m0: " Wei Yongjun
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:11 UTC (permalink / raw)
  To: Markuss Broks, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver s6d27a1-panel has no spi_device_id for samsung,s6d27a1

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-samsung-s6d27a1.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d27a1.c b/drivers/gpu/drm/panel/panel-samsung-s6d27a1.c
index 2adb223a895c..4e80ef81b282 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d27a1.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d27a1.c
@@ -304,9 +304,16 @@ static const struct of_device_id s6d27a1_match[] = {
 };
 MODULE_DEVICE_TABLE(of, s6d27a1_match);
 
+static const struct spi_device_id s6d27a1_ids[] = {
+	{ "s6d27a1" },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(spi, s6d27a1_ids);
+
 static struct spi_driver s6d27a1_driver = {
 	.probe		= s6d27a1_probe,
 	.remove		= s6d27a1_remove,
+	.id_table	= s6d27a1_ids,
 	.driver		= {
 		.name	= "s6d27a1-panel",
 		.of_match_table = s6d27a1_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 07/10] drm/panel: s6e63m0: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (5 preceding siblings ...)
  2022-09-22 14:11 ` [PATCH v2 06/10] drm/panel: s6d27a1: " Wei Yongjun
@ 2022-09-22 14:12 ` Wei Yongjun
  2022-09-22 14:12 ` [PATCH v2 08/10] drm/panel: tpg110: " Wei Yongjun
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:12 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver panel-samsung-s6e63m0 has no spi_device_id for samsung,s6e63m0

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c
index d99afcc672ca..0333adfec0b5 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c
@@ -73,9 +73,16 @@ static const struct of_device_id s6e63m0_spi_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, s6e63m0_spi_of_match);
 
+static const struct spi_device_id s6e63m0_ids[] = {
+	{ "s6e63m0" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, s6e63m0_ids);
+
 static struct spi_driver s6e63m0_spi_driver = {
 	.probe			= s6e63m0_spi_probe,
 	.remove			= s6e63m0_spi_remove,
+	.id_table		= s6e63m0_ids,
 	.driver			= {
 		.name		= "panel-samsung-s6e63m0",
 		.of_match_table = s6e63m0_spi_of_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 08/10] drm/panel: tpg110: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (6 preceding siblings ...)
  2022-09-22 14:12 ` [PATCH v2 07/10] drm/panel: s6e63m0: " Wei Yongjun
@ 2022-09-22 14:12 ` Wei Yongjun
  2022-09-22 14:12 ` [PATCH v2 09/10] drm/panel: ws2401: " Wei Yongjun
  2022-09-22 14:12 ` [PATCH v2 10/10] drm/panel: y030xx067a: " Wei Yongjun
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:12 UTC (permalink / raw)
  To: Linus Walleij, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver tpo-tpg110-panel has no spi_device_id for tpo,tpg110

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-tpo-tpg110.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
index 0b1f5a11a055..f6cac569420c 100644
--- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c
+++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
@@ -463,9 +463,16 @@ static const struct of_device_id tpg110_match[] = {
 };
 MODULE_DEVICE_TABLE(of, tpg110_match);
 
+static const struct spi_device_id tpg110_ids[] = {
+	{ "tpg110" },
+	{},
+};
+MODULE_DEVICE_TABLE(spi, tpg110_ids);
+
 static struct spi_driver tpg110_driver = {
 	.probe		= tpg110_probe,
 	.remove		= tpg110_remove,
+	.id_table	= tpg110_ids,
 	.driver		= {
 		.name	= "tpo-tpg110-panel",
 		.of_match_table = tpg110_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 09/10] drm/panel: ws2401: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (7 preceding siblings ...)
  2022-09-22 14:12 ` [PATCH v2 08/10] drm/panel: tpg110: " Wei Yongjun
@ 2022-09-22 14:12 ` Wei Yongjun
  2022-09-22 14:12 ` [PATCH v2 10/10] drm/panel: y030xx067a: " Wei Yongjun
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:12 UTC (permalink / raw)
  To: Linus Walleij, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver ws2401-panel has no spi_device_id for samsung,lms380kf01

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-widechips-ws2401.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-widechips-ws2401.c b/drivers/gpu/drm/panel/panel-widechips-ws2401.c
index 236f3cb2b594..436ba96befb7 100644
--- a/drivers/gpu/drm/panel/panel-widechips-ws2401.c
+++ b/drivers/gpu/drm/panel/panel-widechips-ws2401.c
@@ -425,9 +425,16 @@ static const struct of_device_id ws2401_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ws2401_match);
 
+static const struct spi_device_id ws2401_ids[] = {
+	{ "lms380kf01" },
+	{},
+};
+MODULE_DEVICE_TABLE(spi, ws2401_ids);
+
 static struct spi_driver ws2401_driver = {
 	.probe		= ws2401_probe,
 	.remove		= ws2401_remove,
+	.id_table	= ws2401_ids,
 	.driver		= {
 		.name	= "ws2401-panel",
 		.of_match_table = ws2401_match,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 10/10] drm/panel: y030xx067a: Silence no spi_device_id warning
  2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
                   ` (8 preceding siblings ...)
  2022-09-22 14:12 ` [PATCH v2 09/10] drm/panel: ws2401: " Wei Yongjun
@ 2022-09-22 14:12 ` Wei Yongjun
  9 siblings, 0 replies; 11+ messages in thread
From: Wei Yongjun @ 2022-09-22 14:12 UTC (permalink / raw)
  To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
  Cc: Wei Yongjun, dri-devel

From: Wei Yongjun <weiyongjun1@huawei.com>

SPI devices use the spi_device_id for module autoloading even on
systems using device tree, after commit 5fa6863ba692 ("spi: Check
we have a spi_device_id for each DT compatible"), kernel warns as
follows since the spi_device_id is missing:

SPI driver abt-y030xx067a has no spi_device_id for abt,y030xx067a

Add spi_device_id entries to silence the warning, and ensure driver
module autoloading works.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
index 1cc0f1d09684..eec5b3a25045 100644
--- a/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
+++ b/drivers/gpu/drm/panel/panel-abt-y030xx067a.c
@@ -368,6 +368,12 @@ static const struct of_device_id y030xx067a_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, y030xx067a_of_match);
 
+static const struct spi_device_id y030xx067a_ids[] = {
+	{ "y030xx067a" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, y030xx067a_ids);
+
 static struct spi_driver y030xx067a_driver = {
 	.driver = {
 		.name = "abt-y030xx067a",
@@ -375,6 +381,7 @@ static struct spi_driver y030xx067a_driver = {
 	},
 	.probe = y030xx067a_probe,
 	.remove = y030xx067a_remove,
+	.id_table = y030xx067a_ids,
 };
 module_spi_driver(y030xx067a_driver);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-09-22 13:56 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 14:11 [PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 02/10] drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 04/10] drm/panel: novatek, nt39016: " Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 05/10] drm/panel: nv3052c: " Wei Yongjun
2022-09-22 14:11 ` [PATCH v2 06/10] drm/panel: s6d27a1: " Wei Yongjun
2022-09-22 14:12 ` [PATCH v2 07/10] drm/panel: s6e63m0: " Wei Yongjun
2022-09-22 14:12 ` [PATCH v2 08/10] drm/panel: tpg110: " Wei Yongjun
2022-09-22 14:12 ` [PATCH v2 09/10] drm/panel: ws2401: " Wei Yongjun
2022-09-22 14:12 ` [PATCH v2 10/10] drm/panel: y030xx067a: " Wei Yongjun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.