* [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper @ 2022-09-22 16:49 Gustavo Sousa 2022-09-22 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) Patchwork ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Gustavo Sousa @ 2022-09-22 16:49 UTC (permalink / raw) To: intel-gfx; +Cc: Lucas De Marchi Use *_hpd_invert() helpers whenever possible to isolate logic specific to hotplug inversion from common HPD setup logic to improve readability and maintainability of the source code. While we only define dg1_hpd_invert() here, future platforms are likely to have different hotplug inversion needs, thus it makes sense grouping different implementations under a common suffix. v2: Fix coding style and prefer to use small *_hdp_invert() helpers instead of a generic one. CC: Jani Nikula <jani.nikula@linux.intel.com> CC: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> --- drivers/gpu/drm/i915/i915_irq.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index de06f293e173..87cb05b3b6ce 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -3411,17 +3411,18 @@ static u32 gen11_hotplug_enables(struct drm_i915_private *i915, } } +static void dg1_hpd_invert(struct drm_i915_private *i915) +{ + u32 val = (INVERT_DDIA_HPD | + INVERT_DDIB_HPD | + INVERT_DDIC_HPD | + INVERT_DDID_HPD); + intel_uncore_rmw(&i915->uncore, SOUTH_CHICKEN1, 0, val); +} + static void dg1_hpd_irq_setup(struct drm_i915_private *dev_priv) { - u32 val; - - val = intel_uncore_read(&dev_priv->uncore, SOUTH_CHICKEN1); - val |= (INVERT_DDIA_HPD | - INVERT_DDIB_HPD | - INVERT_DDIC_HPD | - INVERT_DDID_HPD); - intel_uncore_write(&dev_priv->uncore, SOUTH_CHICKEN1, val); - + dg1_hpd_invert(dev_priv); icp_hpd_irq_setup(dev_priv); } -- 2.37.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) 2022-09-22 16:49 [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Gustavo Sousa @ 2022-09-22 22:20 ` Patchwork 2022-09-23 4:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-09-23 8:20 ` [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Jani Nikula 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2022-09-22 22:20 UTC (permalink / raw) To: Gustavo Sousa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 3987 bytes --] == Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper (rev2) URL : https://patchwork.freedesktop.org/series/108742/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168 -> Patchwork_108742v2 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/index.html Participating hosts (44 -> 43) ------------------------------ Missing (1): fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_108742v2 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@gt_heartbeat: - fi-bxt-dsi: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - {bat-adlm-1}: [DMESG-WARN][3] ([i915#2867]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@smem: - {bat-rplp-1}: [DMESG-WARN][5] ([i915#2867]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@gt_lrc: - {bat-adln-1}: [INCOMPLETE][7] -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/bat-adln-1/igt@i915_selftest@live@gt_lrc.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/bat-adln-1/igt@i915_selftest@live@gt_lrc.html * igt@i915_selftest@live@mman: - fi-rkl-guc: [INCOMPLETE][9] ([i915#6794]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/fi-rkl-guc/igt@i915_selftest@live@mman.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/fi-rkl-guc/igt@i915_selftest@live@mman.html * igt@i915_selftest@live@requests: - {bat-rpls-1}: [INCOMPLETE][11] ([i915#6257] / [i915#6380]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/bat-rpls-1/igt@i915_selftest@live@requests.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/bat-rpls-1/igt@i915_selftest@live@requests.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 [i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380 [i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794 [i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816 Build changes ------------- * Linux: CI_DRM_12168 -> Patchwork_108742v2 CI-20190529: 20190529 CI_DRM_12168: fea329811a7bc341aac5f51ab66ec41a3d0844af @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6662: dcb1d7a8822e62935f4fe3f2e6a04caaee669369 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108742v2: fea329811a7bc341aac5f51ab66ec41a3d0844af @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 1321684a58b6 drm/i915: Move hotplug inversion logic into separate helper == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/index.html [-- Attachment #2: Type: text/html, Size: 4669 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) 2022-09-22 16:49 [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Gustavo Sousa 2022-09-22 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) Patchwork @ 2022-09-23 4:33 ` Patchwork 2022-09-23 8:20 ` [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Jani Nikula 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2022-09-23 4:33 UTC (permalink / raw) To: Gustavo Sousa; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 22375 bytes --] == Series Details == Series: drm/i915: Move hotplug inversion logic into separate helper (rev2) URL : https://patchwork.freedesktop.org/series/108742/ State : success == Summary == CI Bug Log - changes from CI_DRM_12168_full -> Patchwork_108742v2_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (9 -> 9) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_108742v2_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][1] -> [FAIL][2] ([i915#2842]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-iclb: NOTRUN -> [FAIL][3] ([i915#2842]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [PASS][4] -> [FAIL][5] ([i915#2842]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - shard-iclb: NOTRUN -> [SKIP][6] ([fdo#109313]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_lmem_swapping@basic: - shard-iclb: NOTRUN -> [SKIP][7] ([i915#4613]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@gem_lmem_swapping@basic.html * igt@gem_pxp@create-regular-context-1: - shard-iclb: NOTRUN -> [SKIP][8] ([i915#4270]) +2 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@gem_pxp@create-regular-context-1.html * igt@gem_render_copy@y-tiled-to-vebox-linear: - shard-iclb: NOTRUN -> [SKIP][9] ([i915#768]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@gem_render_copy@y-tiled-to-vebox-linear.html * igt@gem_softpin@evict-snoop-interruptible: - shard-iclb: NOTRUN -> [SKIP][10] ([fdo#109312]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@gem_softpin@evict-snoop-interruptible.html * igt@gem_userptr_blits@coherency-unsync: - shard-iclb: NOTRUN -> [SKIP][11] ([i915#3297]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@gem_userptr_blits@coherency-unsync.html * igt@gem_userptr_blits@vma-merge: - shard-iclb: NOTRUN -> [FAIL][12] ([i915#3318]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@gem_userptr_blits@vma-merge.html * igt@gen3_render_linear_blits: - shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109289]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@gen3_render_linear_blits.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][14] -> [DMESG-WARN][15] ([i915#5566] / [i915#716]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-glk3/igt@gen9_exec_parse@allowed-all.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-glk6/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@bb-start-param: - shard-iclb: NOTRUN -> [SKIP][16] ([i915#2856]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@gen9_exec_parse@bb-start-param.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: NOTRUN -> [SKIP][17] ([i915#658]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rpm@modeset-non-lpsp: - shard-iclb: NOTRUN -> [SKIP][18] ([fdo#110892]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@i915_pm_rpm@modeset-non-lpsp.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +5 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-apl3/igt@i915_suspend@sysfs-reader.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl1/igt@i915_suspend@sysfs-reader.html * igt@kms_big_fb@4-tiled-8bpp-rotate-180: - shard-iclb: NOTRUN -> [SKIP][21] ([i915#5286]) +2 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_big_fb@4-tiled-8bpp-rotate-180.html * igt@kms_big_fb@y-tiled-64bpp-rotate-90: - shard-iclb: NOTRUN -> [SKIP][22] ([fdo#110725] / [fdo#111614]) +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-180: - shard-iclb: NOTRUN -> [SKIP][23] ([fdo#110723]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_big_fb@yf-tiled-64bpp-rotate-180.html * igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc: - shard-iclb: NOTRUN -> [SKIP][24] ([fdo#109278] / [i915#3886]) +6 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +4 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl8/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_chamelium@dp-mode-timings: - shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109284] / [fdo#111827]) +5 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_chamelium@dp-mode-timings.html * igt@kms_chamelium@vga-hpd: - shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +7 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl3/igt@kms_chamelium@vga-hpd.html * igt@kms_content_protection@atomic: - shard-apl: NOTRUN -> [TIMEOUT][28] ([i915#1319]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl6/igt@kms_content_protection@atomic.html * igt@kms_content_protection@dp-mst-type-1: - shard-iclb: NOTRUN -> [SKIP][29] ([i915#3116]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_content_protection@dp-mst-type-1.html * igt@kms_content_protection@uevent: - shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109300] / [fdo#111066]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@cursor-random-512x512: - shard-iclb: NOTRUN -> [SKIP][31] ([i915#3359]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_cursor_crc@cursor-random-512x512.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [PASS][32] -> [FAIL][33] ([i915#2346]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor: - shard-iclb: NOTRUN -> [SKIP][34] ([i915#4103]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_cursor_legacy@short-busy-flip-before-cursor.html * igt@kms_flip@2x-wf_vblank-ts-check: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109274]) +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_flip@2x-wf_vblank-ts-check.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][36] ([i915#2587] / [i915#2672]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][37] ([i915#2672]) +7 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html * igt@kms_force_connector_basic@force-load-detect: - shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109285]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc: - shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109280]) +22 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc.html * igt@kms_hdr@static-toggle: - shard-iclb: NOTRUN -> [SKIP][40] ([i915#3555]) +6 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_hdr@static-toggle.html * igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1: - shard-iclb: NOTRUN -> [SKIP][41] ([i915#5176]) +5 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-edp-1.html * igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1: - shard-iclb: [PASS][42] -> [SKIP][43] ([i915#5176]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb7/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [PASS][44] -> [SKIP][45] ([i915#5235]) +2 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb5/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1: - shard-iclb: NOTRUN -> [SKIP][46] ([i915#5235]) +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-edp-1.html * igt@kms_prime@basic-modeset-hybrid: - shard-iclb: NOTRUN -> [SKIP][47] ([i915#6524]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@kms_prime@basic-modeset-hybrid.html * igt@kms_psr2_sf@plane-move-sf-dmg-area: - shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +2 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl6/igt@kms_psr2_sf@plane-move-sf-dmg-area.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109441]) +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109441]) +2 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_psr@psr2_sprite_plane_onoff: - shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +116 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl6/igt@kms_psr@psr2_sprite_plane_onoff.html * igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-b: - shard-iclb: NOTRUN -> [SKIP][53] ([i915#5030]) +2 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-b.html * igt@kms_vblank@pipe-d-wait-forked: - shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278]) +23 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb8/igt@kms_vblank@pipe-d-wait-forked.html * igt@kms_writeback@writeback-invalid-parameters: - shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#2437]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl6/igt@kms_writeback@writeback-invalid-parameters.html * igt@nouveau_crc@pipe-c-source-outp-inactive: - shard-iclb: NOTRUN -> [SKIP][56] ([i915#2530]) +2 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@nouveau_crc@pipe-c-source-outp-inactive.html * igt@perf@stress-open-close: - shard-glk: [PASS][57] -> [INCOMPLETE][58] ([i915#5213]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-glk1/igt@perf@stress-open-close.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-glk9/igt@perf@stress-open-close.html * igt@prime_nv_pcopy@test3_2: - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109291]) +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@prime_nv_pcopy@test3_2.html * igt@sysfs_clients@pidname: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl6/igt@sysfs_clients@pidname.html #### Possible fixes #### * igt@gem_eio@kms: - shard-tglb: [FAIL][61] ([i915#5784]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-tglb2/igt@gem_eio@kms.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-tglb7/igt@gem_eio@kms.html * igt@gem_exec_balancer@parallel: - shard-iclb: [SKIP][63] ([i915#4525]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb6/igt@gem_exec_balancer@parallel.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb1/igt@gem_exec_balancer@parallel.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [FAIL][65] ([i915#2842]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_workarounds@suspend-resume: - shard-apl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +2 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-apl8/igt@gem_workarounds@suspend-resume.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-apl8/igt@gem_workarounds@suspend-resume.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1: - shard-glk: [FAIL][69] ([i915#2521]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-glk7/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1.html * igt@kms_psr@psr2_sprite_blt: - shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html #### Warnings #### * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf: - shard-iclb: [SKIP][73] ([i915#2920]) -> [SKIP][74] ([i915#658]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb5/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area: - shard-iclb: [SKIP][75] ([fdo#111068] / [i915#658]) -> [SKIP][76] ([i915#2920]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html * igt@kms_psr2_sf@plane-move-sf-dmg-area: - shard-iclb: [SKIP][77] ([i915#2920]) -> [SKIP][78] ([fdo#111068] / [i915#658]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12168/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725 [fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768 Build changes ------------- * Linux: CI_DRM_12168 -> Patchwork_108742v2 CI-20190529: 20190529 CI_DRM_12168: fea329811a7bc341aac5f51ab66ec41a3d0844af @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6662: dcb1d7a8822e62935f4fe3f2e6a04caaee669369 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_108742v2: fea329811a7bc341aac5f51ab66ec41a3d0844af @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108742v2/index.html [-- Attachment #2: Type: text/html, Size: 26065 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper 2022-09-22 16:49 [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Gustavo Sousa 2022-09-22 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) Patchwork 2022-09-23 4:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2022-09-23 8:20 ` Jani Nikula 2022-09-24 6:30 ` Lucas De Marchi 2 siblings, 1 reply; 5+ messages in thread From: Jani Nikula @ 2022-09-23 8:20 UTC (permalink / raw) To: Gustavo Sousa, intel-gfx; +Cc: Lucas De Marchi On Thu, 22 Sep 2022, Gustavo Sousa <gustavo.sousa@intel.com> wrote: > Use *_hpd_invert() helpers whenever possible to isolate logic specific > to hotplug inversion from common HPD setup logic to improve readability > and maintainability of the source code. > > While we only define dg1_hpd_invert() here, future platforms are likely > to have different hotplug inversion needs, thus it makes sense grouping > different implementations under a common suffix. > > v2: Fix coding style and prefer to use small *_hdp_invert() helpers > instead of a generic one. > > CC: Jani Nikula <jani.nikula@linux.intel.com> > CC: Lucas De Marchi <lucas.demarchi@intel.com> > Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_irq.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index de06f293e173..87cb05b3b6ce 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -3411,17 +3411,18 @@ static u32 gen11_hotplug_enables(struct drm_i915_private *i915, > } > } > > +static void dg1_hpd_invert(struct drm_i915_private *i915) > +{ > + u32 val = (INVERT_DDIA_HPD | > + INVERT_DDIB_HPD | > + INVERT_DDIC_HPD | > + INVERT_DDID_HPD); > + intel_uncore_rmw(&i915->uncore, SOUTH_CHICKEN1, 0, val); > +} > + > static void dg1_hpd_irq_setup(struct drm_i915_private *dev_priv) > { > - u32 val; > - > - val = intel_uncore_read(&dev_priv->uncore, SOUTH_CHICKEN1); > - val |= (INVERT_DDIA_HPD | > - INVERT_DDIB_HPD | > - INVERT_DDIC_HPD | > - INVERT_DDID_HPD); > - intel_uncore_write(&dev_priv->uncore, SOUTH_CHICKEN1, val); > - > + dg1_hpd_invert(dev_priv); > icp_hpd_irq_setup(dev_priv); > } -- Jani Nikula, Intel Open Source Graphics Center ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper 2022-09-23 8:20 ` [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Jani Nikula @ 2022-09-24 6:30 ` Lucas De Marchi 0 siblings, 0 replies; 5+ messages in thread From: Lucas De Marchi @ 2022-09-24 6:30 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx On Fri, Sep 23, 2022 at 11:20:57AM +0300, Jani Nikula wrote: >On Thu, 22 Sep 2022, Gustavo Sousa <gustavo.sousa@intel.com> wrote: >> Use *_hpd_invert() helpers whenever possible to isolate logic specific >> to hotplug inversion from common HPD setup logic to improve readability >> and maintainability of the source code. >> >> While we only define dg1_hpd_invert() here, future platforms are likely >> to have different hotplug inversion needs, thus it makes sense grouping >> different implementations under a common suffix. >> >> v2: Fix coding style and prefer to use small *_hdp_invert() helpers >> instead of a generic one. >> >> CC: Jani Nikula <jani.nikula@linux.intel.com> >> CC: Lucas De Marchi <lucas.demarchi@intel.com> >> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com> > >Reviewed-by: Jani Nikula <jani.nikula@intel.com> applied, thanks Lucas De Marchi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-24 6:31 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-22 16:49 [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Gustavo Sousa 2022-09-22 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move hotplug inversion logic into separate helper (rev2) Patchwork 2022-09-23 4:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2022-09-23 8:20 ` [Intel-gfx] [PATCH v2] drm/i915: Move hotplug inversion logic into separate helper Jani Nikula 2022-09-24 6:30 ` Lucas De Marchi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.