All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] can: ctucanfd: Remove redundant dev_err call
@ 2022-09-23  9:58 Shang XiaoJing
  2022-09-23 12:11 ` Marc Kleine-Budde
  0 siblings, 1 reply; 2+ messages in thread
From: Shang XiaoJing @ 2022-09-23  9:58 UTC (permalink / raw)
  To: pisa, ondrej.ille, wg, mkl, davem, edumazet, kuba, pabeni,
	linux-can, netdev
  Cc: shangxiaojing

devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
---
 drivers/net/can/ctucanfd/ctucanfd_platform.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c
index 89d54c2151e1..f83684f006ea 100644
--- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
+++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
@@ -58,7 +58,6 @@ static int ctucan_platform_probe(struct platform_device *pdev)
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	addr = devm_ioremap_resource(dev, res);
 	if (IS_ERR(addr)) {
-		dev_err(dev, "Cannot remap address.\n");
 		ret = PTR_ERR(addr);
 		goto err;
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] can: ctucanfd: Remove redundant dev_err call
  2022-09-23  9:58 [PATCH net-next] can: ctucanfd: Remove redundant dev_err call Shang XiaoJing
@ 2022-09-23 12:11 ` Marc Kleine-Budde
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2022-09-23 12:11 UTC (permalink / raw)
  To: Shang XiaoJing
  Cc: pisa, ondrej.ille, wg, davem, edumazet, kuba, pabeni, linux-can, netdev

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On 23.09.2022 17:58:35, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
> 
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>

Applied to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-23 12:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23  9:58 [PATCH net-next] can: ctucanfd: Remove redundant dev_err call Shang XiaoJing
2022-09-23 12:11 ` Marc Kleine-Budde

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.