All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata()
@ 2022-09-23 14:37 Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 1/3] net: dsa: lan9303: " Yang Yingliang
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Yang Yingliang @ 2022-09-23 14:37 UTC (permalink / raw)
  To: netdev
  Cc: andrew, vivien.didelot, f.fainelli, olteanv, woojung.huh,
	Arun.Ramadoss, george.mccollister, davem, kuba

This patchset https://lore.kernel.org/all/20220921140524.3831101-8-yangyingliang@huawei.com/T/
removed all set_drvdata(NULL) in driver remove function.

i2c_set_clientdata() is another wrapper of set drvdata function, to follow
the same convention, remove i2c_set_clientdata() called in driver remove
function in drivers/net/dsa/.

Yang Yingliang (3):
  net: dsa: lan9303: remove unnecessary i2c_set_clientdata()
  net: dsa: microchip: ksz9477: remove unnecessary i2c_set_clientdata()
  net: dsa: xrs700x: remove unnecessary i2c_set_clientdata()

 drivers/net/dsa/lan9303_i2c.c           | 2 --
 drivers/net/dsa/microchip/ksz9477_i2c.c | 2 --
 drivers/net/dsa/xrs700x/xrs700x_i2c.c   | 2 --
 3 files changed, 6 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH net-next 1/3] net: dsa: lan9303: remove unnecessary i2c_set_clientdata()
  2022-09-23 14:37 [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata() Yang Yingliang
@ 2022-09-23 14:37 ` Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 2/3] net: dsa: microchip: ksz9477: " Yang Yingliang
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Yang Yingliang @ 2022-09-23 14:37 UTC (permalink / raw)
  To: netdev
  Cc: andrew, vivien.didelot, f.fainelli, olteanv, woojung.huh,
	Arun.Ramadoss, george.mccollister, davem, kuba

Remove unnecessary i2c_set_clientdata() in ->remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/lan9303_i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dsa/lan9303_i2c.c b/drivers/net/dsa/lan9303_i2c.c
index 8ca4713310fa..79be5fc044bd 100644
--- a/drivers/net/dsa/lan9303_i2c.c
+++ b/drivers/net/dsa/lan9303_i2c.c
@@ -74,8 +74,6 @@ static int lan9303_i2c_remove(struct i2c_client *client)
 
 	lan9303_remove(&sw_dev->chip);
 
-	i2c_set_clientdata(client, NULL);
-
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH net-next 2/3] net: dsa: microchip: ksz9477: remove unnecessary i2c_set_clientdata()
  2022-09-23 14:37 [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata() Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 1/3] net: dsa: lan9303: " Yang Yingliang
@ 2022-09-23 14:37 ` Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 3/3] net: dsa: xrs700x: " Yang Yingliang
  2022-09-27  0:50 ` [PATCH net-next 0/3] net: dsa: " patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Yang Yingliang @ 2022-09-23 14:37 UTC (permalink / raw)
  To: netdev
  Cc: andrew, vivien.didelot, f.fainelli, olteanv, woojung.huh,
	Arun.Ramadoss, george.mccollister, davem, kuba

Remove unnecessary i2c_set_clientdata() in ->remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/microchip/ksz9477_i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c b/drivers/net/dsa/microchip/ksz9477_i2c.c
index 8fbc122e3384..e111756f6473 100644
--- a/drivers/net/dsa/microchip/ksz9477_i2c.c
+++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
@@ -59,8 +59,6 @@ static int ksz9477_i2c_remove(struct i2c_client *i2c)
 	if (dev)
 		ksz_switch_remove(dev);
 
-	i2c_set_clientdata(i2c, NULL);
-
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH net-next 3/3] net: dsa: xrs700x: remove unnecessary i2c_set_clientdata()
  2022-09-23 14:37 [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata() Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 1/3] net: dsa: lan9303: " Yang Yingliang
  2022-09-23 14:37 ` [PATCH net-next 2/3] net: dsa: microchip: ksz9477: " Yang Yingliang
@ 2022-09-23 14:37 ` Yang Yingliang
  2022-09-27  0:50 ` [PATCH net-next 0/3] net: dsa: " patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Yang Yingliang @ 2022-09-23 14:37 UTC (permalink / raw)
  To: netdev
  Cc: andrew, vivien.didelot, f.fainelli, olteanv, woojung.huh,
	Arun.Ramadoss, george.mccollister, davem, kuba

Remove unnecessary i2c_set_clientdata() in ->remove(), the driver_data
will be set to NULL in device_unbind_cleanup() after calling ->remove().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/net/dsa/xrs700x/xrs700x_i2c.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/dsa/xrs700x/xrs700x_i2c.c b/drivers/net/dsa/xrs700x/xrs700x_i2c.c
index 6deae388a0d6..cd533b9e17ec 100644
--- a/drivers/net/dsa/xrs700x/xrs700x_i2c.c
+++ b/drivers/net/dsa/xrs700x/xrs700x_i2c.c
@@ -114,8 +114,6 @@ static int xrs700x_i2c_remove(struct i2c_client *i2c)
 
 	xrs700x_switch_remove(priv);
 
-	i2c_set_clientdata(i2c, NULL);
-
 	return 0;
 }
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata()
  2022-09-23 14:37 [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata() Yang Yingliang
                   ` (2 preceding siblings ...)
  2022-09-23 14:37 ` [PATCH net-next 3/3] net: dsa: xrs700x: " Yang Yingliang
@ 2022-09-27  0:50 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-27  0:50 UTC (permalink / raw)
  To: Yang Yingliang
  Cc: netdev, andrew, vivien.didelot, f.fainelli, olteanv, woojung.huh,
	Arun.Ramadoss, george.mccollister, davem, kuba

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 23 Sep 2022 22:37:39 +0800 you wrote:
> This patchset https://lore.kernel.org/all/20220921140524.3831101-8-yangyingliang@huawei.com/T/
> removed all set_drvdata(NULL) in driver remove function.
> 
> i2c_set_clientdata() is another wrapper of set drvdata function, to follow
> the same convention, remove i2c_set_clientdata() called in driver remove
> function in drivers/net/dsa/.
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: dsa: lan9303: remove unnecessary i2c_set_clientdata()
    https://git.kernel.org/netdev/net-next/c/db5d451c4640
  - [net-next,2/3] net: dsa: microchip: ksz9477: remove unnecessary i2c_set_clientdata()
    https://git.kernel.org/netdev/net-next/c/008971adb95d
  - [net-next,3/3] net: dsa: xrs700x: remove unnecessary i2c_set_clientdata()
    https://git.kernel.org/netdev/net-next/c/6387bf7c390a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-27  0:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 14:37 [PATCH net-next 0/3] net: dsa: remove unnecessary i2c_set_clientdata() Yang Yingliang
2022-09-23 14:37 ` [PATCH net-next 1/3] net: dsa: lan9303: " Yang Yingliang
2022-09-23 14:37 ` [PATCH net-next 2/3] net: dsa: microchip: ksz9477: " Yang Yingliang
2022-09-23 14:37 ` [PATCH net-next 3/3] net: dsa: xrs700x: " Yang Yingliang
2022-09-27  0:50 ` [PATCH net-next 0/3] net: dsa: " patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.