* [PATCH 1/5] Input: lm8333 - add missing linux/input.h include
@ 2022-09-23 19:47 Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 2/5] Input: st-keyscan - add missing linux/input.h and linux/of.h includes Dmitry Torokhov
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 19:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-input; +Cc: linux-kernel
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.
Also let's sort includes alphabetically and drop unneeded irq.h
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/lm8333.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 9dac22c14125..3052cd6dedac 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -4,13 +4,13 @@
* Copyright (C) 2012 Wolfram Sang, Pengutronix <kernel@pengutronix.de>
*/
-#include <linux/module.h>
-#include <linux/slab.h>
-#include <linux/irq.h>
#include <linux/i2c.h>
-#include <linux/interrupt.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/input/lm8333.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/slab.h>
#define LM8333_FIFO_READ 0x20
#define LM8333_DEBOUNCE 0x22
--
2.37.3.998.g577e59143f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/5] Input: st-keyscan - add missing linux/input.h and linux/of.h includes
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
@ 2022-09-23 19:47 ` Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 3/5] Input: mt6779-keypad - add missing linux/input.h include Dmitry Torokhov
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 19:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-input; +Cc: linux-kernel
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.
Also let's sort includes alphabetically.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/st-keyscan.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c
index a045d61165ac..a62bb8fff88c 100644
--- a/drivers/input/keyboard/st-keyscan.c
+++ b/drivers/input/keyboard/st-keyscan.c
@@ -8,12 +8,14 @@
* Based on sh_keysc.c, copyright 2008 Magnus Damm
*/
-#include <linux/module.h>
-#include <linux/interrupt.h>
-#include <linux/platform_device.h>
#include <linux/clk.h>
-#include <linux/io.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
+#include <linux/io.h>
+#include <linux/interrupt.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
#define ST_KEYSCAN_MAXKEYS 16
--
2.37.3.998.g577e59143f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/5] Input: mt6779-keypad - add missing linux/input.h include
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 2/5] Input: st-keyscan - add missing linux/input.h and linux/of.h includes Dmitry Torokhov
@ 2022-09-23 19:47 ` Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 4/5] Input: imx_keypad " Dmitry Torokhov
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 19:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-input; +Cc: linux-kernel
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/mt6779-keypad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c
index a05e70af1fd0..19f69d167fbd 100644
--- a/drivers/input/keyboard/mt6779-keypad.c
+++ b/drivers/input/keyboard/mt6779-keypad.c
@@ -5,6 +5,7 @@
*/
#include <linux/bitops.h>
#include <linux/clk.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/interrupt.h>
#include <linux/module.h>
--
2.37.3.998.g577e59143f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/5] Input: imx_keypad - add missing linux/input.h include
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 2/5] Input: st-keyscan - add missing linux/input.h and linux/of.h includes Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 3/5] Input: mt6779-keypad - add missing linux/input.h include Dmitry Torokhov
@ 2022-09-23 19:47 ` Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 5/5] Input: ep93xx_keypad " Dmitry Torokhov
2022-09-26 10:57 ` [PATCH 1/5] Input: lm8333 " Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 19:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-input; +Cc: linux-kernel
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/imx_keypad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
index ae9303848571..e15a93619e82 100644
--- a/drivers/input/keyboard/imx_keypad.c
+++ b/drivers/input/keyboard/imx_keypad.c
@@ -7,6 +7,7 @@
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/err.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/interrupt.h>
#include <linux/io.h>
--
2.37.3.998.g577e59143f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 5/5] Input: ep93xx_keypad - add missing linux/input.h include
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
` (2 preceding siblings ...)
2022-09-23 19:47 ` [PATCH 4/5] Input: imx_keypad " Dmitry Torokhov
@ 2022-09-23 19:47 ` Dmitry Torokhov
2022-09-26 10:57 ` [PATCH 1/5] Input: lm8333 " Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 19:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-input; +Cc: linux-kernel
We are going to clean up matrix_keymap.h from unnecessary includes,
so the driver needs to include API that it uses directly.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/ep93xx_keypad.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
index 7a3b0664ab4f..f5bf7524722a 100644
--- a/drivers/input/keyboard/ep93xx_keypad.c
+++ b/drivers/input/keyboard/ep93xx_keypad.c
@@ -23,6 +23,7 @@
#include <linux/interrupt.h>
#include <linux/clk.h>
#include <linux/io.h>
+#include <linux/input.h>
#include <linux/input/matrix_keypad.h>
#include <linux/slab.h>
#include <linux/soc/cirrus/ep93xx.h>
--
2.37.3.998.g577e59143f-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5] Input: lm8333 - add missing linux/input.h include
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
` (3 preceding siblings ...)
2022-09-23 19:47 ` [PATCH 5/5] Input: ep93xx_keypad " Dmitry Torokhov
@ 2022-09-26 10:57 ` Andy Shevchenko
4 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2022-09-26 10:57 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel
On Fri, Sep 23, 2022 at 12:47:34PM -0700, Dmitry Torokhov wrote:
> We are going to clean up matrix_keymap.h from unnecessary includes,
> so the driver needs to include API that it uses directly.
>
> Also let's sort includes alphabetically and drop unneeded irq.h
For the entire series:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks for doing this!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-26 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 19:47 [PATCH 1/5] Input: lm8333 - add missing linux/input.h include Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 2/5] Input: st-keyscan - add missing linux/input.h and linux/of.h includes Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 3/5] Input: mt6779-keypad - add missing linux/input.h include Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 4/5] Input: imx_keypad " Dmitry Torokhov
2022-09-23 19:47 ` [PATCH 5/5] Input: ep93xx_keypad " Dmitry Torokhov
2022-09-26 10:57 ` [PATCH 1/5] Input: lm8333 " Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.