Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

[Guenter Roeck]

On Sat, Sep 24, 2022 at 11:28:52PM +0200, Uwe Kleine-König wrote:
> Declarations for static symbols are useless code repetition (unless
> there are cyclic dependencies).
> 
> Reorder some functions and variables which allows to get rid of 42
> forward declarations.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied to hwmon-next.

Thanks,
Guenter

Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]

On Sun, Sep 25, 2022 at 07:26:31AM -0700, Guenter Roeck wrote:
> On Sat, Sep 24, 2022 at 11:28:52PM +0200, Uwe Kleine-König wrote:
> > Declarations for static symbols are useless code repetition (unless
> > there are cyclic dependencies).
> > 
> > Reorder some functions and variables which allows to get rid of 42
> > forward declarations.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Applied to hwmon-next.

Thanks for your prompt action on my patches, very appreciated!

Let me just note two things:

a) vger refused to accept this mail with "Message too long (>100000
chars)", so I guess it won't appear in the archives

b) Your reply didn't have a "In-Reply-To:" header, so the threading is
broken. Because of a) you cannot see this in the archives, but it
happend already before, but not on all the mail I got from you. An
earlier instance is

	https://lore.kernel.org/linux-hwmon/20220923002301.GA1159397@roeck-us.net

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

[Guenter Roeck]

On 9/25/22 12:18, Uwe Kleine-König wrote:
> On Sun, Sep 25, 2022 at 07:26:31AM -0700, Guenter Roeck wrote:
>> On Sat, Sep 24, 2022 at 11:28:52PM +0200, Uwe Kleine-König wrote:
>>> Declarations for static symbols are useless code repetition (unless
>>> there are cyclic dependencies).
>>>
>>> Reorder some functions and variables which allows to get rid of 42
>>> forward declarations.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Applied to hwmon-next.
> 
> Thanks for your prompt action on my patches, very appreciated!
> 
> Let me just note two things:
> 
> a) vger refused to accept this mail with "Message too long (>100000
> chars)", so I guess it won't appear in the archives
> 

I guess that explains why I don't see all patches in patchwork.

> b) Your reply didn't have a "In-Reply-To:" header, so the threading is
> broken. Because of a) you cannot see this in the archives, but it
> happend already before, but not on all the mail I got from you. An
> earlier instance is
> 
> 	https://lore.kernel.org/linux-hwmon/20220923002301.GA1159397@roeck-us.net
> 

Some of the e-mails I reply from mutt, others from Thunderbird. I suspect
that one of them doesn't add the "In-Reply-To:" header. This one is from
Thunderbird. I'll send another one without Cc: from mutt. Please let me know
which one is missing the header.

Thanks,
Guenter

Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1959 bytes --]

Hello Guenter,

On Sun, Sep 25, 2022 at 12:50:55PM -0700, Guenter Roeck wrote:
> On 9/25/22 12:18, Uwe Kleine-König wrote:
> > On Sun, Sep 25, 2022 at 07:26:31AM -0700, Guenter Roeck wrote:
> > > On Sat, Sep 24, 2022 at 11:28:52PM +0200, Uwe Kleine-König wrote:
> > > > Declarations for static symbols are useless code repetition (unless
> > > > there are cyclic dependencies).
> > > > 
> > > > Reorder some functions and variables which allows to get rid of 42
> > > > forward declarations.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > 
> > > Applied to hwmon-next.
> > 
> > Thanks for your prompt action on my patches, very appreciated!
> > 
> > Let me just note two things:
> > 
> > a) vger refused to accept this mail with "Message too long (>100000
> > chars)", so I guess it won't appear in the archives
> 
> I guess that explains why I don't see all patches in patchwork.

The f71882fg was the first one of my patches that vger refused. I didn't
check, but vger at least didn't tell me about my other patches that it
refused any of them.

> > b) Your reply didn't have a "In-Reply-To:" header, so the threading is
> > broken. Because of a) you cannot see this in the archives, but it
> > happend already before, but not on all the mail I got from you. An
> > earlier instance is
> > 
> > 	https://lore.kernel.org/linux-hwmon/20220923002301.GA1159397@roeck-us.net
> > 
> 
> Some of the e-mails I reply from mutt, others from Thunderbird. I suspect
> that one of them doesn't add the "In-Reply-To:" header. This one is from
> Thunderbird. I'll send another one without Cc: from mutt. Please let me know
> which one is missing the header.

Both of these mails have the In-Reply-To header.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] hwmon: f71882fg: Reorder symbols to get rid of a few forward declarations

[Guenter Roeck]

On 9/26/22 00:03, Uwe Kleine-König wrote:
> Hello Guenter,
> 
> On Sun, Sep 25, 2022 at 12:50:55PM -0700, Guenter Roeck wrote:
>> On 9/25/22 12:18, Uwe Kleine-König wrote:
>>> On Sun, Sep 25, 2022 at 07:26:31AM -0700, Guenter Roeck wrote:
>>>> On Sat, Sep 24, 2022 at 11:28:52PM +0200, Uwe Kleine-König wrote:
>>>>> Declarations for static symbols are useless code repetition (unless
>>>>> there are cyclic dependencies).
>>>>>
>>>>> Reorder some functions and variables which allows to get rid of 42
>>>>> forward declarations.
>>>>>
>>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>>
>>>> Applied to hwmon-next.
>>>
>>> Thanks for your prompt action on my patches, very appreciated!
>>>
>>> Let me just note two things:
>>>
>>> a) vger refused to accept this mail with "Message too long (>100000
>>> chars)", so I guess it won't appear in the archives
>>
>> I guess that explains why I don't see all patches in patchwork.
> 
> The f71882fg was the first one of my patches that vger refused. I didn't
> check, but vger at least didn't tell me about my other patches that it
> refused any of them.
> 

Not of yours, but it happens once in a while that I don't see a patch there.
Though thinking about it they are not typically that large.

> 
> Both of these mails have the In-Reply-To header.
> 

Odd. No idea what causes it to get lost.

Guenter