All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties
@ 2022-05-25  0:46 ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2022-05-25  0:46 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck
  Cc: linux-watchdog, yuji2.ishikawa, linux-arm-kernel, linux-kernel,
	devicetree, Rob Herring, Krzysztof Kozlowski, Nobuhiro Iwamatsu,
	Rob Herring

The clock for this driver switched to the common clock controller driver.
Therefore, update common clock properties for watchdog in the binding document.
And this matched this example with the actual dts.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Acked-by: Rob Herring <robh@kernel.org>
---

 v3: doesn't remove timeout-sec.
 v2: send to linux-watchdog.

 .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
index 690e19ce4b87..eba083822d1f 100644
--- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
@@ -35,20 +35,16 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/toshiba,tmpv770x.h>
+
     soc {
         #address-cells = <2>;
         #size-cells = <2>;
 
-        wdt_clk: wdt-clk {
-            compatible = "fixed-clock";
-            clock-frequency = <150000000>;
-            #clock-cells = <0>;
-        };
-
-        watchdog@28330000 {
+        wdt: watchdog@28330000 {
             compatible = "toshiba,visconti-wdt";
             reg = <0 0x28330000 0 0x1000>;
-            clocks = <&wdt_clk>;
             timeout-sec = <20>;
+            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
         };
     };
-- 
2.36.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v3] dt-bindings: watchdog: toshiba, visconti-wdt: Update the common clock properties
@ 2022-05-25  0:46 ` Nobuhiro Iwamatsu
  0 siblings, 0 replies; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2022-05-25  0:46 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck
  Cc: linux-watchdog, yuji2.ishikawa, linux-arm-kernel, linux-kernel,
	devicetree, Rob Herring, Krzysztof Kozlowski, Nobuhiro Iwamatsu,
	Rob Herring

The clock for this driver switched to the common clock controller driver.
Therefore, update common clock properties for watchdog in the binding document.
And this matched this example with the actual dts.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Acked-by: Rob Herring <robh@kernel.org>
---

 v3: doesn't remove timeout-sec.
 v2: send to linux-watchdog.

 .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
index 690e19ce4b87..eba083822d1f 100644
--- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
@@ -35,20 +35,16 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/toshiba,tmpv770x.h>
+
     soc {
         #address-cells = <2>;
         #size-cells = <2>;
 
-        wdt_clk: wdt-clk {
-            compatible = "fixed-clock";
-            clock-frequency = <150000000>;
-            #clock-cells = <0>;
-        };
-
-        watchdog@28330000 {
+        wdt: watchdog@28330000 {
             compatible = "toshiba,visconti-wdt";
             reg = <0 0x28330000 0 0x1000>;
-            clocks = <&wdt_clk>;
             timeout-sec = <20>;
+            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
         };
     };
-- 
2.36.0



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties
  2022-05-25  0:46 ` [PATCH v3] dt-bindings: watchdog: toshiba, visconti-wdt: " Nobuhiro Iwamatsu
@ 2022-09-25 14:29   ` Guenter Roeck
  -1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-09-25 14:29 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Wim Van Sebroeck, linux-watchdog, yuji2.ishikawa,
	linux-arm-kernel, linux-kernel, devicetree, Rob Herring,
	Krzysztof Kozlowski, Rob Herring

On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
>  v3: doesn't remove timeout-sec.
>  v2: send to linux-watchdog.
> 
>  .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
>      soc {
>          #address-cells = <2>;
>          #size-cells = <2>;
>  
> -        wdt_clk: wdt-clk {
> -            compatible = "fixed-clock";
> -            clock-frequency = <150000000>;
> -            #clock-cells = <0>;
> -        };
> -
> -        watchdog@28330000 {
> +        wdt: watchdog@28330000 {
>              compatible = "toshiba,visconti-wdt";
>              reg = <0 0x28330000 0 0x1000>;
> -            clocks = <&wdt_clk>;
>              timeout-sec = <20>;
> +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
>          };
>      };

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties
@ 2022-09-25 14:29   ` Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-09-25 14:29 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu
  Cc: Wim Van Sebroeck, linux-watchdog, yuji2.ishikawa,
	linux-arm-kernel, linux-kernel, devicetree, Rob Herring,
	Krzysztof Kozlowski, Rob Herring

On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
>  v3: doesn't remove timeout-sec.
>  v2: send to linux-watchdog.
> 
>  .../bindings/watchdog/toshiba,visconti-wdt.yaml      | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
>      soc {
>          #address-cells = <2>;
>          #size-cells = <2>;
>  
> -        wdt_clk: wdt-clk {
> -            compatible = "fixed-clock";
> -            clock-frequency = <150000000>;
> -            #clock-cells = <0>;
> -        };
> -
> -        watchdog@28330000 {
> +        wdt: watchdog@28330000 {
>              compatible = "toshiba,visconti-wdt";
>              reg = <0 0x28330000 0 0x1000>;
> -            clocks = <&wdt_clk>;
>              timeout-sec = <20>;
> +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
>          };
>      };

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-25 14:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25  0:46 [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties Nobuhiro Iwamatsu
2022-05-25  0:46 ` [PATCH v3] dt-bindings: watchdog: toshiba, visconti-wdt: " Nobuhiro Iwamatsu
2022-09-25 14:29 ` [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: " Guenter Roeck
2022-09-25 14:29   ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.