[PATCH] gresolv: add missing include to fix clang-16 build

[PATCH] gresolv: add missing include to fix clang-16 build

[Ben Kohler]

Current compilers gcc-12 and clang-15 warn about an implicit function
declaration in gresolv.c, and this turns into a fatal error in clang-16
and eventually in future gcc.
---
 gweb/gresolv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gweb/gresolv.c b/gweb/gresolv.c
index 954e7cfe..7c58e055 100644
--- a/gweb/gresolv.c
+++ b/gweb/gresolv.c
@@ -36,6 +36,7 @@
 #include <arpa/inet.h>
 #include <arpa/nameser.h>
 #include <net/if.h>
+#include <cdefs.h>
 
 #include "gresolv.h"
 
-- 
2.37.3

Re: [PATCH] gresolv: add missing include to fix clang-16 build

[Daniel Wagner]

On Thu, Sep 22, 2022 at 10:45:17AM -0500, Ben Kohler wrote:
> Current compilers gcc-12 and clang-15 warn about an implicit function
> declaration in gresolv.c, and this turns into a fatal error in clang-16
> and eventually in future gcc.
> ---
>  gweb/gresolv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gweb/gresolv.c b/gweb/gresolv.c
> index 954e7cfe..7c58e055 100644
> --- a/gweb/gresolv.c
> +++ b/gweb/gresolv.c
> @@ -36,6 +36,7 @@
>  #include <arpa/inet.h>
>  #include <arpa/nameser.h>
>  #include <net/if.h>
> +#include <cdefs.h>

I use a gcc-12 compiler locally and don't get any warning. I suppose you are
passing additional build flags.

Anyway, this gives me:

gweb/gresolv.c:39:10: fatal error: cdefs.h: No such file or directory
   39 | #include <cdefs.h>
      |          ^~~~~~~~~

Is this supposed to be

#include <sys/cdefs.h> ?

Re: [PATCH] gresolv: add missing include to fix clang-16 build

[Kohler, Benjamin]

Sorry, I had a working patch but then submitted a different one based on 
gcc's warning message recommendation.  This should work better:

---
  gweb/gresolv.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/gweb/gresolv.c b/gweb/gresolv.c
index 954e7cfe..7c58e055 100644
--- a/gweb/gresolv.c
+++ b/gweb/gresolv.c
@@ -36,6 +36,7 @@
  #include <arpa/inet.h>
  #include <arpa/nameser.h>
  #include <net/if.h>
+#include <ctype.h>
  
  #include "gresolv.h"
  
-- 2.37.3

On 9/26/2022 1:21 AM, Daniel Wagner wrote:
> On Thu, Sep 22, 2022 at 10:45:17AM -0500, Ben Kohler wrote:
>> Current compilers gcc-12 and clang-15 warn about an implicit function
>> declaration in gresolv.c, and this turns into a fatal error in clang-16
>> and eventually in future gcc.
>> ---
>>   gweb/gresolv.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/gweb/gresolv.c b/gweb/gresolv.c
>> index 954e7cfe..7c58e055 100644
>> --- a/gweb/gresolv.c
>> +++ b/gweb/gresolv.c
>> @@ -36,6 +36,7 @@
>>   #include <arpa/inet.h>
>>   #include <arpa/nameser.h>
>>   #include <net/if.h>
>> +#include <cdefs.h>
> I use a gcc-12 compiler locally and don't get any warning. I suppose you are
> passing additional build flags.
>
> Anyway, this gives me:
>
> gweb/gresolv.c:39:10: fatal error: cdefs.h: No such file or directory
>     39 | #include <cdefs.h>
>        |          ^~~~~~~~~
>
> Is this supposed to be
>
> #include <sys/cdefs.h> ?
>

Re: [PATCH] gresolv: add missing include to fix clang-16 build

[Daniel Wagner]

On Tue, Sep 27, 2022 at 08:49:25AM -0500, Kohler, Benjamin wrote:
> Sorry, I had a working patch but then submitted a different one based on
> gcc's warning message recommendation.  This should work better:

Thanks! Patch applied!

Daniel