* [PATCH] drm/amdgpu: add VCN poison consumption handler for SRIOV
@ 2022-09-27 7:35 Tao Zhou
2022-09-27 9:36 ` Lazar, Lijo
0 siblings, 1 reply; 2+ messages in thread
From: Tao Zhou @ 2022-09-27 7:35 UTC (permalink / raw)
To: amd-gfx, hawking.zhang, stanley.yang, monk.liu, Victor.Skvortsov,
haijun.chang, Vignesh.Chander
Cc: Tao Zhou
Inform host and let host handle consumption interrupt.
Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index f36e4f08db6d..cb2885999219 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -1243,8 +1243,16 @@ int amdgpu_vcn_process_poison_irq(struct amdgpu_device *adev,
if (!ras_if)
return 0;
- ih_data.head = *ras_if;
- amdgpu_ras_interrupt_dispatch(adev, &ih_data);
+ if (!amdgpu_sriov_vf(adev)) {
+ ih_data.head = *ras_if;
+ amdgpu_ras_interrupt_dispatch(adev, &ih_data);
+ } else {
+ if (adev->virt.ops && adev->virt.ops->ras_poison_handler)
+ adev->virt.ops->ras_poison_handler(adev);
+ else
+ dev_warn(adev->dev,
+ "No ras_poison_handler interface in SRIOV for VCN!\n");
+ }
return 0;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: add VCN poison consumption handler for SRIOV
2022-09-27 7:35 [PATCH] drm/amdgpu: add VCN poison consumption handler for SRIOV Tao Zhou
@ 2022-09-27 9:36 ` Lazar, Lijo
0 siblings, 0 replies; 2+ messages in thread
From: Lazar, Lijo @ 2022-09-27 9:36 UTC (permalink / raw)
To: Tao Zhou, amd-gfx, hawking.zhang, stanley.yang, monk.liu,
Victor.Skvortsov, haijun.chang, Vignesh.Chander
On 9/27/2022 1:05 PM, Tao Zhou wrote:
> Inform host and let host handle consumption interrupt.
>
> Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> index f36e4f08db6d..cb2885999219 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> @@ -1243,8 +1243,16 @@ int amdgpu_vcn_process_poison_irq(struct amdgpu_device *adev,
> if (!ras_if)
> return 0;
>
> - ih_data.head = *ras_if;
> - amdgpu_ras_interrupt_dispatch(adev, &ih_data);
> + if (!amdgpu_sriov_vf(adev)) {
> + ih_data.head = *ras_if;
> + amdgpu_ras_interrupt_dispatch(adev, &ih_data);
> + } else {
> + if (adev->virt.ops && adev->virt.ops->ras_poison_handler)
> + adev->virt.ops->ras_poison_handler(adev);
> + else
> + dev_warn(adev->dev,
> + "No ras_poison_handler interface in SRIOV for VCN!\n");
> + }
>
As guest is not a trusted domain, I guess we need to get more clarity
about the final flow of events. Need to hold this.
Thanks,
Lijo
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-27 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 7:35 [PATCH] drm/amdgpu: add VCN poison consumption handler for SRIOV Tao Zhou
2022-09-27 9:36 ` Lazar, Lijo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.