* [PATCH] dmaengine: idxd: Remove unused struct idxd_fault
@ 2022-09-27 13:37 Yuan Can
2022-09-27 23:35 ` Yu, Fenghua
0 siblings, 1 reply; 3+ messages in thread
From: Yuan Can @ 2022-09-27 13:37 UTC (permalink / raw)
To: fenghua.yu, dave.jiang, vkoul, dmaengine; +Cc: yuancan
After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"), no
one use struct idxd_fault, so remove it.
Signed-off-by: Yuan Can <yuancan@huawei.com>
---
drivers/dma/idxd/irq.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index 5b9921475be6..6dc299182933 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -17,12 +17,6 @@ enum irq_work_type {
IRQ_WORK_PROCESS_FAULT,
};
-struct idxd_fault {
- struct work_struct work;
- u64 addr;
- struct idxd_device *idxd;
-};
-
struct idxd_resubmit {
struct work_struct work;
struct idxd_desc *desc;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dmaengine: idxd: Remove unused struct idxd_fault
2022-09-27 13:37 [PATCH] dmaengine: idxd: Remove unused struct idxd_fault Yuan Can
@ 2022-09-27 23:35 ` Yu, Fenghua
2022-09-28 1:46 ` Yuan Can
0 siblings, 1 reply; 3+ messages in thread
From: Yu, Fenghua @ 2022-09-27 23:35 UTC (permalink / raw)
To: Yuan Can, Jiang, Dave, vkoul, dmaengine
Hi, Yuan,
> After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"),
> no one use struct idxd_fault, so remove it.
How about this commit message?
Since fault processing code has been removed, struct idxd_fault is not used any more and can be removed as well.
Fixes: commit 0e96454ca26c ("dmaengine: idxd: remove fault processing code")
Thanks.
-Fenghua
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove unused struct idxd_fault
2022-09-27 23:35 ` Yu, Fenghua
@ 2022-09-28 1:46 ` Yuan Can
0 siblings, 0 replies; 3+ messages in thread
From: Yuan Can @ 2022-09-28 1:46 UTC (permalink / raw)
To: Yu, Fenghua, Jiang, Dave, vkoul, dmaengine
在 2022/9/28 7:35, Yu, Fenghua 写道:
> Hi, Yuan,
>
>> After commit 0e96454ca26c("dmaengine: idxd: remove fault processing code"),
>> no one use struct idxd_fault, so remove it.
> How about this commit message?
>
> Since fault processing code has been removed, struct idxd_fault is not used any more and can be removed as well.
>
> Fixes: commit 0e96454ca26c ("dmaengine: idxd: remove fault processing code")
Yes, this commit message seems better, let me resend with that.
thanks for your advice!
Best regards,
Yuan Can
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-28 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 13:37 [PATCH] dmaengine: idxd: Remove unused struct idxd_fault Yuan Can
2022-09-27 23:35 ` Yu, Fenghua
2022-09-28 1:46 ` Yuan Can
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.