* [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking
@ 2022-09-27 18:13 Niranjana Vishwanathapura
2022-09-28 3:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unwanted pointer unpacking (rev2) Patchwork
2022-09-28 21:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
0 siblings, 2 replies; 7+ messages in thread
From: Niranjana Vishwanathapura @ 2022-09-27 18:13 UTC (permalink / raw)
To: intel-gfx; +Cc: chris
In await_fence_array(), unpacking syncobj pointer is not needed.
Remove it.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index cd75b0ca2555..8f5796cf9c9c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
int err;
for (n = 0; n < eb->num_fences; n++) {
- struct drm_syncobj *syncobj;
- unsigned int flags;
-
- syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
-
if (!eb->fences[n].dma_fence)
continue;
--
2.21.0.rc0.32.g243a4c7e27
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unwanted pointer unpacking (rev2)
2022-09-27 18:13 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
@ 2022-09-28 3:52 ` Patchwork
2022-09-28 21:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
1 sibling, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-09-28 3:52 UTC (permalink / raw)
To: Niranjana Vishwanathapura; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5735 bytes --]
== Series Details ==
Series: drm/i915: Remove unwanted pointer unpacking (rev2)
URL : https://patchwork.freedesktop.org/series/109099/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109099v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/index.html
Participating hosts (44 -> 43)
------------------------------
Additional (1): fi-rkl-11600
Missing (2): fi-hsw-4770 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_109099v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][2] ([i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#3282])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][5] ([i915#5982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([fdo#111827]) +7 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#4103])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][8] -> [FAIL][9] ([i915#6298])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([fdo#109285] / [i915#4098])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#1072]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#4098])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([fdo#109295] / [i915#3301] / [i915#3708])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_12193 -> Patchwork_109099v2
CI-20190529: 20190529
CI_DRM_12193: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6666: 1e3ecbaa3c56f4c52c62047707eb4942d3a39c44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109099v2: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
275ea9e42c26 drm/i915: Remove unwanted pointer unpacking
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/index.html
[-- Attachment #2: Type: text/html, Size: 6853 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove unwanted pointer unpacking (rev2)
2022-09-27 18:13 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
2022-09-28 3:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unwanted pointer unpacking (rev2) Patchwork
@ 2022-09-28 21:12 ` Patchwork
1 sibling, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-09-28 21:12 UTC (permalink / raw)
To: Niranjana Vishwanathapura; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11062 bytes --]
== Series Details ==
Series: drm/i915: Remove unwanted pointer unpacking (rev2)
URL : https://patchwork.freedesktop.org/series/109099/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12193_full -> Patchwork_109099v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_109099v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-tglb8/igt@gem_exec_fair@basic-flow@rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb5/igt@gem_exec_fair@basic-pace@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][5] -> [SKIP][6] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-tglb3/igt@gem_huc_copy@huc-copy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-tglb7/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@perf@request:
- shard-iclb: [PASS][7] -> [DMESG-WARN][8] ([i915#2867]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb1/igt@i915_selftest@perf@request.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb1/igt@i915_selftest@perf@request.html
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-glk2/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][12] ([i915#6375])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][13] ([i915#2672]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#2672] / [i915#3555])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271]) +40 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][16] ([fdo#108145] / [i915#265])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][17] -> [SKIP][18] ([i915#5235]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb2/igt@kms_psr@psr2_primary_render.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb6/igt@kms_psr@psr2_primary_render.html
* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#2994]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl8/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][22] ([i915#4525]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb4/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][24] ([i915#2842]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [FAIL][26] ([i915#2842]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-glk6/igt@gem_exec_fair@basic-none@vecs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-glk8/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][28] ([i915#180]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-apl3/igt@gem_workarounds@suspend-resume.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-apl8/igt@gem_workarounds@suspend-resume.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][30] ([i915#79]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][32] ([i915#5235]) -> [PASS][33] +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb1/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][34] ([fdo#109441]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-iclb: [SKIP][36] ([i915#5519]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb7/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb4/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
#### Warnings ####
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][38] ([i915#658]) -> [SKIP][39] ([i915#2920])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb4/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][40] ([i915#2920]) -> [SKIP][41] ([i915#658]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12193/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12193 -> Patchwork_109099v2
CI-20190529: 20190529
CI_DRM_12193: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6666: 1e3ecbaa3c56f4c52c62047707eb4942d3a39c44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109099v2: 0f0716dcfd8446cde4391475c9c3656ca670b55f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109099v2/index.html
[-- Attachment #2: Type: text/html, Size: 12993 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking
2022-09-27 6:52 ` Jani Nikula
@ 2022-09-27 18:20 ` Niranjana Vishwanathapura
0 siblings, 0 replies; 7+ messages in thread
From: Niranjana Vishwanathapura @ 2022-09-27 18:20 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, chris
On Tue, Sep 27, 2022 at 09:52:46AM +0300, Jani Nikula wrote:
>On Mon, 26 Sep 2022, Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> wrote:
>> In await_fence_array(), unpacking syncobj pointer is not needed.
>> Remove it.
>
>Where are we with the goal of getting rid of all of ptr_pack_bits(),
>ptr_unpack_bits(), ptr_mask_bits() and ptr_unmask_bits()?
>
I am not sure, I just noticed this unwanted code while working on
VM_BIND patch series.
Regards,
Niranjana
>BR,
>Jani.
>
>
>>
>> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
>> ---
>> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> index cd75b0ca2555..8f5796cf9c9c 100644
>> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>> @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
>> int err;
>>
>> for (n = 0; n < eb->num_fences; n++) {
>> - struct drm_syncobj *syncobj;
>> - unsigned int flags;
>> -
>> - syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
>> -
>> if (!eb->fences[n].dma_fence)
>> continue;
>
>--
>Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking
2022-09-27 5:40 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
2022-09-27 6:52 ` Jani Nikula
@ 2022-09-27 7:34 ` Tvrtko Ursulin
1 sibling, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2022-09-27 7:34 UTC (permalink / raw)
To: Niranjana Vishwanathapura, intel-gfx; +Cc: chris
On 27/09/2022 06:40, Niranjana Vishwanathapura wrote:
> In await_fence_array(), unpacking syncobj pointer is not needed.
> Remove it.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index cd75b0ca2555..8f5796cf9c9c 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
> int err;
>
> for (n = 0; n < eb->num_fences; n++) {
> - struct drm_syncobj *syncobj;
> - unsigned int flags;
> -
> - syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
> -
Seems it was left hanging unused since 13149e8bafc4 ("drm/i915: add
syncobj timeline support").
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
> if (!eb->fences[n].dma_fence)
> continue;
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking
2022-09-27 5:40 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
@ 2022-09-27 6:52 ` Jani Nikula
2022-09-27 18:20 ` Niranjana Vishwanathapura
2022-09-27 7:34 ` Tvrtko Ursulin
1 sibling, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2022-09-27 6:52 UTC (permalink / raw)
To: Niranjana Vishwanathapura, intel-gfx; +Cc: chris
On Mon, 26 Sep 2022, Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com> wrote:
> In await_fence_array(), unpacking syncobj pointer is not needed.
> Remove it.
Where are we with the goal of getting rid of all of ptr_pack_bits(),
ptr_unpack_bits(), ptr_mask_bits() and ptr_unmask_bits()?
BR,
Jani.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index cd75b0ca2555..8f5796cf9c9c 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
> int err;
>
> for (n = 0; n < eb->num_fences; n++) {
> - struct drm_syncobj *syncobj;
> - unsigned int flags;
> -
> - syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
> -
> if (!eb->fences[n].dma_fence)
> continue;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking
@ 2022-09-27 5:40 Niranjana Vishwanathapura
2022-09-27 6:52 ` Jani Nikula
2022-09-27 7:34 ` Tvrtko Ursulin
0 siblings, 2 replies; 7+ messages in thread
From: Niranjana Vishwanathapura @ 2022-09-27 5:40 UTC (permalink / raw)
To: intel-gfx; +Cc: chris
In await_fence_array(), unpacking syncobj pointer is not needed.
Remove it.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
index cd75b0ca2555..8f5796cf9c9c 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
@@ -2954,11 +2954,6 @@ await_fence_array(struct i915_execbuffer *eb,
int err;
for (n = 0; n < eb->num_fences; n++) {
- struct drm_syncobj *syncobj;
- unsigned int flags;
-
- syncobj = ptr_unpack_bits(eb->fences[n].syncobj, &flags, 2);
-
if (!eb->fences[n].dma_fence)
continue;
--
2.21.0.rc0.32.g243a4c7e27
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-28 21:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 18:13 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
2022-09-28 3:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unwanted pointer unpacking (rev2) Patchwork
2022-09-28 21:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 5:40 [Intel-gfx] [PATCH] drm/i915: Remove unwanted pointer unpacking Niranjana Vishwanathapura
2022-09-27 6:52 ` Jani Nikula
2022-09-27 18:20 ` Niranjana Vishwanathapura
2022-09-27 7:34 ` Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.