* [PATCH] scsi: ufs: Remove unneeded casts from void *
@ 2022-09-28 21:36 Markus Fuchs
0 siblings, 0 replies; 4+ messages in thread
From: Markus Fuchs @ 2022-09-28 21:36 UTC (permalink / raw)
To: kernel-janitors; +Cc: Markus Fuchs
The end_io_data member of the "struct request" type has type "void *", so no
cast is necessary.
Signed-off-by: Markus Fuchs <mklntf@gmail.com>
---
Hello,
I try to follow the guide on https://kernelnewbies.org/KernelJanitors/Todo and
therefor send this patch.
Regards,
Markus
drivers/ufs/core/ufshpb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c
index a1a7a1175a5a..0ce5063bedc5 100644
--- a/drivers/ufs/core/ufshpb.c
+++ b/drivers/ufs/core/ufshpb.c
@@ -615,14 +615,14 @@ static void ufshpb_activate_subregion(struct ufshpb_lu *hpb,
static void ufshpb_umap_req_compl_fn(struct request *req, blk_status_t error)
{
- struct ufshpb_req *umap_req = (struct ufshpb_req *)req->end_io_data;
+ struct ufshpb_req *umap_req = req->end_io_data;
ufshpb_put_req(umap_req->hpb, umap_req);
}
static void ufshpb_map_req_compl_fn(struct request *req, blk_status_t error)
{
- struct ufshpb_req *map_req = (struct ufshpb_req *) req->end_io_data;
+ struct ufshpb_req *map_req = req->end_io_data;
struct ufshpb_lu *hpb = map_req->hpb;
struct ufshpb_subregion *srgn;
unsigned long flags;
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: Remove unneeded casts from void *
2022-09-28 22:22 Markus Fuchs
2022-09-30 18:04 ` Bart Van Assche
@ 2022-10-01 9:58 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-10-01 9:58 UTC (permalink / raw)
To: Markus Fuchs
Cc: jejb, martin.petersen, alim.akhtar, avri.altman, bvanassche,
linux-scsi, linux-kernel, kernel-janitors
Markus,
> The end_io_data member of the "struct request" type has type "void *",
> so no cast is necessary.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: Remove unneeded casts from void *
2022-09-28 22:22 Markus Fuchs
@ 2022-09-30 18:04 ` Bart Van Assche
2022-10-01 9:58 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2022-09-30 18:04 UTC (permalink / raw)
To: Markus Fuchs, jejb, martin.petersen
Cc: alim.akhtar, avri.altman, linux-scsi, linux-kernel, kernel-janitors
On 9/28/22 15:22, Markus Fuchs wrote:
> The end_io_data member of the "struct request" type has type "void *", so no
> cast is necessary.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] scsi: ufs: Remove unneeded casts from void *
@ 2022-09-28 22:22 Markus Fuchs
2022-09-30 18:04 ` Bart Van Assche
2022-10-01 9:58 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Markus Fuchs @ 2022-09-28 22:22 UTC (permalink / raw)
To: jejb, martin.petersen
Cc: alim.akhtar, avri.altman, bvanassche, linux-scsi, linux-kernel,
kernel-janitors, Markus Fuchs
The end_io_data member of the "struct request" type has type "void *", so no
cast is necessary.
Signed-off-by: Markus Fuchs <mklntf@gmail.com>
---
drivers/ufs/core/ufshpb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ufs/core/ufshpb.c b/drivers/ufs/core/ufshpb.c
index a1a7a1175a5a..0ce5063bedc5 100644
--- a/drivers/ufs/core/ufshpb.c
+++ b/drivers/ufs/core/ufshpb.c
@@ -615,14 +615,14 @@ static void ufshpb_activate_subregion(struct ufshpb_lu *hpb,
static void ufshpb_umap_req_compl_fn(struct request *req, blk_status_t error)
{
- struct ufshpb_req *umap_req = (struct ufshpb_req *)req->end_io_data;
+ struct ufshpb_req *umap_req = req->end_io_data;
ufshpb_put_req(umap_req->hpb, umap_req);
}
static void ufshpb_map_req_compl_fn(struct request *req, blk_status_t error)
{
- struct ufshpb_req *map_req = (struct ufshpb_req *) req->end_io_data;
+ struct ufshpb_req *map_req = req->end_io_data;
struct ufshpb_lu *hpb = map_req->hpb;
struct ufshpb_subregion *srgn;
unsigned long flags;
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-01 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 21:36 [PATCH] scsi: ufs: Remove unneeded casts from void * Markus Fuchs
2022-09-28 22:22 Markus Fuchs
2022-09-30 18:04 ` Bart Van Assche
2022-10-01 9:58 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.