From: Jakub Kicinski <kuba@kernel.org>
To: jianghaoran <jianghaoran@kylinos.cn>
Cc: vinicius.gomes@intel.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] taprio: Set the value of picos_per_byte before fill sched_entry
Date: Thu, 29 Sep 2022 19:18:15 -0700 [thread overview]
Message-ID: <20220929191815.51362581@kernel.org> (raw)
In-Reply-To: <20220928065830.1544954-1-jianghaoran@kylinos.cn>
On Wed, 28 Sep 2022 14:58:30 +0800 jianghaoran wrote:
> If the value of picos_per_byte is set after fill sched_entry,
> as a result, the min_duration calculated by length_to_duration is 0,
> and the validity of the input interval cannot be judged,
> too small intervals couldn't allow any packet to be transmitted.
Meaning an invalid configuration is accepted but no packets
can ever be transmitted? Could you make the user-visible
issue clearer?
> It will appear like commit b5b73b26b3ca ("taprio:
> Fix allowing too small intervals") described problem.
> Here is a further modification of this problem.
>
> example:
Here as well it seems worthwhile to mention what this is an example of.
e.g. "example configuration which will not be able to transmit packets"
> tc qdisc replace dev enp5s0f0 parent root handle 100 taprio \
> num_tc 3 \
> map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
> queues 1@0 1@1 2@2 \
> base-time 1528743495910289987 \
> sched-entry S 01 9 \
> sched-entry S 02 9 \
> sched-entry S 04 9 \
> clockid CLOCK_TAI
Please add a Fixes tag pointing to the first commit where the issue was
present, and CC Vladimir Oltean <vladimir.oltean@nxp.com> on the next
version.
next prev parent reply other threads:[~2022-09-30 2:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 6:58 [PATCH] taprio: Set the value of picos_per_byte before fill sched_entry jianghaoran
2022-09-30 2:18 ` Jakub Kicinski [this message]
2022-09-30 11:18 ` jianghaoran
2022-09-30 13:46 ` jianghaoran
2022-09-30 13:58 ` test jianghaoran
2022-09-30 14:16 ` [PATCH] taprio: Set the value of picos_per_byte before fill sched_entry jianghaoran
2022-10-01 0:42 ` jianghaoran
2022-10-01 0:44 ` jianghaoran
2022-10-01 0:49 ` jianghaoran
2022-10-01 0:57 ` jianghaoran
2022-10-01 0:59 ` jianghaoran
2022-10-01 1:10 ` jianghaoran
2022-10-01 1:17 ` jianghaoran
2022-10-01 1:23 ` jianghaoran
2022-10-01 7:48 ` [PATCH V2] " jianghaoran
2022-10-01 7:51 ` jianghaoran
2022-10-01 7:51 ` jianghaoran
2022-10-01 7:53 ` jianghaoran
2022-10-01 8:00 ` jianghaoran
2022-10-01 8:06 ` jianghaoran
2022-10-01 11:44 ` Vladimir Oltean
2022-10-03 15:08 ` Jakub Kicinski
2022-10-01 8:29 ` jianghaoran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929191815.51362581@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jianghaoran@kylinos.cn \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.