All of lore.kernel.org
 help / color / mirror / Atom feed
From: jianghaoran <jianghaoran@kylinos.cn>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: [PATCH V2] taprio: Set the value of picos_per_byte before fill sched_entry
Date: Sat,  1 Oct 2022 16:00:25 +0800	[thread overview]
Message-ID: <20221001080025.458519-1-jianghaoran@kylinos.cn> (raw)
In-Reply-To: <20220928065830.1544954-1-jianghaoran@kylinos.cn>

If the value of picos_per_byte is set after fill sched_entry,
as a result, the min_duration calculated by length_to_duration is 0,
and the validity of the input interval cannot be judged,
too small intervals couldn't allow any packet to be transmitted.
It will appear like commit b5b73b26b3ca ("taprio:
Fix allowing too small intervals") described problem.
Here is a further modification of this problem.

example configuration which will not be able to transmit:

tc qdisc replace dev enp5s0f0 parent root handle 100 taprio \
              num_tc 3 \
              map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
              queues 1@0 1@1 2@2 \
              base-time  1528743495910289987 \
              sched-entry S 01 9 \
	      sched-entry S 02 9 \
	      sched-entry S 04 9 \
              clockid CLOCK_TAI

Fixes: b5b73b26b3ca ("taprio: Fix allowing too small intervals")
Signed-off-by: jianghaoran <jianghaoran@kylinos.cn>
---
v2:
1,Add an explanation of what this is an example.
2,add a Fixes tag pointing to the first commit
where the issue was presen.
---
 net/sched/sch_taprio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c
index 86675a79da1e..d95ec2250f24 100644
--- a/net/sched/sch_taprio.c
+++ b/net/sched/sch_taprio.c
@@ -1507,6 +1507,8 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
 		goto free_sched;
 	}
 
+	taprio_set_picos_per_byte(dev, q);
+
 	err = parse_taprio_schedule(q, tb, new_admin, extack);
 	if (err < 0)
 		goto free_sched;
@@ -1521,8 +1523,6 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt,
 	if (err < 0)
 		goto free_sched;
 
-	taprio_set_picos_per_byte(dev, q);
-
 	if (mqprio) {
 		err = netdev_set_num_tc(dev, mqprio->num_tc);
 		if (err)
-- 
2.25.1


  parent reply	other threads:[~2022-10-01  8:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  6:58 [PATCH] taprio: Set the value of picos_per_byte before fill sched_entry jianghaoran
2022-09-30  2:18 ` Jakub Kicinski
2022-09-30 11:18   ` jianghaoran
2022-09-30 13:46   ` jianghaoran
2022-09-30 13:58   ` test jianghaoran
2022-09-30 14:16   ` [PATCH] taprio: Set the value of picos_per_byte before fill sched_entry jianghaoran
2022-10-01  0:42   ` jianghaoran
2022-10-01  0:44     ` jianghaoran
2022-10-01  0:49     ` jianghaoran
2022-10-01  0:57     ` jianghaoran
2022-10-01  0:59     ` jianghaoran
2022-10-01  1:10 ` jianghaoran
2022-10-01  1:17 ` jianghaoran
2022-10-01  1:23 ` jianghaoran
2022-10-01  7:48 ` [PATCH V2] " jianghaoran
2022-10-01  7:51 ` jianghaoran
2022-10-01  7:51 ` jianghaoran
2022-10-01  7:53 ` jianghaoran
2022-10-01  8:00 ` jianghaoran [this message]
2022-10-01  8:06 ` jianghaoran
2022-10-01 11:44   ` Vladimir Oltean
2022-10-03 15:08   ` Jakub Kicinski
2022-10-01  8:29 ` jianghaoran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221001080025.458519-1-jianghaoran@kylinos.cn \
    --to=jianghaoran@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.