All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: imx93: correct the flexspi1 clock setting
@ 2022-09-30  6:02 haibo.chen
  2022-09-30  6:24 ` Peng Fan
  2022-09-30 21:38 ` Stephen Boyd
  0 siblings, 2 replies; 4+ messages in thread
From: haibo.chen @ 2022-09-30  6:02 UTC (permalink / raw)
  To: abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel
  Cc: festevam, linux-clk, linux-imx, haibo.chen, peng.fan, ping.bai

From: Haibo Chen <haibo.chen@nxp.com>

Correct IMX93_CLK_FLEXSPI1_GATE CCGR setting. Otherwise the flexspi
always can't be assigned to a parent clock when dump the clock tree.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/clk/imx/clk-imx93.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
index 99cff1fd108b..40ecee3b5e78 100644
--- a/drivers/clk/imx/clk-imx93.c
+++ b/drivers/clk/imx/clk-imx93.c
@@ -170,7 +170,7 @@ static const struct imx93_clk_ccgr {
 	{ IMX93_CLK_MU2_B_GATE,		"mu2_b",	"bus_wakeup_root",	0x8500, 0, &share_count_mub },
 	{ IMX93_CLK_EDMA1_GATE,		"edma1",	"m33_root",		0x8540, },
 	{ IMX93_CLK_EDMA2_GATE,		"edma2",	"wakeup_axi_root",	0x8580, },
-	{ IMX93_CLK_FLEXSPI1_GATE,	"flexspi",	"flexspi_root",		0x8640, },
+	{ IMX93_CLK_FLEXSPI1_GATE,	"flexspi1",	"flexspi1_root",	0x8640, },
 	{ IMX93_CLK_GPIO1_GATE,		"gpio1",	"m33_root",		0x8880, },
 	{ IMX93_CLK_GPIO2_GATE,		"gpio2",	"bus_wakeup_root",	0x88c0, },
 	{ IMX93_CLK_GPIO3_GATE,		"gpio3",	"bus_wakeup_root",	0x8900, },
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] clk: imx93: correct the flexspi1 clock setting
  2022-09-30  6:02 [PATCH] clk: imx93: correct the flexspi1 clock setting haibo.chen
@ 2022-09-30  6:24 ` Peng Fan
  2022-09-30 21:38 ` Stephen Boyd
  1 sibling, 0 replies; 4+ messages in thread
From: Peng Fan @ 2022-09-30  6:24 UTC (permalink / raw)
  To: Bough Chen, abelvesa, mturquette, sboyd, shawnguo, s.hauer, kernel
  Cc: festevam, linux-clk, dl-linux-imx, Bough Chen, Jacky Bai

> Subject: [PATCH] clk: imx93: correct the flexspi1 clock setting
> 
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Correct IMX93_CLK_FLEXSPI1_GATE CCGR setting. Otherwise the flexspi
> always can't be assigned to a parent clock when dump the clock tree.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Regards,
Peng.

> ---
>  drivers/clk/imx/clk-imx93.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c index
> 99cff1fd108b..40ecee3b5e78 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -170,7 +170,7 @@ static const struct imx93_clk_ccgr {
>  	{ IMX93_CLK_MU2_B_GATE,		"mu2_b",
> 	"bus_wakeup_root",	0x8500, 0, &share_count_mub },
>  	{ IMX93_CLK_EDMA1_GATE,		"edma1",	"m33_root",
> 		0x8540, },
>  	{ IMX93_CLK_EDMA2_GATE,		"edma2",
> 	"wakeup_axi_root",	0x8580, },
> -	{ IMX93_CLK_FLEXSPI1_GATE,	"flexspi",	"flexspi_root",
> 	0x8640, },
> +	{ IMX93_CLK_FLEXSPI1_GATE,	"flexspi1",	"flexspi1_root",
> 	0x8640, },
>  	{ IMX93_CLK_GPIO1_GATE,		"gpio1",	"m33_root",
> 		0x8880, },
>  	{ IMX93_CLK_GPIO2_GATE,		"gpio2",
> 	"bus_wakeup_root",	0x88c0, },
>  	{ IMX93_CLK_GPIO3_GATE,		"gpio3",
> 	"bus_wakeup_root",	0x8900, },
> --
> 2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx93: correct the flexspi1 clock setting
  2022-09-30  6:02 [PATCH] clk: imx93: correct the flexspi1 clock setting haibo.chen
  2022-09-30  6:24 ` Peng Fan
@ 2022-09-30 21:38 ` Stephen Boyd
  2022-10-09  3:11   ` Bough Chen
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2022-09-30 21:38 UTC (permalink / raw)
  To: abelvesa, haibo.chen, kernel, mturquette, s.hauer, shawnguo
  Cc: festevam, linux-clk, linux-imx, haibo.chen, peng.fan, ping.bai

Quoting haibo.chen@nxp.com (2022-09-29 23:02:39)
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> Correct IMX93_CLK_FLEXSPI1_GATE CCGR setting. Otherwise the flexspi
> always can't be assigned to a parent clock when dump the clock tree.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---

Any Fixes tag?

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] clk: imx93: correct the flexspi1 clock setting
  2022-09-30 21:38 ` Stephen Boyd
@ 2022-10-09  3:11   ` Bough Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Bough Chen @ 2022-10-09  3:11 UTC (permalink / raw)
  To: Stephen Boyd, abelvesa, kernel, mturquette, s.hauer, shawnguo
  Cc: festevam, linux-clk, dl-linux-imx, Peng Fan, Jacky Bai

> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: 2022年10月1日 5:38
> To: abelvesa@kernel.org; Bough Chen <haibo.chen@nxp.com>;
> kernel@pengutronix.de; mturquette@baylibre.com; s.hauer@pengutronix.de;
> shawnguo@kernel.org
> Cc: festevam@gmail.com; linux-clk@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; Bough Chen <haibo.chen@nxp.com>; Peng Fan
> <peng.fan@nxp.com>; Jacky Bai <ping.bai@nxp.com>
> Subject: Re: [PATCH] clk: imx93: correct the flexspi1 clock setting
> 
> Quoting haibo.chen@nxp.com (2022-09-29 23:02:39)
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > Correct IMX93_CLK_FLEXSPI1_GATE CCGR setting. Otherwise the flexspi
> > always can't be assigned to a parent clock when dump the clock tree.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> 
> Any Fixes tag?

Oh, sorry. The fixes tag should be:
Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")

Should I send a v2 patch with this fixes tag?

Best Regards
Haibo Chen

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-09  3:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30  6:02 [PATCH] clk: imx93: correct the flexspi1 clock setting haibo.chen
2022-09-30  6:24 ` Peng Fan
2022-09-30 21:38 ` Stephen Boyd
2022-10-09  3:11   ` Bough Chen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.