All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO
@ 2022-09-29  6:29 Randy Dunlap
  2022-10-01 20:16 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-09-29  6:29 UTC (permalink / raw)
  To: linux-kernel; +Cc: Randy Dunlap, ChiaEn Wu, Sebastian Reichel, linux-pm

The mt6370-charger driver uses IIO interfaces and produces build
errors when CONFIG_IIO is not set, so it should depend on IIO.

ERROR: modpost: "iio_read_channel_processed" [drivers/power/supply/mt6370-charger.ko] undefined!
ERROR: modpost: "devm_iio_channel_get_all" [drivers/power/supply/mt6370-charger.ko] undefined!

Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: ChiaEn Wu <chiaen_wu@richtek.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-pm@vger.kernel.org
---
 drivers/power/supply/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -623,6 +623,7 @@ config CHARGER_MT6370
 	tristate "MediaTek MT6370 Charger Driver"
 	depends on MFD_MT6370
 	depends on REGULATOR
+	depends on IIO
 	select LINEAR_RANGES
 	help
 	  Say Y here to enable MT6370 Charger Part.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO
  2022-09-29  6:29 [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO Randy Dunlap
@ 2022-10-01 20:16 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2022-10-01 20:16 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-kernel, ChiaEn Wu, linux-pm

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi,

On Wed, Sep 28, 2022 at 11:29:40PM -0700, Randy Dunlap wrote:
> The mt6370-charger driver uses IIO interfaces and produces build
> errors when CONFIG_IIO is not set, so it should depend on IIO.
> 
> ERROR: modpost: "iio_read_channel_processed" [drivers/power/supply/mt6370-charger.ko] undefined!
> ERROR: modpost: "devm_iio_channel_get_all" [drivers/power/supply/mt6370-charger.ko] undefined!
> 
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: ChiaEn Wu <chiaen_wu@richtek.com>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> Cc: linux-pm@vger.kernel.org
> ---
>  drivers/power/supply/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
>  	tristate "MediaTek MT6370 Charger Driver"
>  	depends on MFD_MT6370
>  	depends on REGULATOR
> +	depends on IIO
>  	select LINEAR_RANGES
>  	help
>  	  Say Y here to enable MT6370 Charger Part.

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-01 20:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29  6:29 [PATCH] power: supply: mt6370: uses IIO interfaces, depends on IIO Randy Dunlap
2022-10-01 20:16 ` Sebastian Reichel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.