* [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe()
@ 2022-09-21 15:29 Yang Yingliang
2022-09-22 1:42 ` ChiaEn Wu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yang Yingliang @ 2022-09-21 15:29 UTC (permalink / raw)
To: linux-pm, linux-mediatek; +Cc: sre, chiaen_wu
If create_singlethread_workqueue() fails, it returns a null pointer,
replace IS_ERR() check with NULL pointer check.
Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/power/supply/mt6370-charger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
index 716cba259a7a..f27dae5043f5 100644
--- a/drivers/power/supply/mt6370-charger.c
+++ b/drivers/power/supply/mt6370-charger.c
@@ -911,8 +911,8 @@ static int mt6370_chg_probe(struct platform_device *pdev)
priv->attach = MT6370_ATTACH_STAT_DETACH;
priv->wq = create_singlethread_workqueue(dev_name(priv->dev));
- if (IS_ERR(priv->wq))
- return dev_err_probe(dev, PTR_ERR(priv->wq),
+ if (!priv->wq)
+ return dev_err_probe(dev, -ENOMEM,
"Failed to create workqueue\n");
ret = devm_add_action_or_reset(dev, mt6370_chg_destroy_wq, priv->wq);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe()
2022-09-21 15:29 [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe() Yang Yingliang
@ 2022-09-22 1:42 ` ChiaEn Wu
2022-09-22 7:25 ` AngeloGioacchino Del Regno
2022-10-01 20:22 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: ChiaEn Wu @ 2022-09-22 1:42 UTC (permalink / raw)
To: Yang Yingliang, linux-pm, linux-mediatek; +Cc: sre, chiaen_wu
On 9/21/2022 11:29 PM, Yang Yingliang wrote:
> If create_singlethread_workqueue() fails, it returns a null pointer,
> replace IS_ERR() check with NULL pointer check.
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/power/supply/mt6370-charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
> index 716cba259a7a..f27dae5043f5 100644
> --- a/drivers/power/supply/mt6370-charger.c
> +++ b/drivers/power/supply/mt6370-charger.c
> @@ -911,8 +911,8 @@ static int mt6370_chg_probe(struct platform_device *pdev)
> priv->attach = MT6370_ATTACH_STAT_DETACH;
>
> priv->wq = create_singlethread_workqueue(dev_name(priv->dev));
> - if (IS_ERR(priv->wq))
> - return dev_err_probe(dev, PTR_ERR(priv->wq),
> + if (!priv->wq)
> + return dev_err_probe(dev, -ENOMEM,
> "Failed to create workqueue\n");
>
> ret = devm_add_action_or_reset(dev, mt6370_chg_destroy_wq, priv->wq);
Hi Yingliang,
In general this looks good to me. Thanks for catching this!
Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
--
Best Regards,
ChiaEn Wu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe()
2022-09-21 15:29 [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe() Yang Yingliang
2022-09-22 1:42 ` ChiaEn Wu
@ 2022-09-22 7:25 ` AngeloGioacchino Del Regno
2022-10-01 20:22 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-09-22 7:25 UTC (permalink / raw)
To: Yang Yingliang, linux-pm, linux-mediatek; +Cc: sre, chiaen_wu
Il 21/09/22 17:29, Yang Yingliang ha scritto:
> If create_singlethread_workqueue() fails, it returns a null pointer,
> replace IS_ERR() check with NULL pointer check.
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe()
2022-09-21 15:29 [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe() Yang Yingliang
2022-09-22 1:42 ` ChiaEn Wu
2022-09-22 7:25 ` AngeloGioacchino Del Regno
@ 2022-10-01 20:22 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2022-10-01 20:22 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-pm, linux-mediatek, chiaen_wu
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
Hi,
On Wed, Sep 21, 2022 at 11:29:15PM +0800, Yang Yingliang wrote:
> If create_singlethread_workqueue() fails, it returns a null pointer,
> replace IS_ERR() check with NULL pointer check.
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/power/supply/mt6370-charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
> index 716cba259a7a..f27dae5043f5 100644
> --- a/drivers/power/supply/mt6370-charger.c
> +++ b/drivers/power/supply/mt6370-charger.c
> @@ -911,8 +911,8 @@ static int mt6370_chg_probe(struct platform_device *pdev)
> priv->attach = MT6370_ATTACH_STAT_DETACH;
>
> priv->wq = create_singlethread_workqueue(dev_name(priv->dev));
> - if (IS_ERR(priv->wq))
> - return dev_err_probe(dev, PTR_ERR(priv->wq),
> + if (!priv->wq)
> + return dev_err_probe(dev, -ENOMEM,
> "Failed to create workqueue\n");
>
> ret = devm_add_action_or_reset(dev, mt6370_chg_destroy_wq, priv->wq);
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-01 20:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 15:29 [PATCH -next] power: supply: mt6370: Fix return value check in mt6370_chg_probe() Yang Yingliang
2022-09-22 1:42 ` ChiaEn Wu
2022-09-22 7:25 ` AngeloGioacchino Del Regno
2022-10-01 20:22 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.