All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot
@ 2022-10-03 13:39 Fabio Estevam
  2022-10-03 13:56 ` Michael Nazzareno Trimarchi
  2022-10-21 11:41 ` sbabic
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-10-03 13:39 UTC (permalink / raw)
  To: trini; +Cc: sbabic, u-boot, Fabio Estevam

When the imx8mm.dtsi file was pulled in from Linux, the UARTs
were moved into an spba sub-node which wasn't being included
in the SPL device tree.  This meant the references to the UART
weren't being handled properly and when booting the system would
constantly reboot.  Fix this by adding the spba node to the spl
device tree to restore normal booting.

Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot
board.

Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Hi Tom and Stefano,

I know today is release day. Could this one be applied directly?

It fixes a boot regression.

Thanks

 arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
index 78773c198e..3a9ba8b8c9 100644
--- a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
@@ -26,6 +26,10 @@
 	u-boot,dm-spl;
 };
 
+&spba1 {
+	u-boot,dm-spl;
+};
+
 &clk {
 	u-boot,dm-spl;
 	u-boot,dm-pre-reloc;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot
  2022-10-03 13:39 [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot Fabio Estevam
@ 2022-10-03 13:56 ` Michael Nazzareno Trimarchi
  2022-10-21 11:41 ` sbabic
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Nazzareno Trimarchi @ 2022-10-03 13:56 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: trini, sbabic, u-boot

On Mon, Oct 3, 2022 at 3:39 PM Fabio Estevam <festevam@denx.de> wrote:
>
> When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> were moved into an spba sub-node which wasn't being included
> in the SPL device tree.  This meant the references to the UART
> weren't being handled properly and when booting the system would
> constantly reboot.  Fix this by adding the spba node to the spl
> device tree to restore normal booting.
>
> Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot
> board.
>
> Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Hi Tom and Stefano,
>
> I know today is release day. Could this one be applied directly?
>
> It fixes a boot regression.
>
> Thanks
>
>  arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> index 78773c198e..3a9ba8b8c9 100644
> --- a/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi
> @@ -26,6 +26,10 @@
>         u-boot,dm-spl;
>  };
>
> +&spba1 {
> +       u-boot,dm-spl;
> +};
> +

Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>

>  &clk {
>         u-boot,dm-spl;
>         u-boot,dm-pre-reloc;
> --
> 2.25.1
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot
  2022-10-03 13:39 [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot Fabio Estevam
  2022-10-03 13:56 ` Michael Nazzareno Trimarchi
@ 2022-10-21 11:41 ` sbabic
  1 sibling, 0 replies; 3+ messages in thread
From: sbabic @ 2022-10-21 11:41 UTC (permalink / raw)
  To: Fabio Estevam, u-boot

> When the imx8mm.dtsi file was pulled in from Linux, the UARTs
> were moved into an spba sub-node which wasn't being included
> in the SPL device tree.  This meant the references to the UART
> weren't being handled properly and when booting the system would
> constantly reboot.  Fix this by adding the spba node to the spl
> device tree to restore normal booting.
> Based on the patch from Adam Ford for the imx8mn-beacon-kit-u-boot
> board.
> Fixes: 4e5114daf9eb ("imx8mn: synchronise device tree with linux")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-21 11:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 13:39 [PATCH] imx8mn-ddr4-evk-u-boot: Fix broken boot Fabio Estevam
2022-10-03 13:56 ` Michael Nazzareno Trimarchi
2022-10-21 11:41 ` sbabic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.