* [PATCH] can: kvaser_usb: Remove -Warray-bounds exception
@ 2022-10-06 19:20 Kees Cook
2022-10-07 7:56 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2022-10-06 19:20 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde
Cc: Kees Cook, linux-can, linux-kernel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
GCC-12 emits false positive -Warray-bounds warnings with
CONFIG_UBSAN_SHIFT (-fsanitize=shift). This is fixed in GCC 13[1],
and there is top-level Makefile logic to remove -Warray-bounds for
known-bad GCC versions staring with commit f0be87c42cbd ("gcc-12: disable
'-Warray-bounds' universally for now").
Remove the local work-around.
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/can/usb/kvaser_usb/Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/can/usb/kvaser_usb/Makefile b/drivers/net/can/usb/kvaser_usb/Makefile
index b20d951a0790..cf260044f0b9 100644
--- a/drivers/net/can/usb/kvaser_usb/Makefile
+++ b/drivers/net/can/usb/kvaser_usb/Makefile
@@ -1,8 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-$(CONFIG_CAN_KVASER_USB) += kvaser_usb.o
kvaser_usb-y = kvaser_usb_core.o kvaser_usb_leaf.o kvaser_usb_hydra.o
-
-# FIXME: temporarily silence -Warray-bounds on non W=1+ builds
-ifndef KBUILD_EXTRA_WARN
-CFLAGS_kvaser_usb_hydra.o += -Wno-array-bounds
-endif
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: kvaser_usb: Remove -Warray-bounds exception
2022-10-06 19:20 [PATCH] can: kvaser_usb: Remove -Warray-bounds exception Kees Cook
@ 2022-10-07 7:56 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2022-10-07 7:56 UTC (permalink / raw)
To: Kees Cook
Cc: Wolfgang Grandegger, linux-can, linux-kernel, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On 06.10.2022 12:20:35, Kees Cook wrote:
> GCC-12 emits false positive -Warray-bounds warnings with
> CONFIG_UBSAN_SHIFT (-fsanitize=shift). This is fixed in GCC 13[1],
> and there is top-level Makefile logic to remove -Warray-bounds for
> known-bad GCC versions staring with commit f0be87c42cbd ("gcc-12: disable
> '-Warray-bounds' universally for now").
>
> Remove the local work-around.
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105679
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied to linux-can-next/main.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-07 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 19:20 [PATCH] can: kvaser_usb: Remove -Warray-bounds exception Kees Cook
2022-10-07 7:56 ` Marc Kleine-Budde
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.