* [PATCH -next] drm/qxl: Remove unused variable 'count'
@ 2022-10-10 2:44 ` Chen Zhongjin
0 siblings, 0 replies; 2+ messages in thread
From: Chen Zhongjin @ 2022-10-10 2:44 UTC (permalink / raw)
To: linux-kernel, virtualization, spice-devel, dri-devel
Cc: airlied, kraxel, airlied, daniel, chenzhongjin
The variable 'count' is introduced in this commit
'commit f64122c1f6ad("drm: add new QXL driver. (v1.4)")'
However, since introduced it was just iterated and never been used.
Remove it for code cleaning.
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
drivers/gpu/drm/qxl/qxl_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/gpu/drm/qxl/qxl_cmd.c
index 7b00c955cd82..fe8b179b4f5f 100644
--- a/drivers/gpu/drm/qxl/qxl_cmd.c
+++ b/drivers/gpu/drm/qxl/qxl_cmd.c
@@ -429,7 +429,7 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
{
uint32_t handle;
int idr_ret;
- int count = 0;
+
again:
idr_preload(GFP_ATOMIC);
spin_lock(&qdev->surf_id_idr_lock);
@@ -441,7 +441,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
handle = idr_ret;
if (handle >= qdev->rom->n_surfaces) {
- count++;
spin_lock(&qdev->surf_id_idr_lock);
idr_remove(&qdev->surf_id_idr, handle);
spin_unlock(&qdev->surf_id_idr_lock);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] drm/qxl: Remove unused variable 'count'
@ 2022-10-10 2:44 ` Chen Zhongjin
0 siblings, 0 replies; 2+ messages in thread
From: Chen Zhongjin @ 2022-10-10 2:44 UTC (permalink / raw)
To: linux-kernel, virtualization, spice-devel, dri-devel
Cc: airlied, chenzhongjin, kraxel
The variable 'count' is introduced in this commit
'commit f64122c1f6ad("drm: add new QXL driver. (v1.4)")'
However, since introduced it was just iterated and never been used.
Remove it for code cleaning.
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
drivers/gpu/drm/qxl/qxl_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/gpu/drm/qxl/qxl_cmd.c
index 7b00c955cd82..fe8b179b4f5f 100644
--- a/drivers/gpu/drm/qxl/qxl_cmd.c
+++ b/drivers/gpu/drm/qxl/qxl_cmd.c
@@ -429,7 +429,7 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
{
uint32_t handle;
int idr_ret;
- int count = 0;
+
again:
idr_preload(GFP_ATOMIC);
spin_lock(&qdev->surf_id_idr_lock);
@@ -441,7 +441,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
handle = idr_ret;
if (handle >= qdev->rom->n_surfaces) {
- count++;
spin_lock(&qdev->surf_id_idr_lock);
idr_remove(&qdev->surf_id_idr, handle);
spin_unlock(&qdev->surf_id_idr_lock);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-30 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 2:44 [PATCH -next] drm/qxl: Remove unused variable 'count' Chen Zhongjin
2022-10-10 2:44 ` Chen Zhongjin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.