[PATCH 0/1] Add missing flags to the uring passthrough engine

[PATCH 0/1] Add missing flags to the uring passthrough engine

[Ankit Kumar]

Add flag IORING_SETUP_COOP_TASKRUN for ring setup, to the uring
passthrough I/O engine. This was introduced to the normal io_uring
engine with commit 4d22c103

Add flag IORING_SETUP_SINGLE_ISSUER & IORING_SETUP_DEFER_TASKRUN for
ring setup, to the uring passthrough I/O engine. This was introduced
to the normal io_uring engine with commit e453f369

Ankit Kumar (1):
  engines/io_uring: set coop taskrun, single issuer and defer taskrun

 engines/io_uring.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

-- 
2.17.1

[PATCH 1/1] engines/io_uring: set coop taskrun, single issuer and defer taskrun

[Ankit Kumar]

Add missing changes to io_uring_cmd I/O engine for COOP_TASKRUN
This was introduced for io_uring in commit 4d22c103

Add missing changes to io_uring_cmd I/O engine to set single issuer
and defer taskrun. This was introduced for io_uring in commit e453f369

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
---
 engines/io_uring.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/engines/io_uring.c b/engines/io_uring.c
index c679177f..6906e0a4 100644
--- a/engines/io_uring.c
+++ b/engines/io_uring.c
@@ -889,9 +889,30 @@ static int fio_ioring_cmd_queue_init(struct thread_data *td)
 	p.flags |= IORING_SETUP_CQSIZE;
 	p.cq_entries = depth;
 
+	/*
+	 * Setup COOP_TASKRUN as we don't need to get IPI interrupted for
+	 * completing IO operations.
+	 */
+	p.flags |= IORING_SETUP_COOP_TASKRUN;
+
+	/*
+	 * io_uring is always a single issuer, and we can defer task_work
+	 * runs until we reap events.
+	 */
+	p.flags |= IORING_SETUP_SINGLE_ISSUER | IORING_SETUP_DEFER_TASKRUN;
+
 retry:
 	ret = syscall(__NR_io_uring_setup, depth, &p);
 	if (ret < 0) {
+		if (errno == EINVAL && p.flags & IORING_SETUP_DEFER_TASKRUN) {
+			p.flags &= ~IORING_SETUP_DEFER_TASKRUN;
+			p.flags &= ~IORING_SETUP_SINGLE_ISSUER;
+			goto retry;
+		}
+		if (errno == EINVAL && p.flags & IORING_SETUP_COOP_TASKRUN) {
+			p.flags &= ~IORING_SETUP_COOP_TASKRUN;
+			goto retry;
+		}
 		if (errno == EINVAL && p.flags & IORING_SETUP_CQSIZE) {
 			p.flags &= ~IORING_SETUP_CQSIZE;
 			goto retry;
-- 
2.17.1

Re: [PATCH 0/1] Add missing flags to the uring passthrough engine

[Jens Axboe]

On Tue, 11 Oct 2022 16:29:34 +0530, Ankit Kumar wrote:
> Add flag IORING_SETUP_COOP_TASKRUN for ring setup, to the uring
> passthrough I/O engine. This was introduced to the normal io_uring
> engine with commit 4d22c103
> 
> Add flag IORING_SETUP_SINGLE_ISSUER & IORING_SETUP_DEFER_TASKRUN for
> ring setup, to the uring passthrough I/O engine. This was introduced
> to the normal io_uring engine with commit e453f369
> 
> [...]

Applied, thanks!

[1/1] engines/io_uring: set coop taskrun, single issuer and defer taskrun
      commit: 07f78c37833730594778fb5684ac6ec40d0289f8

Best regards,
-- 
Jens Axboe

Re: [PATCH 0/1] Add missing flags to the uring passthrough engine

[Ankit Kumar]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Wed, Oct 12, 2022 at 07:19:44AM -0600, Jens Axboe wrote:
> On Tue, 11 Oct 2022 16:29:34 +0530, Ankit Kumar wrote:
> > Add flag IORING_SETUP_COOP_TASKRUN for ring setup, to the uring
> > passthrough I/O engine. This was introduced to the normal io_uring
> > engine with commit 4d22c103
> > 
> > Add flag IORING_SETUP_SINGLE_ISSUER & IORING_SETUP_DEFER_TASKRUN for
> > ring setup, to the uring passthrough I/O engine. This was introduced
> > to the normal io_uring engine with commit e453f369
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] engines/io_uring: set coop taskrun, single issuer and defer taskrun
>       commit: 07f78c37833730594778fb5684ac6ec40d0289f8
> 
> Best regards,
> -- 
> Jens Axboe

Hi Jens,

I don't see the commit in the master branch.
Can you please take a look.

Thanks and Regards
Ankit
> 
> 
> 

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 0/1] Add missing flags to the uring passthrough engine

[Jens Axboe]

On 10/13/22 11:32 PM, Ankit Kumar wrote:
> On Wed, Oct 12, 2022 at 07:19:44AM -0600, Jens Axboe wrote:
>> On Tue, 11 Oct 2022 16:29:34 +0530, Ankit Kumar wrote:
>>> Add flag IORING_SETUP_COOP_TASKRUN for ring setup, to the uring
>>> passthrough I/O engine. This was introduced to the normal io_uring
>>> engine with commit 4d22c103
>>>
>>> Add flag IORING_SETUP_SINGLE_ISSUER & IORING_SETUP_DEFER_TASKRUN for
>>> ring setup, to the uring passthrough I/O engine. This was introduced
>>> to the normal io_uring engine with commit e453f369
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] engines/io_uring: set coop taskrun, single issuer and defer taskrun
>>       commit: 07f78c37833730594778fb5684ac6ec40d0289f8
>>
>> Best regards,
>> -- 
>> Jens Axboe
> 
> Hi Jens,
> 
> I don't see the commit in the master branch.
> Can you please take a look.

Guess it might help if I actually pushed it out after committing,
that has been done now.

-- 
Jens Axboe