From: Johan Hovold <johan+linaro@kernel.org> To: Vinod Koul <vkoul@kernel.org> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kishon Vijay Abraham I <kishon@ti.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH 17/20] phy: qcom-qmp-pcie: add config sanity checks Date: Wed, 12 Oct 2022 10:49:59 +0200 [thread overview] Message-ID: <20221012085002.24099-17-johan+linaro@kernel.org> (raw) In-Reply-To: <20221012085002.24099-1-johan+linaro@kernel.org> The driver expects every configuration to set the pwrdn_ctrl and phy_status masks. Add some probe WARN_ON_ONCE() to probe to catch any new driver support that fails to provide them. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 5534a4ad0243..7c81667dd968 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2347,6 +2347,9 @@ static int qmp_pcie_probe(struct platform_device *pdev) if (!cfg) return -EINVAL; + WARN_ON_ONCE(!cfg->pwrdn_ctrl); + WARN_ON_ONCE(!cfg->phy_status); + serdes = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(serdes)) return PTR_ERR(serdes); -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org> To: Vinod Koul <vkoul@kernel.org> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kishon Vijay Abraham I <kishon@ti.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH 17/20] phy: qcom-qmp-pcie: add config sanity checks Date: Wed, 12 Oct 2022 10:49:59 +0200 [thread overview] Message-ID: <20221012085002.24099-17-johan+linaro@kernel.org> (raw) In-Reply-To: <20221012085002.24099-1-johan+linaro@kernel.org> The driver expects every configuration to set the pwrdn_ctrl and phy_status masks. Add some probe WARN_ON_ONCE() to probe to catch any new driver support that fails to provide them. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 5534a4ad0243..7c81667dd968 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2347,6 +2347,9 @@ static int qmp_pcie_probe(struct platform_device *pdev) if (!cfg) return -EINVAL; + WARN_ON_ONCE(!cfg->pwrdn_ctrl); + WARN_ON_ONCE(!cfg->phy_status); + serdes = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(serdes)) return PTR_ERR(serdes); -- 2.35.1 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-10-12 8:51 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-12 8:48 [PATCH 00/20] phy: qcom-qmp: further prep fixes and cleanups (set 3) Johan Hovold 2022-10-12 8:48 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 01/20] phy: qcom-qmp-pcie: fix sc8180x initialisation Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 02/20] phy: qcom-qmp-pcie: fix ipq8074-gen3 initialisation Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 20:44 ` Dmitry Baryshkov 2022-10-12 20:44 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 03/20] phy: qcom-qmp-pcie: fix ipq6018 initialisation Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 20:44 ` Dmitry Baryshkov 2022-10-12 20:44 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 04/20] phy: qcom-qmp-pcie: clean up status polling Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 20:45 ` Dmitry Baryshkov 2022-10-12 20:45 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 05/20] phy: qcom-qmp-pcie: increase status polling period Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 06/20] phy: qcom-qmp-pcie-msm8996: clean up ready and status polling Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 20:47 ` Dmitry Baryshkov 2022-10-12 20:47 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 07/20] phy: qcom-qmp-pcie-msm8996: increase status polling period Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 08/20] phy: qcom-qmp-combo: clean up status polling Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-17 6:55 ` Johan Hovold 2022-10-17 6:55 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 09/20] phy: qcom-qmp-combo: increase status polling period Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 10/20] phy: qcom-qmp-ufs: drop unused phy-status config Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 11/20] phy: qcom-qmp-ufs: clean up ready polling Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-12 21:14 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 12/20] phy: qcom-qmp-ufs: increase ready polling period Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 13/20] phy: qcom-qmp-usb: clean up status polling Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:15 ` Dmitry Baryshkov 2022-10-12 21:15 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 14/20] phy: qcom-qmp-usb: increase status polling period Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 8:49 ` [PATCH 15/20] phy: qcom-qmp-combo: drop start and pwrdn-ctrl abstraction Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:16 ` Dmitry Baryshkov 2022-10-12 21:16 ` Dmitry Baryshkov 2022-10-12 8:49 ` [PATCH 16/20] phy: qcom-qmp-pcie: drop start-ctrl abstraction Johan Hovold 2022-10-12 8:49 ` Johan Hovold 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-28 12:23 ` Vinod Koul 2022-10-28 12:23 ` Vinod Koul 2022-10-12 8:49 ` Johan Hovold [this message] 2022-10-12 8:49 ` [PATCH 17/20] phy: qcom-qmp-pcie: add config sanity checks Johan Hovold 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 8:50 ` [PATCH 18/20] phy: qcom-qmp-pcie-msm8996: drop start and pwrdn-ctrl abstraction Johan Hovold 2022-10-12 8:50 ` Johan Hovold 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 8:50 ` [PATCH 19/20] phy: qcom-qmp-ufs: " Johan Hovold 2022-10-12 8:50 ` Johan Hovold 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 21:20 ` Dmitry Baryshkov 2022-10-12 8:50 ` [PATCH 20/20] phy: qcom-qmp-usb: " Johan Hovold 2022-10-12 8:50 ` Johan Hovold 2022-10-12 21:21 ` Dmitry Baryshkov 2022-10-12 21:21 ` Dmitry Baryshkov 2022-10-12 20:44 ` [PATCH 01/20] phy: qcom-qmp-pcie: fix sc8180x initialisation Dmitry Baryshkov 2022-10-12 20:44 ` Dmitry Baryshkov 2022-10-12 12:36 ` [PATCH 00/20] phy: qcom-qmp: further prep fixes and cleanups (set 3) Johan Hovold 2022-10-12 12:36 ` Johan Hovold 2022-10-28 12:25 ` Vinod Koul 2022-10-28 12:25 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221012085002.24099-17-johan+linaro@kernel.org \ --to=johan+linaro@kernel.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=kishon@ti.com \ --cc=konrad.dybcio@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.