* [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
@ 2022-10-13 5:11 Ankit Nautiyal
2022-10-13 5:24 ` Navare, Manasi
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Ankit Nautiyal @ 2022-10-13 5:11 UTC (permalink / raw)
To: intel-gfx
Defeature Display Interlace support.
Support for Interlace modes is removed from Gen 12 onwards.
For DP we do not support interlace modes (except for very old
platforms). Pruning the interlaced modes for HDMI for Display >=12.
Bspec: 50490
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 93519fb23d9d..791bfb062c49 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
return MODE_NO_DBLESCAN;
+ if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
+ return MODE_NO_INTERLACE;
+
if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
clock *= 2;
@@ -2247,6 +2250,10 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
return -EINVAL;
+ if (DISPLAY_VER(dev_priv) >= 12 &&
+ adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
+ return -EINVAL;
+
pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
conn_state);
@@ -2956,7 +2963,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
ddc);
drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
- connector->interlace_allowed = true;
+ if (DISPLAY_VER(dev_priv) < 12)
+ connector->interlace_allowed = true;
+
connector->stereo_allowed = true;
if (DISPLAY_VER(dev_priv) >= 10)
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
@ 2022-10-13 5:24 ` Navare, Manasi
2022-10-13 6:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Navare, Manasi @ 2022-10-13 5:24 UTC (permalink / raw)
To: Ankit Nautiyal; +Cc: intel-gfx
On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
> Defeature Display Interlace support.
> Support for Interlace modes is removed from Gen 12 onwards.
> For DP we do not support interlace modes (except for very old
> platforms). Pruning the interlaced modes for HDMI for Display >=12.
> Bspec: 50490
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Looks good to me
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Manasi
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 93519fb23d9d..791bfb062c49 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
> if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return MODE_NO_DBLESCAN;
>
> + if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> +
> if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
> clock *= 2;
>
> @@ -2247,6 +2250,10 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return -EINVAL;
>
> + if (DISPLAY_VER(dev_priv) >= 12 &&
> + adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return -EINVAL;
> +
> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
> conn_state);
> @@ -2956,7 +2963,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
> ddc);
> drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>
> - connector->interlace_allowed = true;
> + if (DISPLAY_VER(dev_priv) < 12)
> + connector->interlace_allowed = true;
> +
> connector->stereo_allowed = true;
>
> if (DISPLAY_VER(dev_priv) >= 10)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
2022-10-13 5:24 ` Navare, Manasi
@ 2022-10-13 6:00 ` Patchwork
2022-10-13 7:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-13 10:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-10-13 6:00 UTC (permalink / raw)
To: Ankit Nautiyal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5113 bytes --]
== Series Details ==
Series: drm/i915/hdmi: Prune Interlaced modes for Display >= 12
URL : https://patchwork.freedesktop.org/series/109646/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12239 -> Patchwork_109646v1
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_109646v1 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109646v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-ctg-p8600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109646v1:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- fi-kbl-8809g: [FAIL][1] ([i915#4312]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-kbl-8809g/igt@runner@aborted.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/fi-kbl-8809g/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@runner@aborted:
- {fi-tgl-mst}: [FAIL][3] ([i915#4312]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-tgl-mst/igt@runner@aborted.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/fi-tgl-mst/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_109646v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][5] ([i915#2867]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][7] ([i915#5334]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
- fi-bxt-dsi: [DMESG-FAIL][9] ([i915#5334]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/fi-bxt-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][11] ([i915#4983] / [i915#5828]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/bat-rpls-2/igt@i915_selftest@live@reset.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3:
- {bat-dg2-11}: [FAIL][13] ([i915#6818]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#6559]: https://gitlab.freedesktop.org/drm/intel/issues/6559
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7031]: https://gitlab.freedesktop.org/drm/intel/issues/7031
Build changes
-------------
* Linux: CI_DRM_12239 -> Patchwork_109646v1
CI-20190529: 20190529
CI_DRM_12239: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7012: ca6f5bdd537d26692c4b1ca011b8c4f227d95703 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109646v1: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
8208a1bb3365 drm/i915/hdmi: Prune Interlaced modes for Display >= 12
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/index.html
[-- Attachment #2: Type: text/html, Size: 5700 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
2022-10-13 5:24 ` Navare, Manasi
2022-10-13 6:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-10-13 7:58 ` Patchwork
2022-10-13 10:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-10-13 7:58 UTC (permalink / raw)
To: Ankit Nautiyal; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 23437 bytes --]
== Series Details ==
Series: drm/i915/hdmi: Prune Interlaced modes for Display >= 12
URL : https://patchwork.freedesktop.org/series/109646/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12239_full -> Patchwork_109646v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109646v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109646v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109646v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@drm_import_export@flink:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb2/igt@drm_import_export@flink.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-tglb2/igt@drm_import_export@flink.html
* igt@syncobj_wait@wait-any-snapshot:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl1/igt@syncobj_wait@wait-any-snapshot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl9/igt@syncobj_wait@wait-any-snapshot.html
Known issues
------------
Here are the changes found in Patchwork_109646v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#6268])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb5/igt@gem_ctx_exec@basic-nohangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#4525])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb5/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-tglb5/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@basic:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@heavy-random:
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk5/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@verify-random-ccs:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4613])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gem_lmem_swapping@verify-random-ccs.html
* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][16] ([i915#4171])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gem_softpin@evict-single-offset.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3323])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gen7_exec_parse@basic-allowed:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271]) +48 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gen7_exec_parse@basic-allowed.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: [PASS][19] -> [TIMEOUT][20] ([i915#4639])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@gen9_exec_parse@bb-large.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gen9_exec_parse@bb-large.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-tglb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-tglb7/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-tglb7/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][23] -> [DMESG-FAIL][24] ([i915#5334])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl10/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271]) +10 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk5/igt@kms_addfb_basic@invalid-smem-bo-on-discrete.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +8 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_color@ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3546])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_color@ctm-0-25.html
* igt@kms_color_chamelium@ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +11 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl7/igt@kms_color_chamelium@ctm-limited-range.html
* igt@kms_content_protection@lic@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][30] ([i915#7121] / [i915#7173])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@kms_content_protection@lic@pipe-a-dp-1.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: NOTRUN -> [FAIL][31] ([i915#79])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-iclb: [PASS][32] -> [DMESG-WARN][33] ([i915#2867])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb7/igt@kms_flip@flip-vs-suspend@c-edp1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb3/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#2587] / [i915#2672]) +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#2672]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#2672] / [i915#3555]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271]) +249 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1:
- shard-skl: NOTRUN -> [FAIL][38] ([i915#4573]) +5 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl7/igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1.html
* igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2:
- shard-glk: NOTRUN -> [FAIL][39] ([i915#4573]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk5/igt@kms_plane_alpha_blend@alpha-transparent-fb@pipe-b-hdmi-a-2.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#658]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#658]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][44] ([i915#6493])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_sysfs_edid_timing.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#2437]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl10/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@non-zero-reason:
- shard-skl: NOTRUN -> [TIMEOUT][46] ([i915#6943] / [i915#7065])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@perf@non-zero-reason.html
* igt@sysfs_clients@pidname:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#2994]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@sysfs_clients@pidname.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [INCOMPLETE][48] ([i915#4793] / [i915#4939]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl9/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][50] ([i915#4525]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb5/igt@gem_exec_balancer@parallel.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb1/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][52] ([i915#2842]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][54] ([i915#2842]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk7/igt@gem_exec_fair@basic-throttle@rcs0.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_sync@basic-store-all:
- shard-skl: [FAIL][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl3/igt@gem_sync@basic-store-all.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl9/igt@gem_sync@basic-store-all.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][58] ([i915#180] / [i915#1982]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][60] ([i915#5566] / [i915#716]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk7/igt@gen9_exec_parse@allowed-single.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk5/igt@gen9_exec_parse@allowed-single.html
* igt@i915_suspend@forcewake:
- shard-apl: [DMESG-WARN][62] ([i915#180]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@i915_suspend@forcewake.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl2/igt@i915_suspend@forcewake.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][64] ([i915#2346]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][66] ([i915#2122]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [FAIL][68] ([i915#2122]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl3/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][70] ([i915#79]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [SKIP][72] ([i915#5235]) -> [PASS][73] +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb5/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][74] ([fdo#109441]) -> [PASS][75] +4 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
#### Warnings ####
* igt@dmabuf@all@dma_fence_chain:
- shard-skl: [INCOMPLETE][76] ([i915#6949]) -> [INCOMPLETE][77] ([i915#6949] / [i915#7165])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-skl6/igt@dmabuf@all@dma_fence_chain.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-skl1/igt@dmabuf@all@dma_fence_chain.html
* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: [INCOMPLETE][78] ([i915#1319] / [i915#7121]) -> [INCOMPLETE][79] ([i915#1319] / [i915#7121] / [i915#7173])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl7/igt@kms_content_protection@legacy@pipe-a-dp-1.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl6/igt@kms_content_protection@legacy@pipe-a-dp-1.html
* igt@kms_content_protection@srm@pipe-a-dp-1:
- shard-apl: [INCOMPLETE][80] ([i915#7121]) -> [INCOMPLETE][81] ([i915#7121] / [i915#7173]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@kms_content_protection@srm@pipe-a-dp-1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl6/igt@kms_content_protection@srm@pipe-a-dp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][82] ([i915#2920]) -> [SKIP][83] ([i915#658]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb5/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][84] ([fdo#111068] / [i915#658]) -> [SKIP][85] ([i915#2920]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@runner@aborted:
- shard-apl: ([FAIL][86], [FAIL][87], [FAIL][88], [FAIL][89], [FAIL][90]) ([fdo#109271] / [i915#180] / [i915#3002]) -> ([FAIL][91], [FAIL][92]) ([i915#3002])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl6/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl1/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl2/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12239/shard-apl8/igt@runner@aborted.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl8/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/shard-apl1/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4639]: https://gitlab.freedesktop.org/drm/intel/issues/4639
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6943]: https://gitlab.freedesktop.org/drm/intel/issues/6943
[i915#6949]: https://gitlab.freedesktop.org/drm/intel/issues/6949
[i915#7065]: https://gitlab.freedesktop.org/drm/intel/issues/7065
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7165]: https://gitlab.freedesktop.org/drm/intel/issues/7165
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12239 -> Patchwork_109646v1
CI-20190529: 20190529
CI_DRM_12239: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7012: ca6f5bdd537d26692c4b1ca011b8c4f227d95703 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109646v1: c8ba40d43d6d1c9e457ebe91543a04a9e85b29f8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109646v1/index.html
[-- Attachment #2: Type: text/html, Size: 28751 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
` (2 preceding siblings ...)
2022-10-13 7:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-10-13 10:30 ` Ville Syrjälä
2022-10-13 11:59 ` Nautiyal, Ankit K
3 siblings, 1 reply; 7+ messages in thread
From: Ville Syrjälä @ 2022-10-13 10:30 UTC (permalink / raw)
To: Ankit Nautiyal; +Cc: intel-gfx
On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
> Defeature Display Interlace support.
> Support for Interlace modes is removed from Gen 12 onwards.
> For DP we do not support interlace modes (except for very old
> platforms).
Yes we do. Specifically G4X/VLV/CHV do not support it,
everything else does.
> Pruning the interlaced modes for HDMI for Display >=12.
> Bspec: 50490
The tagging there seems borked. Only ADLS shows it as not supported.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 93519fb23d9d..791bfb062c49 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
> if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return MODE_NO_DBLESCAN;
>
> + if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> +
These are pointless if the connector doesn't declare interlace_allowed
anyway.
> if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
> clock *= 2;
>
> @@ -2247,6 +2250,10 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return -EINVAL;
>
> + if (DISPLAY_VER(dev_priv) >= 12 &&
> + adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return -EINVAL;
> +
> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
> conn_state);
> @@ -2956,7 +2963,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
> ddc);
> drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>
> - connector->interlace_allowed = true;
> + if (DISPLAY_VER(dev_priv) < 12)
> + connector->interlace_allowed = true;
> +
> connector->stereo_allowed = true;
>
> if (DISPLAY_VER(dev_priv) >= 10)
> --
> 2.25.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 10:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2022-10-13 11:59 ` Nautiyal, Ankit K
2022-10-13 12:10 ` Ville Syrjälä
0 siblings, 1 reply; 7+ messages in thread
From: Nautiyal, Ankit K @ 2022-10-13 11:59 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On 10/13/2022 4:00 PM, Ville Syrjälä wrote:
> On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
>> Defeature Display Interlace support.
>> Support for Interlace modes is removed from Gen 12 onwards.
>> For DP we do not support interlace modes (except for very old
>> platforms).
> Yes we do. Specifically G4X/VLV/CHV do not support it,
> everything else does.
You are right. I think I misread the condition for DP and came to wrong
conclusion.
Will need to add the condition for DP as well in that case.
Apologies for the confusion, and thanks for pointing it out.
>
>> Pruning the interlaced modes for HDMI for Display >=12.
>> Bspec: 50490
> The tagging there seems borked. Only ADLS shows it as not supported.
Yes the page is getting updated it seems. The HSDES for this reads
affected platform as 12 and beyond.
>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index 93519fb23d9d..791bfb062c49 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
>> if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
>> return MODE_NO_DBLESCAN;
>>
>> + if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
>> + return MODE_NO_INTERLACE;
>> +
> These are pointless if the connector doesn't declare interlace_allowed
> anyway.
You are right, will drop this from mode valid then.
As an aside, I see, we do not set connector double_scan allowed, so the
above condition from mode_valid can also be removed I think.
Thanks & Regards,
Ankit
>
>> if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
>> clock *= 2;
>>
>> @@ -2247,6 +2250,10 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
>> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
>> return -EINVAL;
>>
>> + if (DISPLAY_VER(dev_priv) >= 12 &&
>> + adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
>> + return -EINVAL;
>> +
>> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
>> pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
>> conn_state);
>> @@ -2956,7 +2963,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
>> ddc);
>> drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>>
>> - connector->interlace_allowed = true;
>> + if (DISPLAY_VER(dev_priv) < 12)
>> + connector->interlace_allowed = true;
>> +
>> connector->stereo_allowed = true;
>>
>> if (DISPLAY_VER(dev_priv) >= 10)
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
2022-10-13 11:59 ` Nautiyal, Ankit K
@ 2022-10-13 12:10 ` Ville Syrjälä
0 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2022-10-13 12:10 UTC (permalink / raw)
To: Nautiyal, Ankit K; +Cc: intel-gfx
On Thu, Oct 13, 2022 at 05:29:39PM +0530, Nautiyal, Ankit K wrote:
>
> On 10/13/2022 4:00 PM, Ville Syrjälä wrote:
> > On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
> >> Defeature Display Interlace support.
> >> Support for Interlace modes is removed from Gen 12 onwards.
> >> For DP we do not support interlace modes (except for very old
> >> platforms).
> > Yes we do. Specifically G4X/VLV/CHV do not support it,
> > everything else does.
>
> You are right. I think I misread the condition for DP and came to wrong
> conclusion.
>
> Will need to add the condition for DP as well in that case.
>
> Apologies for the confusion, and thanks for pointing it out.
>
> >
> >> Pruning the interlaced modes for HDMI for Display >=12.
> >> Bspec: 50490
> > The tagging there seems borked. Only ADLS shows it as not supported.
>
> Yes the page is getting updated it seems. The HSDES for this reads
> affected platform as 12 and beyond.
>
>
> >
> >> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
> >> 1 file changed, 10 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> >> index 93519fb23d9d..791bfb062c49 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> >> @@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
> >> if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
> >> return MODE_NO_DBLESCAN;
> >>
> >> + if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
> >> + return MODE_NO_INTERLACE;
> >> +
> > These are pointless if the connector doesn't declare interlace_allowed
> > anyway.
>
> You are right, will drop this from mode valid then.
>
> As an aside, I see, we do not set connector double_scan allowed, so the
> above condition from mode_valid can also be removed I think.
Yeah, looks like I mistakenly added those when dealing with the
Xorg doublescan mess. Probably just forgot that doublescan_allowed
was even a thing.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-13 12:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
2022-10-13 5:24 ` Navare, Manasi
2022-10-13 6:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-13 7:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-13 10:30 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2022-10-13 11:59 ` Nautiyal, Ankit K
2022-10-13 12:10 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.