* [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl
@ 2022-10-13 4:16 Damien Le Moal via buildroot
2022-10-13 6:39 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Damien Le Moal via buildroot @ 2022-10-13 4:16 UTC (permalink / raw)
To: buildroot, Thomas Petazzoni; +Cc: Niklas Cassel, Yann E . MORIN
Gitlab CI reported build failures for the sipeed RISC-V nommu boards
with the u-boot/sdcard enabled default configuration. The compilation
errors are related to the openssl/evp.h header file missing, e.g.:
In file included from tools/imagetool.h:24,
from tools/fit_common.c:20:
include/image.h:1166:12: fatal error: openssl/evp.h: No such file or
directory
1166 | # include <openssl/evp.h>
| ^~~~~~~~~~~~~~~
Fix this issue by adding BR2_TARGET_UBOOT_NEEDS_OPENSSL=y to the config
files so that host-openssl gets built as a dependency of U-Boot.
Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
configs/sipeed_maix_bit_sdcard_defconfig | 1 +
configs/sipeed_maix_dock_sdcard_defconfig | 1 +
configs/sipeed_maix_go_sdcard_defconfig | 1 +
configs/sipeed_maixduino_sdcard_defconfig | 1 +
4 files changed, 4 insertions(+)
diff --git a/configs/sipeed_maix_bit_sdcard_defconfig b/configs/sipeed_maix_bit_sdcard_defconfig
index 8a19996090..34769eeca8 100644
--- a/configs/sipeed_maix_bit_sdcard_defconfig
+++ b/configs/sipeed_maix_bit_sdcard_defconfig
@@ -50,6 +50,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/canaan/k210-soc/uboot.config"
BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sipeed_maix_bitm"
BR2_TARGET_UBOOT_FORMAT_BIN=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
BR2_PACKAGE_HOST_UBOOT_TOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
diff --git a/configs/sipeed_maix_dock_sdcard_defconfig b/configs/sipeed_maix_dock_sdcard_defconfig
index d3d0f405e1..62f6a0e0b8 100644
--- a/configs/sipeed_maix_dock_sdcard_defconfig
+++ b/configs/sipeed_maix_dock_sdcard_defconfig
@@ -50,6 +50,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/canaan/k210-soc/uboot.config"
BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sipeed_maix_bitm"
BR2_TARGET_UBOOT_FORMAT_BIN=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
BR2_PACKAGE_HOST_UBOOT_TOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
diff --git a/configs/sipeed_maix_go_sdcard_defconfig b/configs/sipeed_maix_go_sdcard_defconfig
index 75300997b8..6c61e3aaaf 100644
--- a/configs/sipeed_maix_go_sdcard_defconfig
+++ b/configs/sipeed_maix_go_sdcard_defconfig
@@ -50,6 +50,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/canaan/k210-soc/uboot.config"
BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sipeed_maix_bitm"
BR2_TARGET_UBOOT_FORMAT_BIN=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
BR2_PACKAGE_HOST_UBOOT_TOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
diff --git a/configs/sipeed_maixduino_sdcard_defconfig b/configs/sipeed_maixduino_sdcard_defconfig
index add9369747..da8cbe45f9 100644
--- a/configs/sipeed_maixduino_sdcard_defconfig
+++ b/configs/sipeed_maixduino_sdcard_defconfig
@@ -50,6 +50,7 @@ BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/canaan/k210-soc/uboot.config"
BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sipeed_maix_bitm"
BR2_TARGET_UBOOT_FORMAT_BIN=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
BR2_PACKAGE_HOST_UBOOT_TOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
--
2.37.3
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl
2022-10-13 4:16 [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl Damien Le Moal via buildroot
@ 2022-10-13 6:39 ` Thomas Petazzoni via buildroot
2022-10-13 7:57 ` Damien Le Moal via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-10-13 6:39 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Niklas Cassel, Yann E . MORIN, buildroot
On Thu, 13 Oct 2022 13:16:16 +0900
Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
> Gitlab CI reported build failures for the sipeed RISC-V nommu boards
> with the u-boot/sdcard enabled default configuration. The compilation
> errors are related to the openssl/evp.h header file missing, e.g.:
>
> In file included from tools/imagetool.h:24,
> from tools/fit_common.c:20:
> include/image.h:1166:12: fatal error: openssl/evp.h: No such file or
> directory
> 1166 | # include <openssl/evp.h>
> | ^~~~~~~~~~~~~~~
>
> Fix this issue by adding BR2_TARGET_UBOOT_NEEDS_OPENSSL=y to the config
> files so that host-openssl gets built as a dependency of U-Boot.
>
> Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Thanks for the patch. Could you provide the links to the Gitlab CI
failures that are being fixed by this, so that we can add them to the
commit log when applying?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl
2022-10-13 6:39 ` Thomas Petazzoni via buildroot
@ 2022-10-13 7:57 ` Damien Le Moal via buildroot
2022-10-13 12:05 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Damien Le Moal via buildroot @ 2022-10-13 7:57 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Niklas Cassel, Yann E . MORIN, buildroot
On 2022/10/13 15:39, Thomas Petazzoni wrote:
> On Thu, 13 Oct 2022 13:16:16 +0900
> Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
>
>> Gitlab CI reported build failures for the sipeed RISC-V nommu boards
>> with the u-boot/sdcard enabled default configuration. The compilation
>> errors are related to the openssl/evp.h header file missing, e.g.:
>>
>> In file included from tools/imagetool.h:24,
>> from tools/fit_common.c:20:
>> include/image.h:1166:12: fatal error: openssl/evp.h: No such file or
>> directory
>> 1166 | # include <openssl/evp.h>
>> | ^~~~~~~~~~~~~~~
>>
>> Fix this issue by adding BR2_TARGET_UBOOT_NEEDS_OPENSSL=y to the config
>> files so that host-openssl gets built as a dependency of U-Boot.
>>
>> Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>
> Thanks for the patch. Could you provide the links to the Gitlab CI
> failures that are being fixed by this, so that we can add them to the
> commit log when applying?
Done. I am not sure about the proper format though. I copied similar references
I saw in git log. Please let me know if this needs a special format.
Thanks !
>
> Thanks a lot!
>
> Thomas
--
Damien Le Moal
Western Digital Research
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl
2022-10-13 7:57 ` Damien Le Moal via buildroot
@ 2022-10-13 12:05 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-10-13 12:05 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Niklas Cassel, Yann E . MORIN, buildroot
On Thu, 13 Oct 2022 16:57:58 +0900
Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
> Done. I am not sure about the proper format though. I copied similar references
> I saw in git log. Please let me know if this needs a special format.
The format you have used is perfect, it follows what we normally do.
Thanks for the v2!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-13 12:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-13 4:16 [Buildroot] [PATCH] configs/sipeed_*_sdcard: Add dependency on host-openssl Damien Le Moal via buildroot
2022-10-13 6:39 ` Thomas Petazzoni via buildroot
2022-10-13 7:57 ` Damien Le Moal via buildroot
2022-10-13 12:05 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.