* [PATCH] kbuild: fix single directory build
@ 2022-10-14 20:18 Masahiro Yamada
2022-10-14 21:18 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2022-10-14 20:18 UTC (permalink / raw)
To: linux-kbuild
Cc: Masahiro Yamada, David Sterba, Michal Marek, Nick Desaulniers,
linux-kernel
Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.
KBUILD_MODULES _is_ needed for single builds.
Otherwise, "make foo/bar/baz/" does not build module objects at all.
Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 85a63a1d29b3..48a005fc69ca 100644
--- a/Makefile
+++ b/Makefile
@@ -1978,6 +1978,8 @@ endif
single-goals := $(addprefix $(build-dir)/, $(single-no-ko))
+KBUILD_MODULES := 1
+
endif
# Preset locale variables to speed up the build process. Limit locale
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: fix single directory build
2022-10-14 20:18 [PATCH] kbuild: fix single directory build Masahiro Yamada
@ 2022-10-14 21:18 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2022-10-14 21:18 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Michal Marek, Nick Desaulniers, linux-kernel
On Sat, Oct 15, 2022 at 05:18:11AM +0900, Masahiro Yamada wrote:
> Commit f110e5a250e3 ("kbuild: refactor single builds of *.ko") was wrong.
>
> KBUILD_MODULES _is_ needed for single builds.
>
> Otherwise, "make foo/bar/baz/" does not build module objects at all.
>
> Fixes: f110e5a250e3 ("kbuild: refactor single builds of *.ko")
> Reported-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Now it works, thanks.
Tested-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-14 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 20:18 [PATCH] kbuild: fix single directory build Masahiro Yamada
2022-10-14 21:18 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.