[PATCH] clk: qcom: gcc-msm8660: Drop hardcoded fixed board clocks

[PATCH] clk: qcom: gcc-msm8660: Drop hardcoded fixed board clocks

[Linus Walleij]

These two clocks are now registered in the device tree as fixed clocks,
causing a regression in the driver as the clock already exists with
e.g. the name "pxo_board" as the MSM8660 GCC driver probes.

Fix this by just not hard-coding this anymore and everything works
like a charm.

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: baecbda52933 ("ARM: dts: qcom: msm8660: fix node names for fixed clocks")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/clk/qcom/gcc-msm8660.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/clk/qcom/gcc-msm8660.c b/drivers/clk/qcom/gcc-msm8660.c
index 657e1154bb9b..a9eb6a9ac445 100644
--- a/drivers/clk/qcom/gcc-msm8660.c
+++ b/drivers/clk/qcom/gcc-msm8660.c
@@ -2767,17 +2767,6 @@ MODULE_DEVICE_TABLE(of, gcc_msm8660_match_table);
 
 static int gcc_msm8660_probe(struct platform_device *pdev)
 {
-	int ret;
-	struct device *dev = &pdev->dev;
-
-	ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 19200000);
-	if (ret)
-		return ret;
-
-	ret = qcom_cc_register_board_clk(dev, "pxo_board", "pxo", 27000000);
-	if (ret)
-		return ret;
-
 	return qcom_cc_probe(pdev, &gcc_msm8660_desc);
 }
 
-- 
2.34.1

Re: [PATCH] clk: qcom: gcc-msm8660: Drop hardcoded fixed board clocks

[Stephen Boyd]

Quoting Linus Walleij (2022-10-13 07:07:45)
> These two clocks are now registered in the device tree as fixed clocks,
> causing a regression in the driver as the clock already exists with
> e.g. the name "pxo_board" as the MSM8660 GCC driver probes.
> 
> Fix this by just not hard-coding this anymore and everything works
> like a charm.
> 
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: baecbda52933 ("ARM: dts: qcom: msm8660: fix node names for fixed clocks")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Applied to clk-next