All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	linux-renesas-soc@vger.kernel.org,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH 6/6] ata: ahci_qoriq: Fix compilation warning
Date: Mon, 17 Oct 2022 12:22:05 +0900	[thread overview]
Message-ID: <20221017032205.2210188-7-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20221017032205.2210188-1-damien.lemoal@opensource.wdc.com>

When compiling with clang and W=1, the following warning is generated:

drivers/ata/ahci_qoriq.c:283:22: error: cast to smaller integer type
'enum ahci_qoriq_type' from 'const void *'
[-Werror,-Wvoid-pointer-to-enum-cast]
                qoriq_priv->type = (enum ahci_qoriq_type)of_id->data;
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix this by using a cast to unsigned long to match the "void *" type
size of of_id->data.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/ahci_qoriq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 6cd61842ad48..9cf9bf36a874 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -280,7 +280,7 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	if (of_id)
-		qoriq_priv->type = (enum ahci_qoriq_type)of_id->data;
+		qoriq_priv->type = (unsigned long)of_id->data;
 	else
 		qoriq_priv->type = (enum ahci_qoriq_type)acpi_id->driver_data;
 
-- 
2.37.3


WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	linux-renesas-soc@vger.kernel.org,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH 6/6] ata: ahci_qoriq: Fix compilation warning
Date: Mon, 17 Oct 2022 12:22:05 +0900	[thread overview]
Message-ID: <20221017032205.2210188-7-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20221017032205.2210188-1-damien.lemoal@opensource.wdc.com>

When compiling with clang and W=1, the following warning is generated:

drivers/ata/ahci_qoriq.c:283:22: error: cast to smaller integer type
'enum ahci_qoriq_type' from 'const void *'
[-Werror,-Wvoid-pointer-to-enum-cast]
                qoriq_priv->type = (enum ahci_qoriq_type)of_id->data;
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fix this by using a cast to unsigned long to match the "void *" type
size of of_id->data.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 drivers/ata/ahci_qoriq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c
index 6cd61842ad48..9cf9bf36a874 100644
--- a/drivers/ata/ahci_qoriq.c
+++ b/drivers/ata/ahci_qoriq.c
@@ -280,7 +280,7 @@ static int ahci_qoriq_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	if (of_id)
-		qoriq_priv->type = (enum ahci_qoriq_type)of_id->data;
+		qoriq_priv->type = (unsigned long)of_id->data;
 	else
 		qoriq_priv->type = (enum ahci_qoriq_type)acpi_id->driver_data;
 
-- 
2.37.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-10-17  3:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  3:21 [PATCH 0/6] Fix compilation warnings Damien Le Moal
2022-10-17  3:21 ` Damien Le Moal
2022-10-17  3:22 ` [PATCH 1/6] ata: ahci_st: Fix compilation warning Damien Le Moal
2022-10-17  3:22   ` Damien Le Moal
2022-10-17  3:22 ` [PATCH 2/6] ata: sata_rcar: " Damien Le Moal
2022-10-17  3:22   ` Damien Le Moal
2022-10-17  7:13   ` Geert Uytterhoeven
2022-10-17  7:13     ` Geert Uytterhoeven
2022-10-17 19:08   ` Sergey Shtylyov
2022-10-17 19:08     ` Sergey Shtylyov
2022-10-17  3:22 ` [PATCH 3/6] ata: ahci_brcm: " Damien Le Moal
2022-10-17  3:22   ` Damien Le Moal
2022-10-17 19:57   ` Florian Fainelli
2022-10-17 19:57     ` Florian Fainelli
2022-10-17  3:22 ` [PATCH 4/6] ata: ahci_xgene: " Damien Le Moal
2022-10-17  3:22   ` Damien Le Moal
2022-10-17  3:22 ` [PATCH 5/6] ata: ahci_imx: " Damien Le Moal
2022-10-17  3:22   ` Damien Le Moal
2022-10-17  3:22 ` Damien Le Moal [this message]
2022-10-17  3:22   ` [PATCH 6/6] ata: ahci_qoriq: " Damien Le Moal
2022-10-17  7:25 ` [PATCH 0/6] Fix compilation warnings Arnd Bergmann
2022-10-17  7:25   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017032205.2210188-7-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=arnd@arndb.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=s.hauer@pengutronix.de \
    --cc=s.shtylyov@omp.ru \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.