[PATCH] disk-utils/fsck.c: Processes may kill other processes.

[PATCH] disk-utils/fsck.c: Processes may kill other processes.

[zhanchengbin]

A error in disk-utils/fsck.c, if run the fsck -N command, processes
don't execute, just show what would be done. However, the pid whose
value is -1 is added to the instance_list list in the execute
function,if the kill_all function is called later, kill(-1, signum)
is executed, Signals are sent to all processes except the number one
process and itself. Other processes will be killed if they use the
default signal processing function.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
  disk-utils/fsck.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index 505952c81..800d3ce08 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -730,6 +730,8 @@ static int kill_all(int signum)
      for (inst = instance_list; inst; inst = inst->next) {
          if (inst->flags & FLAG_DONE)
              continue;
+        if (inst->pid <= 0)
+            continue;
          kill(inst->pid, signum);
          n++;
      }
-- 
2.27.0

Re: [PATCH] disk-utils/fsck.c: Processes may kill other processes.

[Lukas Czerner]

On Mon, Oct 10, 2022 at 05:41:17PM +0800, zhanchengbin wrote:
> A error in disk-utils/fsck.c, if run the fsck -N command, processes
> don't execute, just show what would be done. However, the pid whose
> value is -1 is added to the instance_list list in the execute
> function,if the kill_all function is called later, kill(-1, signum)
> is executed, Signals are sent to all processes except the number one
> process and itself. Other processes will be killed if they use the
> default signal processing function.

Looks good thanks.

> 
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
                               ^^^
Here as well, please remove my Sob and you can add

Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Thanks!
-Lukas

> ---
>  disk-utils/fsck.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
> index 505952c81..800d3ce08 100644
> --- a/disk-utils/fsck.c
> +++ b/disk-utils/fsck.c
> @@ -730,6 +730,8 @@ static int kill_all(int signum)
>      for (inst = instance_list; inst; inst = inst->next) {
>          if (inst->flags & FLAG_DONE)
>              continue;
> +        if (inst->pid <= 0)
> +            continue;
>          kill(inst->pid, signum);
>          n++;
>      }
> -- 
> 2.27.0
> 

Re: [PATCH] disk-utils/fsck.c: Processes may kill other processes.

[Karel Zak]

On Mon, Oct 10, 2022 at 03:06:51PM +0200, Lukas Czerner wrote:
> On Mon, Oct 10, 2022 at 05:41:17PM +0800, zhanchengbin wrote:
> > A error in disk-utils/fsck.c, if run the fsck -N command, processes
> > don't execute, just show what would be done. However, the pid whose
> > value is -1 is added to the instance_list list in the execute
> > function,if the kill_all function is called later, kill(-1, signum)
> > is executed, Signals are sent to all processes except the number one
> > process and itself. Other processes will be killed if they use the
> > default signal processing function.
> 
> Looks good thanks.
> 
> > 
> > Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>                                ^^^
> Here as well, please remove my Sob and you can add
> 
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>

Applied, thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com