* [PATCH] nvme: fix error pointer dereference in error handling
@ 2022-10-15 8:25 Dan Carpenter
2022-10-16 5:09 ` Chaitanya Kulkarni
2022-10-17 7:21 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-10-15 8:25 UTC (permalink / raw)
To: Keith Busch, Christoph Hellwig
Cc: Jens Axboe, Sagi Grimberg, Chaitanya Kulkarni, linux-nvme,
kernel-janitors
There is typo here so it releases the wrong variable. "ctrl->admin_q"
was intended instead of "ctrl->fabrics_q".
Fixes: fe60e8c53411 ("nvme: add common helpers to allocate and free tagsets")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 059737c1a2c1..9cbe7854d488 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4846,7 +4846,7 @@ int nvme_alloc_admin_tag_set(struct nvme_ctrl *ctrl, struct blk_mq_tag_set *set,
return 0;
out_cleanup_admin_q:
- blk_mq_destroy_queue(ctrl->fabrics_q);
+ blk_mq_destroy_queue(ctrl->admin_q);
out_free_tagset:
blk_mq_free_tag_set(ctrl->admin_tagset);
return ret;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: fix error pointer dereference in error handling
2022-10-15 8:25 [PATCH] nvme: fix error pointer dereference in error handling Dan Carpenter
@ 2022-10-16 5:09 ` Chaitanya Kulkarni
2022-10-17 7:21 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2022-10-16 5:09 UTC (permalink / raw)
To: Dan Carpenter, Keith Busch, Christoph Hellwig
Cc: Jens Axboe, Sagi Grimberg, Chaitanya Kulkarni, linux-nvme,
kernel-janitors
On 10/15/22 01:25, Dan Carpenter wrote:
> There is typo here so it releases the wrong variable. "ctrl->admin_q"
> was intended instead of "ctrl->fabrics_q".
>
> Fixes: fe60e8c53411 ("nvme: add common helpers to allocate and free tagsets")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: fix error pointer dereference in error handling
2022-10-15 8:25 [PATCH] nvme: fix error pointer dereference in error handling Dan Carpenter
2022-10-16 5:09 ` Chaitanya Kulkarni
@ 2022-10-17 7:21 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-10-17 7:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Keith Busch, Christoph Hellwig, Jens Axboe, Sagi Grimberg,
Chaitanya Kulkarni, linux-nvme, kernel-janitors
Thanks, applied to nvme-6.1.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-15 8:25 [PATCH] nvme: fix error pointer dereference in error handling Dan Carpenter
2022-10-16 5:09 ` Chaitanya Kulkarni
2022-10-17 7:21 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.