* [PATCH] staging: iio: frequency: ad9834: merge unnecessary split lines
@ 2022-10-17 6:32 Deepak R Varma
2022-10-17 7:10 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2022-10-17 6:32 UTC (permalink / raw)
To: outreachy, lars, Michael.Hennerich, jic23, gregkh, linux-iio,
linux-staging, linux-kernel
Cc: kumarpraveen, saurabh.truth
Improve code readability by merging unnecessary split lines that are
well within the code-style guidelines post merge.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/iio/frequency/ad9834.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index 2b4267a87e65..285df0e489a6 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1);
static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL);
static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/
-static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL,
- ad9834_write, AD9834_PIN_SW);
+static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW);
static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET);
-static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL,
- ad9834_write, AD9834_OPBITEN);
+static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN);
static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0);
static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: frequency: ad9834: merge unnecessary split lines
2022-10-17 6:32 [PATCH] staging: iio: frequency: ad9834: merge unnecessary split lines Deepak R Varma
@ 2022-10-17 7:10 ` Julia Lawall
2022-10-23 12:37 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2022-10-17 7:10 UTC (permalink / raw)
To: Deepak R Varma
Cc: outreachy, lars, Michael.Hennerich, jic23, gregkh, linux-iio,
linux-staging, linux-kernel, kumarpraveen, saurabh.truth
On Mon, 17 Oct 2022, Deepak R Varma wrote:
> Improve code readability by merging unnecessary split lines that are
> well within the code-style guidelines post merge.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> drivers/staging/iio/frequency/ad9834.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
> index 2b4267a87e65..285df0e489a6 100644
> --- a/drivers/staging/iio/frequency/ad9834.c
> +++ b/drivers/staging/iio/frequency/ad9834.c
> @@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1);
> static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL);
> static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/
>
> -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL,
> - ad9834_write, AD9834_PIN_SW);
> +static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW);
> static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET);
> -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL,
> - ad9834_write, AD9834_OPBITEN);
> +static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN);
> static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0);
> static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1);
>
> --
> 2.30.2
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: frequency: ad9834: merge unnecessary split lines
2022-10-17 7:10 ` Julia Lawall
@ 2022-10-23 12:37 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2022-10-23 12:37 UTC (permalink / raw)
To: Julia Lawall
Cc: Deepak R Varma, outreachy, lars, Michael.Hennerich, gregkh,
linux-iio, linux-staging, linux-kernel, kumarpraveen,
saurabh.truth
On Mon, 17 Oct 2022 09:10:15 +0200 (CEST)
Julia Lawall <julia.lawall@inria.fr> wrote:
> On Mon, 17 Oct 2022, Deepak R Varma wrote:
>
> > Improve code readability by merging unnecessary split lines that are
> > well within the code-style guidelines post merge.
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
>
> Acked-by: Julia Lawall <julia.lawall@inria.fr>
Not a huge benefit to readability, but as this is in staging, fair enough!
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything.
Thanks,
Jonathan
>
> > ---
> > drivers/staging/iio/frequency/ad9834.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
> > index 2b4267a87e65..285df0e489a6 100644
> > --- a/drivers/staging/iio/frequency/ad9834.c
> > +++ b/drivers/staging/iio/frequency/ad9834.c
> > @@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1);
> > static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL);
> > static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/
> >
> > -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL,
> > - ad9834_write, AD9834_PIN_SW);
> > +static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW);
> > static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET);
> > -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL,
> > - ad9834_write, AD9834_OPBITEN);
> > +static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN);
> > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0);
> > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1);
> >
> > --
> > 2.30.2
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-23 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 6:32 [PATCH] staging: iio: frequency: ad9834: merge unnecessary split lines Deepak R Varma
2022-10-17 7:10 ` Julia Lawall
2022-10-23 12:37 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.