* [PATCH] mfd: rk808: permit having multiple PMIC instances
@ 2022-10-25 9:54 Neil Armstrong
2022-10-31 15:22 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2022-10-25 9:54 UTC (permalink / raw)
To: Neil Armstrong, linux-kernel, Lee Jones
This set each cells id to -1 to allow multiple instances of
each cell in case multiple PMICs handled by the rk808 driver
are probed.
This fixes probing a RK818 and a RK817 on the Odroid Go Ultra
devices.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Cc: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org
---
drivers/mfd/rk808.c | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index e00da7c7e3b1..b9cfd249912d 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -137,58 +137,64 @@ static const struct resource rk817_charger_resources[] = {
};
static const struct mfd_cell rk805s[] = {
- { .name = "rk808-clkout", },
- { .name = "rk808-regulator", },
- { .name = "rk805-pinctrl", },
+ { .name = "rk808-clkout", .id = -1, },
+ { .name = "rk808-regulator", .id = -1, },
+ { .name = "rk805-pinctrl", .id = -1, },
{
.name = "rk808-rtc",
.num_resources = ARRAY_SIZE(rtc_resources),
.resources = &rtc_resources[0],
+ .id = -1,
},
{ .name = "rk805-pwrkey",
.num_resources = ARRAY_SIZE(rk805_key_resources),
.resources = &rk805_key_resources[0],
+ .id = -1,
},
};
static const struct mfd_cell rk808s[] = {
- { .name = "rk808-clkout", },
- { .name = "rk808-regulator", },
+ { .name = "rk808-clkout", .id = -1, },
+ { .name = "rk808-regulator", .id = -1, },
{
.name = "rk808-rtc",
.num_resources = ARRAY_SIZE(rtc_resources),
.resources = rtc_resources,
+ .id = -1,
},
};
static const struct mfd_cell rk817s[] = {
- { .name = "rk808-clkout",},
- { .name = "rk808-regulator",},
+ { .name = "rk808-clkout", .id = -1, },
+ { .name = "rk808-regulator", .id = -1, },
{
.name = "rk805-pwrkey",
.num_resources = ARRAY_SIZE(rk817_pwrkey_resources),
.resources = &rk817_pwrkey_resources[0],
+ .id = -1,
},
{
.name = "rk808-rtc",
.num_resources = ARRAY_SIZE(rk817_rtc_resources),
.resources = &rk817_rtc_resources[0],
+ .id = -1,
},
- { .name = "rk817-codec",},
+ { .name = "rk817-codec", .id = -1, },
{
.name = "rk817-charger",
.num_resources = ARRAY_SIZE(rk817_charger_resources),
.resources = &rk817_charger_resources[0],
+ .id = -1,
},
};
static const struct mfd_cell rk818s[] = {
- { .name = "rk808-clkout", },
- { .name = "rk808-regulator", },
+ { .name = "rk808-regulator", .id = -1, },
{
.name = "rk808-rtc",
.num_resources = ARRAY_SIZE(rtc_resources),
.resources = rtc_resources,
+ .id = -1,
},
};
---
base-commit: 247f34f7b80357943234f93f247a1ae6b6c3a740
change-id: 20221025-rk808-multi-65dd03a92705
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: rk808: permit having multiple PMIC instances
2022-10-25 9:54 [PATCH] mfd: rk808: permit having multiple PMIC instances Neil Armstrong
@ 2022-10-31 15:22 ` Lee Jones
2022-10-31 15:30 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2022-10-31 15:22 UTC (permalink / raw)
To: Neil Armstrong; +Cc: linux-kernel
On Tue, 25 Oct 2022, Neil Armstrong wrote:
> This set each cells id to -1 to allow multiple instances of
> each cell in case multiple PMICs handled by the rk808 driver
> are probed.
>
> This fixes probing a RK818 and a RK817 on the Odroid Go Ultra
> devices.
No issue with the premise Neil, but would you be kind enough to use
the define provided (PLATFORM_DEVID_NONE) instead of the magic number
please?
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/mfd/rk808.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index e00da7c7e3b1..b9cfd249912d 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -137,58 +137,64 @@ static const struct resource rk817_charger_resources[] = {
> };
>
> static const struct mfd_cell rk805s[] = {
> - { .name = "rk808-clkout", },
> - { .name = "rk808-regulator", },
> - { .name = "rk805-pinctrl", },
> + { .name = "rk808-clkout", .id = -1, },
> + { .name = "rk808-regulator", .id = -1, },
> + { .name = "rk805-pinctrl", .id = -1, },
> {
> .name = "rk808-rtc",
> .num_resources = ARRAY_SIZE(rtc_resources),
> .resources = &rtc_resources[0],
> + .id = -1,
> },
> { .name = "rk805-pwrkey",
> .num_resources = ARRAY_SIZE(rk805_key_resources),
> .resources = &rk805_key_resources[0],
> + .id = -1,
> },
> };
>
> static const struct mfd_cell rk808s[] = {
> - { .name = "rk808-clkout", },
> - { .name = "rk808-regulator", },
> + { .name = "rk808-clkout", .id = -1, },
> + { .name = "rk808-regulator", .id = -1, },
> {
> .name = "rk808-rtc",
> .num_resources = ARRAY_SIZE(rtc_resources),
> .resources = rtc_resources,
> + .id = -1,
> },
> };
>
> static const struct mfd_cell rk817s[] = {
> - { .name = "rk808-clkout",},
> - { .name = "rk808-regulator",},
> + { .name = "rk808-clkout", .id = -1, },
> + { .name = "rk808-regulator", .id = -1, },
> {
> .name = "rk805-pwrkey",
> .num_resources = ARRAY_SIZE(rk817_pwrkey_resources),
> .resources = &rk817_pwrkey_resources[0],
> + .id = -1,
> },
> {
> .name = "rk808-rtc",
> .num_resources = ARRAY_SIZE(rk817_rtc_resources),
> .resources = &rk817_rtc_resources[0],
> + .id = -1,
> },
> - { .name = "rk817-codec",},
> + { .name = "rk817-codec", .id = -1, },
> {
> .name = "rk817-charger",
> .num_resources = ARRAY_SIZE(rk817_charger_resources),
> .resources = &rk817_charger_resources[0],
> + .id = -1,
> },
> };
>
> static const struct mfd_cell rk818s[] = {
> - { .name = "rk808-clkout", },
> - { .name = "rk808-regulator", },
> + { .name = "rk808-regulator", .id = -1, },
> {
> .name = "rk808-rtc",
> .num_resources = ARRAY_SIZE(rtc_resources),
> .resources = rtc_resources,
> + .id = -1,
> },
> };
>
>
> ---
> base-commit: 247f34f7b80357943234f93f247a1ae6b6c3a740
> change-id: 20221025-rk808-multi-65dd03a92705
>
> Best regards,
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: rk808: permit having multiple PMIC instances
2022-10-31 15:22 ` Lee Jones
@ 2022-10-31 15:30 ` Neil Armstrong
0 siblings, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2022-10-31 15:30 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
Hi,
On 31/10/2022 16:22, Lee Jones wrote:
> On Tue, 25 Oct 2022, Neil Armstrong wrote:
>
>> This set each cells id to -1 to allow multiple instances of
>> each cell in case multiple PMICs handled by the rk808 driver
>> are probed.
>>
>> This fixes probing a RK818 and a RK817 on the Odroid Go Ultra
>> devices.
>
> No issue with the premise Neil, but would you be kind enough to use
> the define provided (PLATFORM_DEVID_NONE) instead of the magic number
> please?
Sure, will re-spin asap with PLATFORM_DEVID_NONE
Thanks,
Neil
>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> Cc: Lee Jones <lee@kernel.org>
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> drivers/mfd/rk808.c | 26 ++++++++++++++++----------
>> 1 file changed, 16 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>> index e00da7c7e3b1..b9cfd249912d 100644
>> --- a/drivers/mfd/rk808.c
>> +++ b/drivers/mfd/rk808.c
>> @@ -137,58 +137,64 @@ static const struct resource rk817_charger_resources[] = {
>> };
>>
>> static const struct mfd_cell rk805s[] = {
>> - { .name = "rk808-clkout", },
>> - { .name = "rk808-regulator", },
>> - { .name = "rk805-pinctrl", },
>> + { .name = "rk808-clkout", .id = -1, },
>> + { .name = "rk808-regulator", .id = -1, },
>> + { .name = "rk805-pinctrl", .id = -1, },
>> {
>> .name = "rk808-rtc",
>> .num_resources = ARRAY_SIZE(rtc_resources),
>> .resources = &rtc_resources[0],
>> + .id = -1,
>> },
>> { .name = "rk805-pwrkey",
>> .num_resources = ARRAY_SIZE(rk805_key_resources),
>> .resources = &rk805_key_resources[0],
>> + .id = -1,
>> },
>> };
>>
>> static const struct mfd_cell rk808s[] = {
>> - { .name = "rk808-clkout", },
>> - { .name = "rk808-regulator", },
>> + { .name = "rk808-clkout", .id = -1, },
>> + { .name = "rk808-regulator", .id = -1, },
>> {
>> .name = "rk808-rtc",
>> .num_resources = ARRAY_SIZE(rtc_resources),
>> .resources = rtc_resources,
>> + .id = -1,
>> },
>> };
>>
>> static const struct mfd_cell rk817s[] = {
>> - { .name = "rk808-clkout",},
>> - { .name = "rk808-regulator",},
>> + { .name = "rk808-clkout", .id = -1, },
>> + { .name = "rk808-regulator", .id = -1, },
>> {
>> .name = "rk805-pwrkey",
>> .num_resources = ARRAY_SIZE(rk817_pwrkey_resources),
>> .resources = &rk817_pwrkey_resources[0],
>> + .id = -1,
>> },
>> {
>> .name = "rk808-rtc",
>> .num_resources = ARRAY_SIZE(rk817_rtc_resources),
>> .resources = &rk817_rtc_resources[0],
>> + .id = -1,
>> },
>> - { .name = "rk817-codec",},
>> + { .name = "rk817-codec", .id = -1, },
>> {
>> .name = "rk817-charger",
>> .num_resources = ARRAY_SIZE(rk817_charger_resources),
>> .resources = &rk817_charger_resources[0],
>> + .id = -1,
>> },
>> };
>>
>> static const struct mfd_cell rk818s[] = {
>> - { .name = "rk808-clkout", },
>> - { .name = "rk808-regulator", },
>> + { .name = "rk808-regulator", .id = -1, },
>> {
>> .name = "rk808-rtc",
>> .num_resources = ARRAY_SIZE(rtc_resources),
>> .resources = rtc_resources,
>> + .id = -1,
>> },
>> };
>>
>>
>> ---
>> base-commit: 247f34f7b80357943234f93f247a1ae6b6c3a740
>> change-id: 20221025-rk808-multi-65dd03a92705
>>
>> Best regards,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-31 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25 9:54 [PATCH] mfd: rk808: permit having multiple PMIC instances Neil Armstrong
2022-10-31 15:22 ` Lee Jones
2022-10-31 15:30 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.