All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] python-wheel: new package
@ 2022-10-25  6:53 Nasser Afshin
  2023-02-17 14:10 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Nasser Afshin @ 2022-10-25  6:53 UTC (permalink / raw)
  To: buildroot; +Cc: Nasser Afshin, Asaf Kahlon

Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>
---
 package/Config.in                      |  1 +
 package/python-wheel/Config.in         | 15 +++++++++++++++
 package/python-wheel/python-wheel.hash |  5 +++++
 package/python-wheel/python-wheel.mk   | 14 ++++++++++++++
 4 files changed, 35 insertions(+)
 create mode 100644 package/python-wheel/Config.in
 create mode 100644 package/python-wheel/python-wheel.hash
 create mode 100644 package/python-wheel/python-wheel.mk

diff --git a/package/Config.in b/package/Config.in
index b60e7700ad..56b1a08d8b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1062,6 +1062,7 @@ menu "External python modules"
 	source "package/python-websocket-client/Config.in"
 	source "package/python-websockets/Config.in"
 	source "package/python-werkzeug/Config.in"
+	source "package/python-wheel/Config.in"
 	source "package/python-whoosh/Config.in"
 	source "package/python-wrapt/Config.in"
 	source "package/python-ws4py/Config.in"
diff --git a/package/python-wheel/Config.in b/package/python-wheel/Config.in
new file mode 100644
index 0000000000..225d7529a4
--- /dev/null
+++ b/package/python-wheel/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_PYTHON_WHEEL
+	bool "python-wheel"
+	help
+      This library is the reference implementation of the Python wheel
+      packaging standard, as defined in PEP 427.
+
+        It has two different roles:
+            1. A setuptools extension for building wheels that provides the bdist_wheel
+            setuptools command
+            2. A command line tool for working with wheel files
+
+        It should be noted that wheel is not intended to be used as a library, and as
+        such there is no stable, public API.
+
+          https://github.com/pypa/wheel
diff --git a/package/python-wheel/python-wheel.hash b/package/python-wheel/python-wheel.hash
new file mode 100644
index 0000000000..be82f63a30
--- /dev/null
+++ b/package/python-wheel/python-wheel.hash
@@ -0,0 +1,5 @@
+# md5 from https://pypi.python.org/pypi/wheel/json
+md5 f490f1399e5903706cb1d4fbed9ecb28  wheel-0.37.1.tar.gz
+# Locally computed
+sha256  e9a504e793efbca1b8e0e9cb979a249cf4a0a7b5b8c9e8b65a5e39d49529c1c4  wheel-0.37.1.tar.gz
+sha256  cca9e20c6af1fcfbf69408f377769286cbeebcded336100c9b4a3f35fbe635e4  LICENSE.txt
diff --git a/package/python-wheel/python-wheel.mk b/package/python-wheel/python-wheel.mk
new file mode 100644
index 0000000000..d8fab54867
--- /dev/null
+++ b/package/python-wheel/python-wheel.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-wheel
+#
+################################################################################
+
+PYTHON_WHEEL_VERSION = 0.37.1
+PYTHON_WHEEL_SOURCE = wheel-$(PYTHON_WHEEL_VERSION).tar.gz
+PYTHON_WHEEL_SITE = https://files.pythonhosted.org/packages/c0/6c/9f840c2e55b67b90745af06a540964b73589256cb10cc10057c87ac78fc2
+PYTHON_WHEEL_SETUP_TYPE = distutils
+PYTHON_WHEEL_LICENSE = MIT
+PYTHON_WHEEL_LICENSE_FILES = LICENSE.txt
+
+$(eval $(python-package))
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] python-wheel: new package
  2022-10-25  6:53 [Buildroot] [PATCH] python-wheel: new package Nasser Afshin
@ 2023-02-17 14:10 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-02-17 14:10 UTC (permalink / raw)
  To: Nasser Afshin; +Cc: Asaf Kahlon, buildroot

Hello Nasser,

Thanks for the contribution, and sorry for the very slow feedback :-/

On Tue, 25 Oct 2022 10:23:56 +0330
Nasser Afshin <afshin.nasser@gmail.com> wrote:

> Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>
> ---
>  package/Config.in                      |  1 +
>  package/python-wheel/Config.in         | 15 +++++++++++++++
>  package/python-wheel/python-wheel.hash |  5 +++++
>  package/python-wheel/python-wheel.mk   | 14 ++++++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 package/python-wheel/Config.in
>  create mode 100644 package/python-wheel/python-wheel.hash
>  create mode 100644 package/python-wheel/python-wheel.mk

Could you give some details on the use case for python-wheels on the
target?

Also, could you add an entry to the DEVELOPERS file?

In addition, for Python packages, we really like to have a runtime test
in support/testing/. Could you have a look into this?


>  	source "package/python-ws4py/Config.in"
> diff --git a/package/python-wheel/Config.in b/package/python-wheel/Config.in
> new file mode 100644
> index 0000000000..225d7529a4
> --- /dev/null
> +++ b/package/python-wheel/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_PYTHON_WHEEL
> +	bool "python-wheel"
> +	help
> +      This library is the reference implementation of the Python wheel
> +      packaging standard, as defined in PEP 427.
> +
> +        It has two different roles:
> +            1. A setuptools extension for building wheels that provides the bdist_wheel
> +            setuptools command
> +            2. A command line tool for working with wheel files
> +
> +        It should be noted that wheel is not intended to be used as a library, and as
> +        such there is no stable, public API.
> +
> +          https://github.com/pypa/wheel

The indentation is not correct. Could you run "make check-package" and
make sure there are no warnings?


> index 0000000000..d8fab54867
> --- /dev/null
> +++ b/package/python-wheel/python-wheel.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-wheel
> +#
> +################################################################################
> +
> +PYTHON_WHEEL_VERSION = 0.37.1
> +PYTHON_WHEEL_SOURCE = wheel-$(PYTHON_WHEEL_VERSION).tar.gz
> +PYTHON_WHEEL_SITE = https://files.pythonhosted.org/packages/c0/6c/9f840c2e55b67b90745af06a540964b73589256cb10cc10057c87ac78fc2
> +PYTHON_WHEEL_SETUP_TYPE = distutils

Are you sure? It seems to be using setuptools. Could you double check
this?

Could you fix this and resend, as a new patch sent with "git
send-email" (and not in the middle of a reply, like you did for
python-pycrate, which was not good)?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-17 14:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-25  6:53 [Buildroot] [PATCH] python-wheel: new package Nasser Afshin
2023-02-17 14:10 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.