[PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Oliver Graute]

Switch to use binman to pack images

Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
Changes for v3
 -added Reviewed-by
 -rebased on master

 arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
 arch/arm/mach-imx/imx8/Kconfig      | 1 +
 board/congatec/cgtqmx8/imximage.cfg | 4 ++--
 configs/cgtqmx8_defconfig           | 2 +-
 doc/board/congatec/cgtqmx8.rst      | 3 +--
 5 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/arch/arm/dts/imx8qm-cgtqmx8.dts b/arch/arm/dts/imx8qm-cgtqmx8.dts
index 555c357f6f..919d00644f 100644
--- a/arch/arm/dts/imx8qm-cgtqmx8.dts
+++ b/arch/arm/dts/imx8qm-cgtqmx8.dts
@@ -12,6 +12,7 @@
 /memreserve/ 0x80000000 0x00020000;
 
 #include "fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"
 
 / {
 	model = "Congatec QMX8 Qseven series";
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
index 4414cbc213..3094524460 100644
--- a/arch/arm/mach-imx/imx8/Kconfig
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -74,6 +74,7 @@ config TARGET_IMX8QM_MEK
 
 config TARGET_CONGA_QMX8
 	bool "Support congatec conga-QMX8 board"
+	select BINMAN
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select IMX8QM
diff --git a/board/congatec/cgtqmx8/imximage.cfg b/board/congatec/cgtqmx8/imximage.cfg
index 5ecde0c530..43035088e3 100644
--- a/board/congatec/cgtqmx8/imximage.cfg
+++ b/board/congatec/cgtqmx8/imximage.cfg
@@ -4,8 +4,8 @@
  */
 
 
-/* Boot from SD, sector size 0x400 */
-BOOT_FROM SD 0x400
+BOOT_FROM	sd
+
 /* SoC type IMX8QM */
 SOC_TYPE IMX8QM
 /* Append seco container image */
diff --git a/configs/cgtqmx8_defconfig b/configs/cgtqmx8_defconfig
index 2cf882f826..fb334bc4a4 100644
--- a/configs/cgtqmx8_defconfig
+++ b/configs/cgtqmx8_defconfig
@@ -21,7 +21,7 @@ CONFIG_SYS_LOAD_ADDR=0x80280000
 CONFIG_REMAKE_ELF=y
 CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
-CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
+# CONFIG_USE_SPL_FIT_GENERATOR is not set
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_BOOTDELAY=3
 CONFIG_USE_BOOTCOMMAND=y
diff --git a/doc/board/congatec/cgtqmx8.rst b/doc/board/congatec/cgtqmx8.rst
index bccdef2f16..16711a844d 100644
--- a/doc/board/congatec/cgtqmx8.rst
+++ b/doc/board/congatec/cgtqmx8.rst
@@ -57,8 +57,7 @@ Build U-Boot
      $ export ATF_LOAD_ADDR=0x80000000
      $ export BL33_LOAD_ADDR=0x80020000
      $ make cgtqmx8_defconfig
-     $ make u-boot.bin
-     $ make flash.bin
+     $ make
 
 Flash the binary into the SD card
 ---------------------------------
-- 
2.17.1

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Fabio Estevam]

Hi Stefano and Oliver,

On Tue, May 3, 2022 at 7:49 AM Oliver Graute
<oliver.graute@kococonnector.com> wrote:
>
> Switch to use binman to pack images
>
> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> Changes for v3
>  -added Reviewed-by
>  -rebased on master
>
>  arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
>  arch/arm/mach-imx/imx8/Kconfig      | 1 +
>  board/congatec/cgtqmx8/imximage.cfg | 4 ++--
>  configs/cgtqmx8_defconfig           | 2 +-
>  doc/board/congatec/cgtqmx8.rst      | 3 +--
>  5 files changed, 6 insertions(+), 5 deletions(-)

Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.

The previous v2 did include it:
https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Stefano Babic]

On 24.10.22 13:37, Fabio Estevam wrote:
> Hi Stefano and Oliver,
> 
> On Tue, May 3, 2022 at 7:49 AM Oliver Graute
> <oliver.graute@kococonnector.com> wrote:
>>
>> Switch to use binman to pack images
>>
>> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
>> Reviewed-by: Fabio Estevam <festevam@denx.de>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>> Changes for v3
>>   -added Reviewed-by
>>   -rebased on master
>>
>>   arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
>>   arch/arm/mach-imx/imx8/Kconfig      | 1 +
>>   board/congatec/cgtqmx8/imximage.cfg | 4 ++--
>>   configs/cgtqmx8_defconfig           | 2 +-
>>   doc/board/congatec/cgtqmx8.rst      | 3 +--
>>   5 files changed, 6 insertions(+), 5 deletions(-)
> 
> Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
> 

Right - as well as V4, this is what I tried to merge and breaks. I have 
drop it.

> The previous v2 did include it:
> https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/

Thanks for noting this - Oliver, can you check and repost a V5, then ? 
Thanks !

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Oliver Graute]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]


> 
> Right - as well as V4, this is what I tried to merge and breaks. I have drop it.
> 
>> The previous v2 did include it:
>> https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
> 
> Thanks for noting this - Oliver, can you check and repost a V5, then ? Thanks !

The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for „PATCH v3 imx: imx8qm-rom7720: switch to binman“

So if you first apply the patches for the imx8qm-rom7720 Board it should work.

https://patchwork.ozlabs.org/project/uboot/patch/20221007130945.12493-1-oliver.graute@kococonnector.com/

Best regards,

Oliver

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Oliver Graute]

On 24/10/22, Stefano Babic wrote:
> On 24.10.22 13:37, Fabio Estevam wrote:
> > Hi Stefano and Oliver,
> > 
> > On Tue, May 3, 2022 at 7:49 AM Oliver Graute
> > <oliver.graute@kococonnector.com> wrote:
> > > 
> > > Switch to use binman to pack images
> > > 
> > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > > Reviewed-by: Fabio Estevam <festevam@denx.de>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > ---
> > > Changes for v3
> > >   -added Reviewed-by
> > >   -rebased on master
> > > 
> > >   arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
> > >   arch/arm/mach-imx/imx8/Kconfig      | 1 +
> > >   board/congatec/cgtqmx8/imximage.cfg | 4 ++--
> > >   configs/cgtqmx8_defconfig           | 2 +-
> > >   doc/board/congatec/cgtqmx8.rst      | 3 +--
> > >   5 files changed, 6 insertions(+), 5 deletions(-)
> > 
> > Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
> > 
> 
> Right - as well as V4, this is what I tried to merge and breaks. I have drop
> it.
> 
> > The previous v2 did include it:
> > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
> 
> Thanks for noting this - Oliver, can you check and repost a V5, then ?

The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
"PATCH v3 imx: imx8qm-rom7720: switch to binman"

So if you first apply the patches for the imx8qm-rom7720 Board it should work.

https://patchwork.ozlabs.org/project/uboot/patch/20221007130945.12493-1-oliver.graute@kococonnector.com/

Best regards,

Oliver

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Stefano Babic]

On 24.10.22 13:59, Oliver Graute wrote:
> On 24/10/22, Stefano Babic wrote:
>> On 24.10.22 13:37, Fabio Estevam wrote:
>>> Hi Stefano and Oliver,
>>>
>>> On Tue, May 3, 2022 at 7:49 AM Oliver Graute
>>> <oliver.graute@kococonnector.com> wrote:
>>>>
>>>> Switch to use binman to pack images
>>>>
>>>> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
>>>> Reviewed-by: Fabio Estevam <festevam@denx.de>
>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>> ---
>>>> Changes for v3
>>>>    -added Reviewed-by
>>>>    -rebased on master
>>>>
>>>>    arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
>>>>    arch/arm/mach-imx/imx8/Kconfig      | 1 +
>>>>    board/congatec/cgtqmx8/imximage.cfg | 4 ++--
>>>>    configs/cgtqmx8_defconfig           | 2 +-
>>>>    doc/board/congatec/cgtqmx8.rst      | 3 +--
>>>>    5 files changed, 6 insertions(+), 5 deletions(-)
>>>
>>> Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
>>>
>>
>> Right - as well as V4, this is what I tried to merge and breaks. I have drop
>> it.
>>
>>> The previous v2 did include it:
>>> https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
>>
>> Thanks for noting this - Oliver, can you check and repost a V5, then ?
> 
> The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
> "PATCH v3 imx: imx8qm-rom7720: switch to binman"
> 
> So if you first apply the patches for the imx8qm-rom7720 Board it should work.


Ok, thanks for tipp - I apply both and will test again

Stefano


> 
> https://patchwork.ozlabs.org/project/uboot/patch/20221007130945.12493-1-oliver.graute@kococonnector.com/
> 
> Best regards,
> 
> Oliver

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Oliver Graute]

On 24/10/22, Stefano Babic wrote:
> On 24.10.22 13:59, Oliver Graute wrote:
> > On 24/10/22, Stefano Babic wrote:
> > > On 24.10.22 13:37, Fabio Estevam wrote:
> > > > Hi Stefano and Oliver,
> > > > 
> > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute
> > > > <oliver.graute@kococonnector.com> wrote:
> > > > > 
> > > > > Switch to use binman to pack images
> > > > > 
> > > > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > > > > Reviewed-by: Fabio Estevam <festevam@denx.de>
> > > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > > ---
> > > > > Changes for v3
> > > > >    -added Reviewed-by
> > > > >    -rebased on master
> > > > > 
> > > > >    arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
> > > > >    arch/arm/mach-imx/imx8/Kconfig      | 1 +
> > > > >    board/congatec/cgtqmx8/imximage.cfg | 4 ++--
> > > > >    configs/cgtqmx8_defconfig           | 2 +-
> > > > >    doc/board/congatec/cgtqmx8.rst      | 3 +--
> > > > >    5 files changed, 6 insertions(+), 5 deletions(-)
> > > > 
> > > > Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
> > > > 
> > > 
> > > Right - as well as V4, this is what I tried to merge and breaks. I have drop
> > > it.
> > > 
> > > > The previous v2 did include it:
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
> > > 
> > > Thanks for noting this - Oliver, can you check and repost a V5, then ?
> > 
> > The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
> > "PATCH v3 imx: imx8qm-rom7720: switch to binman"
> > 
> > So if you first apply the patches for the imx8qm-rom7720 Board it should work.
> 
> 
> Ok, thanks for tipp - I apply both and will test again

I saw the CI Pipeline failing. Perhaps the reason is a
missing CONFIG_FIT_EXTERNAL_OFFSET?

+++ b/configs/cgtqmx8_defconfig
@@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
 CONFIG_REMAKE_ELF=y
 CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
 CONFIG_SPL_LOAD_FIT=y
 # CONFIG_USE_SPL_FIT_GENERATOR is not set

Can you confirm?

 Best regards,

 Oliver

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Stefano Babic]

On 25.10.22 10:50, Oliver Graute wrote:
> On 24/10/22, Stefano Babic wrote:
>> On 24.10.22 13:59, Oliver Graute wrote:
>>> On 24/10/22, Stefano Babic wrote:
>>>> On 24.10.22 13:37, Fabio Estevam wrote:
>>>>> Hi Stefano and Oliver,
>>>>>
>>>>> On Tue, May 3, 2022 at 7:49 AM Oliver Graute
>>>>> <oliver.graute@kococonnector.com> wrote:
>>>>>>
>>>>>> Switch to use binman to pack images
>>>>>>
>>>>>> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
>>>>>> Reviewed-by: Fabio Estevam <festevam@denx.de>
>>>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>>>> ---
>>>>>> Changes for v3
>>>>>>     -added Reviewed-by
>>>>>>     -rebased on master
>>>>>>
>>>>>>     arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
>>>>>>     arch/arm/mach-imx/imx8/Kconfig      | 1 +
>>>>>>     board/congatec/cgtqmx8/imximage.cfg | 4 ++--
>>>>>>     configs/cgtqmx8_defconfig           | 2 +-
>>>>>>     doc/board/congatec/cgtqmx8.rst      | 3 +--
>>>>>>     5 files changed, 6 insertions(+), 5 deletions(-)
>>>>>
>>>>> Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
>>>>>
>>>>
>>>> Right - as well as V4, this is what I tried to merge and breaks. I have drop
>>>> it.
>>>>
>>>>> The previous v2 did include it:
>>>>> https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
>>>>
>>>> Thanks for noting this - Oliver, can you check and repost a V5, then ?
>>>
>>> The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
>>> "PATCH v3 imx: imx8qm-rom7720: switch to binman"
>>>
>>> So if you first apply the patches for the imx8qm-rom7720 Board it should work.
>>
>>
>> Ok, thanks for tipp - I apply both and will test again
> 
> I saw the CI Pipeline failing. Perhaps the reason is a
> missing CONFIG_FIT_EXTERNAL_OFFSET?
> 

I see this, but just applying the two patches, multiple boards are broken:
imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi


> +++ b/configs/cgtqmx8_defconfig
> @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
>   CONFIG_REMAKE_ELF=y
>   CONFIG_FIT=y
> +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
>   CONFIG_SPL_LOAD_FIT=y
>   # CONFIG_USE_SPL_FIT_GENERATOR is not set
> 
> Can you confirm?
> 

I let CI run just to see if cgtqmx8 is fixed.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Stefano Babic]

On 25.10.22 11:28, Stefano Babic wrote:
> On 25.10.22 10:50, Oliver Graute wrote:
>> On 24/10/22, Stefano Babic wrote:
>>> On 24.10.22 13:59, Oliver Graute wrote:
>>>> On 24/10/22, Stefano Babic wrote:
>>>>> On 24.10.22 13:37, Fabio Estevam wrote:
>>>>>> Hi Stefano and Oliver,
>>>>>>
>>>>>> On Tue, May 3, 2022 at 7:49 AM Oliver Graute
>>>>>> <oliver.graute@kococonnector.com> wrote:
>>>>>>>
>>>>>>> Switch to use binman to pack images
>>>>>>>
>>>>>>> Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
>>>>>>> Reviewed-by: Fabio Estevam <festevam@denx.de>
>>>>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>>>>> ---
>>>>>>> Changes for v3
>>>>>>>     -added Reviewed-by
>>>>>>>     -rebased on master
>>>>>>>
>>>>>>>     arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
>>>>>>>     arch/arm/mach-imx/imx8/Kconfig      | 1 +
>>>>>>>     board/congatec/cgtqmx8/imximage.cfg | 4 ++--
>>>>>>>     configs/cgtqmx8_defconfig           | 2 +-
>>>>>>>     doc/board/congatec/cgtqmx8.rst      | 3 +--
>>>>>>>     5 files changed, 6 insertions(+), 5 deletions(-)
>>>>>>
>>>>>> Just realized that v3 does not include imx8qm-u-boot.dtsi and this 
>>>>>> breaks CI.
>>>>>>
>>>>>
>>>>> Right - as well as V4, this is what I tried to merge and breaks. I 
>>>>> have drop
>>>>> it.
>>>>>
>>>>>> The previous v2 did include it:
>>>>>> https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
>>>>>
>>>>> Thanks for noting this - Oliver, can you check and repost a V5, then ?
>>>>
>>>> The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
>>>> "PATCH v3 imx: imx8qm-rom7720: switch to binman"
>>>>
>>>> So if you first apply the patches for the imx8qm-rom7720 Board it 
>>>> should work.
>>>
>>>
>>> Ok, thanks for tipp - I apply both and will test again
>>
>> I saw the CI Pipeline failing. Perhaps the reason is a
>> missing CONFIG_FIT_EXTERNAL_OFFSET?
>>
> 
> I see this, but just applying the two patches, multiple boards are broken:
> imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi
> 
> 
>> +++ b/configs/cgtqmx8_defconfig
>> @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>>   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
>>   CONFIG_REMAKE_ELF=y
>>   CONFIG_FIT=y
>> +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
>>   CONFIG_SPL_LOAD_FIT=y
>>   # CONFIG_USE_SPL_FIT_GENERATOR is not set
>>
>> Can you confirm?
>>
> 
> I let CI run just to see if cgtqmx8 is fixed.

So this seems to fix the Congatec board. Rather, all DTS for i.MX8 are 
built together, and other boards have not switched to binman. I feel 
this dependency too hard. Should we maybe split the targets in 
arch/arm/dts/Makefile ? All DTS are build according to CONFIG_ARCH_IMX8, 
so congatec DTS is compiled even in case of deneb and gied.

See https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/13928.

Best regards,
Stefano

> 
> Stefano
> 

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3628 bytes --]

On Tue, Oct 25, 2022 at 02:07:55PM +0200, Stefano Babic wrote:
> On 25.10.22 11:28, Stefano Babic wrote:
> > On 25.10.22 10:50, Oliver Graute wrote:
> > > On 24/10/22, Stefano Babic wrote:
> > > > On 24.10.22 13:59, Oliver Graute wrote:
> > > > > On 24/10/22, Stefano Babic wrote:
> > > > > > On 24.10.22 13:37, Fabio Estevam wrote:
> > > > > > > Hi Stefano and Oliver,
> > > > > > > 
> > > > > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute
> > > > > > > <oliver.graute@kococonnector.com> wrote:
> > > > > > > > 
> > > > > > > > Switch to use binman to pack images
> > > > > > > > 
> > > > > > > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > > > > > > > Reviewed-by: Fabio Estevam <festevam@denx.de>
> > > > > > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > > > > > ---
> > > > > > > > Changes for v3
> > > > > > > >     -added Reviewed-by
> > > > > > > >     -rebased on master
> > > > > > > > 
> > > > > > > >     arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
> > > > > > > >     arch/arm/mach-imx/imx8/Kconfig      | 1 +
> > > > > > > >     board/congatec/cgtqmx8/imximage.cfg | 4 ++--
> > > > > > > >     configs/cgtqmx8_defconfig           | 2 +-
> > > > > > > >     doc/board/congatec/cgtqmx8.rst      | 3 +--
> > > > > > > >     5 files changed, 6 insertions(+), 5 deletions(-)
> > > > > > > 
> > > > > > > Just realized that v3 does not include
> > > > > > > imx8qm-u-boot.dtsi and this breaks CI.
> > > > > > > 
> > > > > > 
> > > > > > Right - as well as V4, this is what I tried to merge and
> > > > > > breaks. I have drop
> > > > > > it.
> > > > > > 
> > > > > > > The previous v2 did include it:
> > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
> > > > > > 
> > > > > > Thanks for noting this - Oliver, can you check and repost a V5, then ?
> > > > > 
> > > > > The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
> > > > > "PATCH v3 imx: imx8qm-rom7720: switch to binman"
> > > > > 
> > > > > So if you first apply the patches for the imx8qm-rom7720
> > > > > Board it should work.
> > > > 
> > > > 
> > > > Ok, thanks for tipp - I apply both and will test again
> > > 
> > > I saw the CI Pipeline failing. Perhaps the reason is a
> > > missing CONFIG_FIT_EXTERNAL_OFFSET?
> > > 
> > 
> > I see this, but just applying the two patches, multiple boards are broken:
> > imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi
> > 
> > 
> > > +++ b/configs/cgtqmx8_defconfig
> > > @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> > >   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
> > >   CONFIG_REMAKE_ELF=y
> > >   CONFIG_FIT=y
> > > +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
> > >   CONFIG_SPL_LOAD_FIT=y
> > >   # CONFIG_USE_SPL_FIT_GENERATOR is not set
> > > 
> > > Can you confirm?
> > > 
> > 
> > I let CI run just to see if cgtqmx8 is fixed.
> 
> So this seems to fix the Congatec board. Rather, all DTS for i.MX8 are built
> together, and other boards have not switched to binman. I feel this
> dependency too hard. Should we maybe split the targets in
> arch/arm/dts/Makefile ? All DTS are build according to CONFIG_ARCH_IMX8, so
> congatec DTS is compiled even in case of deneb and gied.
> 
> See https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/13928.

IMHO at this point we need to just untested-convert those last
outstanding board or boards, or remove them. This migration has been
dragging on and on and I'm sure I've mailed the board maintainers a few
times.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman

[Oliver Graute]

On 25/10/22, Stefano Babic wrote:
> On 25.10.22 10:50, Oliver Graute wrote:
> > On 24/10/22, Stefano Babic wrote:
> > > On 24.10.22 13:59, Oliver Graute wrote:
> > > > On 24/10/22, Stefano Babic wrote:
> > > > > On 24.10.22 13:37, Fabio Estevam wrote:
> > > > > > Hi Stefano and Oliver,
> > > > > > 
> > > > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute
> > > > > > <oliver.graute@kococonnector.com> wrote:
> > > > > > > 
> > > > > > > Switch to use binman to pack images
> > > > > > > 
> > > > > > > Signed-off-by: Oliver Graute <oliver.graute@kococonnector.com>
> > > > > > > Reviewed-by: Fabio Estevam <festevam@denx.de>
> > > > > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > > > > ---
> > > > > > > Changes for v3
> > > > > > >     -added Reviewed-by
> > > > > > >     -rebased on master
> > > > > > > 
> > > > > > >     arch/arm/dts/imx8qm-cgtqmx8.dts     | 1 +
> > > > > > >     arch/arm/mach-imx/imx8/Kconfig      | 1 +
> > > > > > >     board/congatec/cgtqmx8/imximage.cfg | 4 ++--
> > > > > > >     configs/cgtqmx8_defconfig           | 2 +-
> > > > > > >     doc/board/congatec/cgtqmx8.rst      | 3 +--
> > > > > > >     5 files changed, 6 insertions(+), 5 deletions(-)
> > > > > > 
> > > > > > Just realized that v3 does not include imx8qm-u-boot.dtsi and this breaks CI.
> > > > > > 
> > > > > 
> > > > > Right - as well as V4, this is what I tried to merge and breaks. I have drop
> > > > > it.
> > > > > 
> > > > > > The previous v2 did include it:
> > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220221090139.10066-1-oliver.graute@kococonnector.com/
> > > > > 
> > > > > Thanks for noting this - Oliver, can you check and repost a V5, then ?
> > > > 
> > > > The arch/arm/dts/imx8qm-u-boot.dtsi  is applied on the binman Patch for
> > > > "PATCH v3 imx: imx8qm-rom7720: switch to binman"
> > > > 
> > > > So if you first apply the patches for the imx8qm-rom7720 Board it should work.
> > > 
> > > 
> > > Ok, thanks for tipp - I apply both and will test again
> > 
> > I saw the CI Pipeline failing. Perhaps the reason is a
> > missing CONFIG_FIT_EXTERNAL_OFFSET?
> > 
> 
> I see this, but just applying the two patches, multiple boards are broken:
> imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi
> 
> 
> > +++ b/configs/cgtqmx8_defconfig
> > @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> >   CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
> >   CONFIG_REMAKE_ELF=y
> >   CONFIG_FIT=y
> > +CONFIG_FIT_EXTERNAL_OFFSET=0x3000
> >   CONFIG_SPL_LOAD_FIT=y
> >   # CONFIG_USE_SPL_FIT_GENERATOR is not set
> > 
> > Can you confirm?
> > 
> 
> I let CI run just to see if cgtqmx8 is fixed.

For imx8qm_rom7720 the CONFIG_FIT_EXTERNAL_OFFSET is also missing

--- a/configs/imx8qm_rom7720_a1_4G_defconfig
+++ b/configs/imx8qm_rom7720_a1_4G_defconfig
@@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000
 CONFIG_REMAKE_ELF=y
 CONFIG_FIT=y
+CONFIG_FIT_EXTERNAL_OFFSET=0x3000
 CONFIG_SPL_LOAD_FIT=y
 # CONFIG_USE_SPL_FIT_GENERATOR is not set
 CONFIG_BOOTDELAY=3


Best regards,

Oliver