* [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
@ 2022-10-26 22:44 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-10-26 22:44 UTC (permalink / raw)
To: linux-kernel
Cc: justinpopo6, Florian Fainelli, Al Cooper,
Broadcom internal kernel review list, Kishon Vijay Abraham I,
Vinod Koul, open list:GENERIC PHY FRAMEWORK
The wake-up interrupt lines are entirely optional, avoid printing
messages that interrupts were not found by switching to the _optional
variant.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
index 2cb3779fcdf8..fbf454b206f2 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
priv->suspend_clk = NULL;
}
- priv->wake_irq = platform_get_irq_byname(pdev, "wake");
+ priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
if (priv->wake_irq < 0)
- priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
+ priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
if (priv->wake_irq >= 0) {
err = devm_request_irq(dev, priv->wake_irq,
brcm_usb_phy_wake_isr, 0,
--
2.25.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
@ 2022-10-26 22:44 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-10-26 22:44 UTC (permalink / raw)
To: linux-kernel
Cc: justinpopo6, Florian Fainelli, Al Cooper,
Broadcom internal kernel review list, Kishon Vijay Abraham I,
Vinod Koul, open list:GENERIC PHY FRAMEWORK
The wake-up interrupt lines are entirely optional, avoid printing
messages that interrupts were not found by switching to the _optional
variant.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
index 2cb3779fcdf8..fbf454b206f2 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
priv->suspend_clk = NULL;
}
- priv->wake_irq = platform_get_irq_byname(pdev, "wake");
+ priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
if (priv->wake_irq < 0)
- priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
+ priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
if (priv->wake_irq >= 0) {
err = devm_request_irq(dev, priv->wake_irq,
brcm_usb_phy_wake_isr, 0,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
2022-10-26 22:44 ` Florian Fainelli
@ 2022-10-27 16:49 ` Justin Chen
-1 siblings, 0 replies; 6+ messages in thread
From: Justin Chen @ 2022-10-27 16:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Al Cooper, Broadcom internal kernel review list,
Kishon Vijay Abraham I, Vinod Koul,
open list:GENERIC PHY FRAMEWORK
On Wed, Oct 26, 2022 at 3:45 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Justin Chen <justinpopo6@gmail.com>
> ---
> drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
> index 2cb3779fcdf8..fbf454b206f2 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb.c
> @@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
> priv->suspend_clk = NULL;
> }
>
> - priv->wake_irq = platform_get_irq_byname(pdev, "wake");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
> if (priv->wake_irq < 0)
> - priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
> if (priv->wake_irq >= 0) {
> err = devm_request_irq(dev, priv->wake_irq,
> brcm_usb_phy_wake_isr, 0,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
@ 2022-10-27 16:49 ` Justin Chen
0 siblings, 0 replies; 6+ messages in thread
From: Justin Chen @ 2022-10-27 16:49 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Al Cooper, Broadcom internal kernel review list,
Kishon Vijay Abraham I, Vinod Koul,
open list:GENERIC PHY FRAMEWORK
On Wed, Oct 26, 2022 at 3:45 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Justin Chen <justinpopo6@gmail.com>
> ---
> drivers/phy/broadcom/phy-brcm-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
> index 2cb3779fcdf8..fbf454b206f2 100644
> --- a/drivers/phy/broadcom/phy-brcm-usb.c
> +++ b/drivers/phy/broadcom/phy-brcm-usb.c
> @@ -445,9 +445,9 @@ static int brcm_usb_phy_dvr_init(struct platform_device *pdev,
> priv->suspend_clk = NULL;
> }
>
> - priv->wake_irq = platform_get_irq_byname(pdev, "wake");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wake");
> if (priv->wake_irq < 0)
> - priv->wake_irq = platform_get_irq_byname(pdev, "wakeup");
> + priv->wake_irq = platform_get_irq_byname_optional(pdev, "wakeup");
> if (priv->wake_irq >= 0) {
> err = devm_request_irq(dev, priv->wake_irq,
> brcm_usb_phy_wake_isr, 0,
> --
> 2.25.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
2022-10-26 22:44 ` Florian Fainelli
@ 2022-11-05 14:37 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-11-05 14:37 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, justinpopo6, Al Cooper,
Broadcom internal kernel review list, Kishon Vijay Abraham I,
open list:GENERIC PHY FRAMEWORK
On 26-10-22, 15:44, Florian Fainelli wrote:
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional()
@ 2022-11-05 14:37 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-11-05 14:37 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, justinpopo6, Al Cooper,
Broadcom internal kernel review list, Kishon Vijay Abraham I,
open list:GENERIC PHY FRAMEWORK
On 26-10-22, 15:44, Florian Fainelli wrote:
> The wake-up interrupt lines are entirely optional, avoid printing
> messages that interrupts were not found by switching to the _optional
> variant.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-05 14:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 22:44 [PATCH] phy: phy-brcm-usb: Utilize platform_get_irq_byname_optional() Florian Fainelli
2022-10-26 22:44 ` Florian Fainelli
2022-10-27 16:49 ` Justin Chen
2022-10-27 16:49 ` Justin Chen
2022-11-05 14:37 ` Vinod Koul
2022-11-05 14:37 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.