From: Bjorn Andersson <andersson@kernel.org> To: Johan Hovold <johan@kernel.org> Cc: Bjorn Andersson <quic_bjorande@quicinc.com>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kuogee Hsieh <quic_khsieh@quicinc.com>, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances Date: Wed, 26 Oct 2022 21:00:07 -0500 [thread overview] Message-ID: <20221027020007.bkbmqbodihxlefnl@builder.lan> (raw) In-Reply-To: <Y1ke9xp8m5zWg+Mu@hovoldconsulting.com> On Wed, Oct 26, 2022 at 01:50:15PM +0200, Johan Hovold wrote: > On Tue, Oct 25, 2022 at 08:26:24PM -0700, Bjorn Andersson wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > > > Enable Display Clock controllers, MDSS instanced, MDPs, DP controllers, > > DP PHYs and link them all together. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > --- > > > &apps_rsc { > > @@ -156,13 +240,169 @@ vreg_l7g: ldo7 { > > > > vreg_l8g: ldo8 { > > regulator-name = "vreg_l8g"; > > - regulator-min-microvolt = <880000>; > > - regulator-max-microvolt = <880000>; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + regulator-allow-set-load; > > Did you really intend to allow set-load here? > > I'm guessing this wasn't the case, but otherwise you also need to > specify the valid modes. > I see no reason for keeping it at this point in time, will drop it. Thanks, Bjorn > > + }; > > + > > + vreg_l11g: ldo11 { > > + regulator-name = "vreg_l11g"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > }; > > }; > > }; > > > +&mdss0_dp2_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l8g>; > > + vdda-pll-supply = <&vreg_l3g>; > > +}; > > Johan
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org> To: Johan Hovold <johan@kernel.org> Cc: freedreno@lists.freedesktop.org, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, Bjorn Andersson <quic_bjorande@quicinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, Konrad Dybcio <konrad.dybcio@somainline.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, Kuogee Hsieh <quic_khsieh@quicinc.com>, Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances Date: Wed, 26 Oct 2022 21:00:07 -0500 [thread overview] Message-ID: <20221027020007.bkbmqbodihxlefnl@builder.lan> (raw) In-Reply-To: <Y1ke9xp8m5zWg+Mu@hovoldconsulting.com> On Wed, Oct 26, 2022 at 01:50:15PM +0200, Johan Hovold wrote: > On Tue, Oct 25, 2022 at 08:26:24PM -0700, Bjorn Andersson wrote: > > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > > > Enable Display Clock controllers, MDSS instanced, MDPs, DP controllers, > > DP PHYs and link them all together. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > > --- > > > &apps_rsc { > > @@ -156,13 +240,169 @@ vreg_l7g: ldo7 { > > > > vreg_l8g: ldo8 { > > regulator-name = "vreg_l8g"; > > - regulator-min-microvolt = <880000>; > > - regulator-max-microvolt = <880000>; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > + regulator-allow-set-load; > > Did you really intend to allow set-load here? > > I'm guessing this wasn't the case, but otherwise you also need to > specify the valid modes. > I see no reason for keeping it at this point in time, will drop it. Thanks, Bjorn > > + }; > > + > > + vreg_l11g: ldo11 { > > + regulator-name = "vreg_l11g"; > > + regulator-min-microvolt = <912000>; > > + regulator-max-microvolt = <912000>; > > regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>; > > }; > > }; > > }; > > > +&mdss0_dp2_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l8g>; > > + vdda-pll-supply = <&vreg_l3g>; > > +}; > > Johan
next prev parent reply other threads:[~2022-10-27 2:00 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-26 3:26 [PATCH v3 00/12] drm/msm: Add SC8280XP support Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 01/12] dt-bindings: display/msm: Add binding for SC8280XP MDSS Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 12:36 ` Rob Herring 2022-10-26 12:36 ` Rob Herring 2022-10-26 17:54 ` Rob Herring 2022-10-26 17:54 ` Rob Herring 2022-10-27 2:05 ` Bjorn Andersson 2022-10-27 2:05 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 02/12] drm/msm/dpu: Introduce SC8280XP Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 16:49 ` kernel test robot 2022-11-02 23:35 ` Dmitry Baryshkov 2022-11-02 23:35 ` Dmitry Baryshkov 2022-10-26 3:26 ` [PATCH v3 03/12] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 04/12] drm/msm/dp: Stop using DP id as index in desc Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-11-02 23:36 ` Dmitry Baryshkov 2022-11-02 23:36 ` Dmitry Baryshkov 2022-10-26 3:26 ` [PATCH v3 05/12] drm/msm/dp: Add DP and EDP compatibles for SC8280XP Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 06/12] drm/msm/dp: Add SDM845 DisplayPort instance Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 07/12] drm/msm/dp: Implement hpd_notify() Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 08/12] drm/msm/dp: Don't enable HPD interrupts for edp Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 09/12] drm/msm/dp: HPD handling relates to next_bridge Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 6:08 ` Dmitry Baryshkov 2022-10-26 6:08 ` Dmitry Baryshkov 2022-10-27 1:58 ` Bjorn Andersson 2022-10-27 1:58 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 11:55 ` Johan Hovold 2022-10-26 11:55 ` Johan Hovold 2022-10-26 19:11 ` kernel test robot 2022-10-27 5:58 ` kernel test robot 2022-11-18 23:15 ` Kuogee Hsieh 2022-11-18 23:15 ` Kuogee Hsieh 2022-11-30 20:07 ` Bjorn Andersson 2022-11-30 20:07 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 3:26 ` [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances Bjorn Andersson 2022-10-26 3:26 ` Bjorn Andersson 2022-10-26 11:50 ` Johan Hovold 2022-10-26 11:50 ` Johan Hovold 2022-10-27 2:00 ` Bjorn Andersson [this message] 2022-10-27 2:00 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221027020007.bkbmqbodihxlefnl@builder.lan \ --to=andersson@kernel.org \ --cc=airlied@gmail.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=johan@kernel.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_bjorande@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.