All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org,
	"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>
Cc: Hannes Reinecke <hare@suse.de>
Subject: [PATCH v3 5/6] ata: libata: blacklist FUA support for known buggy drives
Date: Thu, 27 Oct 2022 16:50:25 +0900	[thread overview]
Message-ID: <20221027075026.240017-6-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20221027075026.240017-1-damien.lemoal@opensource.wdc.com>

Thread [1] reported back in 2012 problems with enabling FUA for 3
different drives. Add these drives to ata_device_blacklist[] to mark
them with the ATA_HORKAGE_NO_FUA flag. To be conservative and avoid
problems on old systems, the model number for the three new entries
are defined as to widely match all drives in the same product line.

[1]: https://lore.kernel.org/lkml/CA+6av4=uxu_q5U_46HtpUt=FSgbh3pZuAEY54J5_xK=MKWq-YQ@mail.gmail.com/

Suggested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index fea06f41f371..ec732c47b6fb 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4144,6 +4144,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 
 	/* Buggy FUA */
 	{ "Maxtor",		"BANC1G10",	ATA_HORKAGE_NO_FUA },
+	{ "WDC*WD2500J*",	NULL,		ATA_HORKAGE_NO_FUA },
+	{ "OCZ-VERTEX*",	NULL,		ATA_HORKAGE_NO_FUA },
+	{ "INTEL*SSDSC2CT*",	NULL,		ATA_HORKAGE_NO_FUA },
 
 	/* End Marker */
 	{ }
-- 
2.37.3


  parent reply	other threads:[~2022-10-27  7:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  7:50 [PATCH v3 0/6] Improve libata support for FUA Damien Le Moal
2022-10-27  7:50 ` [PATCH v3 1/6] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-10-27  9:24   ` Hannes Reinecke
2022-10-27  7:50 ` [PATCH v3 2/6] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-10-27  9:25   ` Hannes Reinecke
2022-10-27  9:43   ` Sergei Shtylyov
2022-10-27  7:50 ` [PATCH v3 3/6] ata: libata: cleanup fua handling Damien Le Moal
2022-10-27  9:32   ` Hannes Reinecke
2022-10-27  7:50 ` [PATCH v3 4/6] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-10-27  8:21   ` Niklas Cassel
2022-10-27  9:12     ` Damien Le Moal
2022-10-27  9:42   ` Hannes Reinecke
2022-10-27 22:22     ` Damien Le Moal
2022-10-28 10:01       ` Hannes Reinecke
2022-10-28 16:45       ` Maciej S. Szmigiero
2022-10-28 16:45   ` Maciej S. Szmigiero
2022-10-27  7:50 ` Damien Le Moal [this message]
2022-10-27  7:50 ` [PATCH v3 6/6] ata: libata: Enable fua support by default Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027075026.240017-6-damien.lemoal@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.