All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	linux-ide@vger.kernel.org,
	"Maciej S . Szmigiero" <mail@maciej.szmigiero.name>
Cc: Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 2/6] ata: libata: Rename and cleanup ata_rwcmd_protocol()
Date: Thu, 27 Oct 2022 12:43:19 +0300	[thread overview]
Message-ID: <ec971154-47c5-2e93-23e5-40090d29d2ff@gmail.com> (raw)
In-Reply-To: <20221027075026.240017-3-damien.lemoal@opensource.wdc.com>

Hello!

On 10/27/22 10:50 AM, Damien Le Moal wrote:

> Rename ata_rwcmd_protocol() to ata_set_rwcmd_protocol() to better
> reflect the fact that this function sets a task file command and
> protocol. The arguments order is also reversed and the function return
> type changed to a bool to indicate if the command and protocol were set
> corretly (instead of returning a completely arbitrary "-1" value.

   Correctly. :-)

> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
>  drivers/ata/libata-core.c | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 884ae73b11ea..56ddcbaa0c6f 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -574,17 +574,18 @@ static const u8 ata_rw_cmds[] = {
>  };
>  
>  /**
> - *	ata_rwcmd_protocol - set taskfile r/w commands and protocol
> + *	ata_set_rwcmd_protocol - set taskfile r/w command and protocol
> + *	@dev: target device for the tf

   s/tf/taskfile/?

>   *	@tf: command to examine and configure
> - *	@dev: device tf belongs to
[...]

MBR, Sergey

  parent reply	other threads:[~2022-10-27  9:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  7:50 [PATCH v3 0/6] Improve libata support for FUA Damien Le Moal
2022-10-27  7:50 ` [PATCH v3 1/6] ata: libata: Introduce ata_ncq_supported() Damien Le Moal
2022-10-27  9:24   ` Hannes Reinecke
2022-10-27  7:50 ` [PATCH v3 2/6] ata: libata: Rename and cleanup ata_rwcmd_protocol() Damien Le Moal
2022-10-27  9:25   ` Hannes Reinecke
2022-10-27  9:43   ` Sergei Shtylyov [this message]
2022-10-27  7:50 ` [PATCH v3 3/6] ata: libata: cleanup fua handling Damien Le Moal
2022-10-27  9:32   ` Hannes Reinecke
2022-10-27  7:50 ` [PATCH v3 4/6] ata: libata: Fix FUA handling in ata_build_rw_tf() Damien Le Moal
2022-10-27  8:21   ` Niklas Cassel
2022-10-27  9:12     ` Damien Le Moal
2022-10-27  9:42   ` Hannes Reinecke
2022-10-27 22:22     ` Damien Le Moal
2022-10-28 10:01       ` Hannes Reinecke
2022-10-28 16:45       ` Maciej S. Szmigiero
2022-10-28 16:45   ` Maciej S. Szmigiero
2022-10-27  7:50 ` [PATCH v3 5/6] ata: libata: blacklist FUA support for known buggy drives Damien Le Moal
2022-10-27  7:50 ` [PATCH v3 6/6] ata: libata: Enable fua support by default Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec971154-47c5-2e93-23e5-40090d29d2ff@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.