* [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard
@ 2022-10-27 9:03 Nicolas Dumazet
2022-11-09 11:29 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Dumazet @ 2022-10-27 9:03 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jean-Francois Le Fillatre
Cc: Petar Kostic, Oliver Neukum, Ole Ernst, Hannu Hartikainen,
Jimmy Wang, linux-usb, linux-kernel, Nicolas Dumazet, stable
Before adding this quirk, this (mechanical keyboard) device would not be
recognized, logging:
new full-speed USB device number 56 using xhci_hcd
unable to read config index 0 descriptor/start: -32
chopping to 0 config(s)
It would take dozens of plugging/unpuggling cycles for the keyboard to
be recognized. Keyboard seems to simply work after applying this quirk.
This issue had been reported by users in two places already ([1], [2])
but nobody tried upstreaming a patch yet. After testing I believe their
suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a
little overkill. I assume this particular combination was tested because
it had been previously suggested in [3], but only NO_LPM seems
sufficient for this device.
[1]: https://qiita.com/float168/items/fed43d540c8e2201b543
[2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/
[3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477
---
Changes in v2:
- add the entry to the right location (sorting entries by
vendor/device id).
Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Dumazet <ndumazet@google.com>
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0722d2131305..079e183cf3bf 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -362,6 +362,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x0781, 0x5583), .driver_info = USB_QUIRK_NO_LPM },
{ USB_DEVICE(0x0781, 0x5591), .driver_info = USB_QUIRK_NO_LPM },
+ /* Realforce 87U Keyboard */
+ { USB_DEVICE(0x0853, 0x011b), .driver_info = USB_QUIRK_NO_LPM },
+
/* M-Systems Flash Disk Pioneers */
{ USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },
--
2.38.0.135.g90850a2211-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard
2022-10-27 9:03 [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard Nicolas Dumazet
@ 2022-11-09 11:29 ` Greg Kroah-Hartman
2022-11-09 12:31 ` Nicolas Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-11-09 11:29 UTC (permalink / raw)
To: Nicolas Dumazet
Cc: Jean-Francois Le Fillatre, Petar Kostic, Oliver Neukum,
Ole Ernst, Hannu Hartikainen, Jimmy Wang, linux-usb,
linux-kernel, stable
On Thu, Oct 27, 2022 at 11:03:42AM +0200, Nicolas Dumazet wrote:
> Before adding this quirk, this (mechanical keyboard) device would not be
> recognized, logging:
>
> new full-speed USB device number 56 using xhci_hcd
> unable to read config index 0 descriptor/start: -32
> chopping to 0 config(s)
>
> It would take dozens of plugging/unpuggling cycles for the keyboard to
> be recognized. Keyboard seems to simply work after applying this quirk.
>
> This issue had been reported by users in two places already ([1], [2])
> but nobody tried upstreaming a patch yet. After testing I believe their
> suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a
> little overkill. I assume this particular combination was tested because
> it had been previously suggested in [3], but only NO_LPM seems
> sufficient for this device.
>
> [1]: https://qiita.com/float168/items/fed43d540c8e2201b543
> [2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/
> [3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477
>
> ---
> Changes in v2:
> - add the entry to the right location (sorting entries by
> vendor/device id).
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Dumazet <ndumazet@google.com>
> ---
By putting your s-o-b below the --- line, tools will drop it, how did
you test this?
Put the v2 stuff below the --- line, don't add a new one. See the
thousands of examples on the list for how to do this correctly (as well
as the kernel documentation.)
Can you fix this up and resend a v3 please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard
2022-11-09 11:29 ` Greg Kroah-Hartman
@ 2022-11-09 12:31 ` Nicolas Dumazet
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Dumazet @ 2022-11-09 12:31 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jean-Francois Le Fillatre, Petar Kostic, Oliver Neukum,
Ole Ernst, Hannu Hartikainen, Jimmy Wang, linux-usb,
linux-kernel, stable
[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]
On Wed, Nov 9, 2022 at 12:29 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Oct 27, 2022 at 11:03:42AM +0200, Nicolas Dumazet wrote:
> > Before adding this quirk, this (mechanical keyboard) device would not be
> > recognized, logging:
> >
> > new full-speed USB device number 56 using xhci_hcd
> > unable to read config index 0 descriptor/start: -32
> > chopping to 0 config(s)
> >
> > It would take dozens of plugging/unpuggling cycles for the keyboard to
> > be recognized. Keyboard seems to simply work after applying this quirk.
> >
> > This issue had been reported by users in two places already ([1], [2])
> > but nobody tried upstreaming a patch yet. After testing I believe their
> > suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a
> > little overkill. I assume this particular combination was tested because
> > it had been previously suggested in [3], but only NO_LPM seems
> > sufficient for this device.
> >
> > [1]: https://qiita.com/float168/items/fed43d540c8e2201b543
> > [2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/
> > [3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477
> >
> > ---
> > Changes in v2:
> > - add the entry to the right location (sorting entries by
> > vendor/device id).
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Nicolas Dumazet <ndumazet@google.com>
> > ---
>
> By putting your s-o-b below the --- line, tools will drop it, how did
> you test this?
>
> Put the v2 stuff below the --- line, don't add a new one. See the
> thousands of examples on the list for how to do this correctly (as well
> as the kernel documentation.)
>
> Can you fix this up and resend a v3 please?
Duh -- apologies for this rookie mistake. v3 sent your way.
>
> thanks,
>
> greg k-h
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-09 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 9:03 [PATCH v2] usb: add NO_LPM quirk for Realforce 87U Keyboard Nicolas Dumazet
2022-11-09 11:29 ` Greg Kroah-Hartman
2022-11-09 12:31 ` Nicolas Dumazet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.