All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: <jaegeuk@kernel.org>, <chao@kernel.org>, <mhiramat@kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>
Subject: Re: [PATCH 2/2] f2fs: fix the msg data type
Date: Thu, 27 Oct 2022 15:47:02 +0530	[thread overview]
Message-ID: <20221027101702.GA18823@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <1666861961-12924-2-git-send-email-quic_mojha@quicinc.com>

On Thu, Oct 27, 2022 at 02:42:41PM +0530, Mukesh Ojha wrote:
> Data type of msg in f2fs_write_checkpoint trace should
> be const char * instead of char *.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
>  include/trace/events/f2fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index ff57e7f..7fbfce4 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -1404,7 +1404,7 @@ TRACE_EVENT(f2fs_readpages,
>  
>  TRACE_EVENT(f2fs_write_checkpoint,
>  
> -	TP_PROTO(struct super_block *sb, int reason, char *msg),
> +	TP_PROTO(struct super_block *sb, int reason, const char *msg),
>  
>  	TP_ARGS(sb, reason, msg),
>  
LGTM. one minor comment.

Declare it const char pointer in the trace point structure also.

diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 11f6b71..22960e6 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -1429,7 +1429,7 @@ TRACE_EVENT(f2fs_write_checkpoint,
 	TP_STRUCT__entry(
 		__field(dev_t,	dev)
 		__field(int,	reason)
-		__field(char *,	msg)
+		__field(const char *,	msg)
 	),
 
 	TP_fast_assign(

Thanks,
Pavan

WARNING: multiple messages have this Message-ID (diff)
From: Pavan Kondeti <quic_pkondeti@quicinc.com>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: quic_pkondeti@quicinc.com, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, mhiramat@kernel.org,
	jaegeuk@kernel.org
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: fix the msg data type
Date: Thu, 27 Oct 2022 15:47:02 +0530	[thread overview]
Message-ID: <20221027101702.GA18823@hu-pkondeti-hyd.qualcomm.com> (raw)
In-Reply-To: <1666861961-12924-2-git-send-email-quic_mojha@quicinc.com>

On Thu, Oct 27, 2022 at 02:42:41PM +0530, Mukesh Ojha wrote:
> Data type of msg in f2fs_write_checkpoint trace should
> be const char * instead of char *.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
>  include/trace/events/f2fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index ff57e7f..7fbfce4 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -1404,7 +1404,7 @@ TRACE_EVENT(f2fs_readpages,
>  
>  TRACE_EVENT(f2fs_write_checkpoint,
>  
> -	TP_PROTO(struct super_block *sb, int reason, char *msg),
> +	TP_PROTO(struct super_block *sb, int reason, const char *msg),
>  
>  	TP_ARGS(sb, reason, msg),
>  
LGTM. one minor comment.

Declare it const char pointer in the trace point structure also.

diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index 11f6b71..22960e6 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -1429,7 +1429,7 @@ TRACE_EVENT(f2fs_write_checkpoint,
 	TP_STRUCT__entry(
 		__field(dev_t,	dev)
 		__field(int,	reason)
-		__field(char *,	msg)
+		__field(const char *,	msg)
 	),
 
 	TP_fast_assign(

Thanks,
Pavan


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2022-10-27 10:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27  9:12 [PATCH v2 1/2] f2fs: fix the assign logic of iocb Mukesh Ojha
2022-10-27  9:12 ` [f2fs-dev] " Mukesh Ojha
2022-10-27  9:12 ` [PATCH 2/2] f2fs: fix the msg data type Mukesh Ojha
2022-10-27  9:12   ` [f2fs-dev] " Mukesh Ojha
2022-10-27 10:17   ` Pavan Kondeti [this message]
2022-10-27 10:17     ` Pavan Kondeti
2022-10-27 10:30     ` Pavan Kondeti
2022-10-27 10:30       ` Pavan Kondeti
2022-10-29  2:55   ` Chao Yu
2022-10-29  2:55     ` [f2fs-dev] " Chao Yu
2022-10-29  2:55 ` [f2fs-dev] [PATCH v2 1/2] f2fs: fix the assign logic of iocb Chao Yu
2022-10-29  2:55   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027101702.GA18823@hu-pkondeti-hyd.qualcomm.com \
    --to=quic_pkondeti@quicinc.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=quic_mojha@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.