All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec
@ 2022-10-27 12:56 Michael Ellerman
  2022-11-01 12:25 ` Michael Ellerman
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2022-10-27 12:56 UTC (permalink / raw)
  To: linuxppc-dev

There's a build failure for Book3E without AltiVec:
  Error: cc1: error: AltiVec not supported in this target
  make[6]: *** [/linux/scripts/Makefile.build:250:
  drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o] Error 1

This happens because the amdgpu build is only gated by
PPC_LONG_DOUBLE_128, but that symbol can be enabled even though AltiVec
is disabled.

The only user of PPC_LONG_DOUBLE_128 is amdgpu, so just add a dependency
on AltiVec to that symbol to fix the build.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/powerpc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 699df27b0e2f..20fb1765238c 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -285,7 +285,7 @@ config PPC
 	#
 
 config PPC_LONG_DOUBLE_128
-	depends on PPC64
+	depends on PPC64 && ALTIVEC
 	def_bool $(success,test "$(shell,echo __LONG_DOUBLE_128__ | $(CC) -E -P -)" = 1)
 
 config PPC_BARRIER_NOSPEC
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec
  2022-10-27 12:56 [PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec Michael Ellerman
@ 2022-11-01 12:25 ` Michael Ellerman
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-11-01 12:25 UTC (permalink / raw)
  To: Michael Ellerman, linuxppc-dev

On Thu, 27 Oct 2022 23:56:26 +1100, Michael Ellerman wrote:
> There's a build failure for Book3E without AltiVec:
>   Error: cc1: error: AltiVec not supported in this target
>   make[6]: *** [/linux/scripts/Makefile.build:250:
>   drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o] Error 1
> 
> This happens because the amdgpu build is only gated by
> PPC_LONG_DOUBLE_128, but that symbol can be enabled even though AltiVec
> is disabled.
> 
> [...]

Applied to powerpc/fixes.

[1/1] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec
      https://git.kernel.org/powerpc/c/2153fc9623e5465f503d793d4c94ad65e9ec9b5f

cheers

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-01 12:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 12:56 [PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec Michael Ellerman
2022-11-01 12:25 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.