drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:46:28: warning: Parameter 'secy' can be declared as pointer to const [constParameter]

drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:46:28: warning: Parameter 'secy' can be declared as pointer to const [constParameter]

[kernel test robot]

:::::: 
:::::: Manual check reason: "low confidence static check warning: drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:46:28: warning: Parameter 'secy' can be declared as pointer to const [constParameter]"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Subbaraya Sundeep <sbhatta@marvell.com>
CC: Sunil Goutham <sgoutham@marvell.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   882ad2a2a8ffa1defecdf907052f04da2737dc46
commit: c54ffc73601c0a239e55911923a6e23a2a74f143 octeontx2-pf: mcs: Introduce MACSEC hardware offloading
date:   4 weeks ago
:::::: branch date: 11 hours ago
:::::: commit date: 4 weeks ago
compiler: mips64el-linux-gcc (GCC) 12.1.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout c54ffc73601c0a239e55911923a6e23a2a74f143
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:288:3: warning: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak]
     goto fail;
     ^
   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:598:3: warning: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak]
     goto fail;
     ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:46:28: warning: Parameter 'secy' can be declared as pointer to const [constParameter]
          struct macsec_secy *secy)
                              ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:60:29: warning: Parameter 'rx_sc' can be declared as pointer to const [constParameter]
          struct macsec_rx_sc *rx_sc)
                               ^
   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:59:28: warning: Parameter 'secy' can be declared as pointer to const [constParameter]
          struct macsec_secy *secy,
                              ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:51:13: warning: Uninitialized variable: txsc->sw_secy [uninitvar]
     if (txsc->sw_secy == secy)
               ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:65:13: warning: Uninitialized variable: rxsc->sw_rxsc [uninitvar]
     if (rxsc->sw_rxsc == rx_sc && rxsc->sw_secy == secy)
               ^
>> drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:1012:34: warning: Uninitialized variable: rxsc->hw_sc_id [uninitvar]
     cn10k_mcs_sc_stats(pfvf, rxsc->hw_sc_id, &sc_rsp, MCS_RX, true);
                                    ^
   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:997:58: note: Assuming condition is false
    if (secy->validate_frames == txsc->last_validate_frames &&
                                                            ^
   drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c:1012:34: note: Uninitialized variable: rxsc->hw_sc_id
     cn10k_mcs_sc_stats(pfvf, rxsc->hw_sc_id, &sc_rsp, MCS_RX, true);
                                    ^

vim +/secy +46 drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c

c54ffc73601c0a Subbaraya Sundeep 2022-10-01  44  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  45  static struct cn10k_mcs_txsc *cn10k_mcs_get_txsc(struct cn10k_mcs_cfg *cfg,
c54ffc73601c0a Subbaraya Sundeep 2022-10-01 @46  						 struct macsec_secy *secy)
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  47  {
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  48  	struct cn10k_mcs_txsc *txsc;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  49  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  50  	list_for_each_entry(txsc, &cfg->txsc_list, entry) {
c54ffc73601c0a Subbaraya Sundeep 2022-10-01 @51  		if (txsc->sw_secy == secy)
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  52  			return txsc;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  53  	}
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  54  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  55  	return NULL;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  56  }
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  57  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  58  static struct cn10k_mcs_rxsc *cn10k_mcs_get_rxsc(struct cn10k_mcs_cfg *cfg,
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  59  						 struct macsec_secy *secy,
c54ffc73601c0a Subbaraya Sundeep 2022-10-01 @60  						 struct macsec_rx_sc *rx_sc)
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  61  {
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  62  	struct cn10k_mcs_rxsc *rxsc;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  63  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  64  	list_for_each_entry(rxsc, &cfg->rxsc_list, entry) {
c54ffc73601c0a Subbaraya Sundeep 2022-10-01 @65  		if (rxsc->sw_rxsc == rx_sc && rxsc->sw_secy == secy)
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  66  			return rxsc;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  67  	}
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  68  
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  69  	return NULL;
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  70  }
c54ffc73601c0a Subbaraya Sundeep 2022-10-01  71  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp