* [PATCH] video: fbdev: omapfb: remove redundant variable checksum
@ 2022-11-01 10:29 Colin Ian King
2022-11-01 15:31 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-11-01 10:29 UTC (permalink / raw)
To: Helge Deller, linux-omap, linux-fbdev, dri-devel
Cc: kernel-janitors, linux-kernel
Variable checksum is being used to accumulate values however
it is never read or used afterwards. It is redundant and can
be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
index cb63bc0e92ca..b33f62c5cb22 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
@@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
{
void __iomem *base = core->base;
u8 cur_addr;
- char checksum = 0;
const int retries = 1000;
u8 seg_ptr = ext / 2;
u8 edidbase = ((ext % 2) * 0x80);
@@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
}
pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0);
- checksum += pedid[cur_addr];
}
return 0;
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: omapfb: remove redundant variable checksum
2022-11-01 10:29 [PATCH] video: fbdev: omapfb: remove redundant variable checksum Colin Ian King
@ 2022-11-01 15:31 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2022-11-01 15:31 UTC (permalink / raw)
To: Colin Ian King, linux-omap, linux-fbdev, dri-devel
Cc: kernel-janitors, linux-kernel
On 11/1/22 11:29, Colin Ian King wrote:
> Variable checksum is being used to accumulate values however
> it is never read or used afterwards. It is redundant and can
> be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> index cb63bc0e92ca..b33f62c5cb22 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
> @@ -129,7 +129,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
> {
> void __iomem *base = core->base;
> u8 cur_addr;
> - char checksum = 0;
> const int retries = 1000;
> u8 seg_ptr = ext / 2;
> u8 edidbase = ((ext % 2) * 0x80);
> @@ -178,7 +177,6 @@ static int hdmi_core_ddc_edid(struct hdmi_core_data *core, u8 *pedid, u8 ext)
> }
>
> pedid[cur_addr] = REG_GET(base, HDMI_CORE_I2CM_DATAI, 7, 0);
> - checksum += pedid[cur_addr];
> }
>
> return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 10:29 [PATCH] video: fbdev: omapfb: remove redundant variable checksum Colin Ian King
2022-11-01 15:31 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.