* [PATCH v2] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
@ 2022-11-02 9:13 Manivannan Sadhasivam
2022-11-07 3:12 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Manivannan Sadhasivam @ 2022-11-02 9:13 UTC (permalink / raw)
To: andersson
Cc: konrad.dybcio, mturquette, sboyd, linux-arm-msm, linux-clk,
linux-kernel, Manivannan Sadhasivam
USB controllers on SM8250 doesn't work after coming back from suspend.
This can be fixed by keeping the USB GDSCs in retention mode so that
hardware can keep them ON and put into rentention mode once the parent
domain goes to a low power state.
Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Changes in v2:
* Added Fixes tag (Stephen)
drivers/clk/qcom/gcc-sm8250.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sm8250.c b/drivers/clk/qcom/gcc-sm8250.c
index 9755ef4888c1..a0ba37656b07 100644
--- a/drivers/clk/qcom/gcc-sm8250.c
+++ b/drivers/clk/qcom/gcc-sm8250.c
@@ -3267,7 +3267,7 @@ static struct gdsc usb30_prim_gdsc = {
.pd = {
.name = "usb30_prim_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
};
static struct gdsc usb30_sec_gdsc = {
@@ -3275,7 +3275,7 @@ static struct gdsc usb30_sec_gdsc = {
.pd = {
.name = "usb30_sec_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
};
static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
2022-11-02 9:13 [PATCH v2] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs Manivannan Sadhasivam
@ 2022-11-07 3:12 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-11-07 3:12 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: mturquette, linux-clk, linux-arm-msm, konrad.dybcio, linux-kernel, sboyd
On Wed, 2 Nov 2022 14:43:20 +0530, Manivannan Sadhasivam wrote:
> USB controllers on SM8250 doesn't work after coming back from suspend.
> This can be fixed by keeping the USB GDSCs in retention mode so that
> hardware can keep them ON and put into rentention mode once the parent
> domain goes to a low power state.
>
>
Applied, thanks!
[1/1] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs
commit: ac1c5a03d3772b1db25e8092f771aa33f6ae2f7e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-07 3:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 9:13 [PATCH v2] clk: qcom: gcc-sm8250: Use retention mode for USB GDSCs Manivannan Sadhasivam
2022-11-07 3:12 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.