* [PATCH] hash: fix memory leak of hash_rcu_cfg
@ 2022-11-04 7:33 Jun Qiu
0 siblings, 0 replies; 3+ messages in thread
From: Jun Qiu @ 2022-11-04 7:33 UTC (permalink / raw)
To: dev; +Cc: yipeng1.wang
The memory of h->hash_rcu_cfg which allocated in
rte_hash_rcu_qsbr_add was leaked.
Signed-off-by: Jun Qiu <jun.qiu@jaguarmicro.com>
---
lib/hash/rte_cuckoo_hash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 62c762439a..829b79c89a 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -521,6 +521,7 @@ rte_hash_free(struct rte_hash *h)
rte_free(h->buckets_ext);
rte_free(h->tbl_chng_cnt);
rte_free(h->ext_bkt_to_free);
+ rte_free(h->hash_rcu_cfg);
rte_free(h);
rte_free(te);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hash: fix memory leak of hash_rcu_cfg
2022-11-04 9:51 Jun Qiu
@ 2022-11-14 10:03 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-11-14 10:03 UTC (permalink / raw)
To: Jun Qiu; +Cc: dev, yipeng1.wang, lei.cai, stable
On Fri, Nov 4, 2022 at 10:52 AM Jun Qiu <jun.qiu@jaguarmicro.com> wrote:
>
> The memory of h->hash_rcu_cfg which is allocated in
> rte_hash_rcu_qsbr_add was leaked.
>
> Fixes: 769b2de ("hash: implement RCU resources reclamation")
Please, use 12 chars format for commit hash, as documented.
git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h
(\"%s\")%nCc: %ae'"
> Cc: stable@dpdk.org
>
> Signed-off-by: Jun Qiu <jun.qiu@jaguarmicro.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] hash: fix memory leak of hash_rcu_cfg
@ 2022-11-04 9:51 Jun Qiu
2022-11-14 10:03 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Jun Qiu @ 2022-11-04 9:51 UTC (permalink / raw)
To: dev; +Cc: yipeng1.wang, lei.cai, stable
The memory of h->hash_rcu_cfg which is allocated in
rte_hash_rcu_qsbr_add was leaked.
Fixes: 769b2de ("hash: implement RCU resources reclamation")
Cc: stable@dpdk.org
Signed-off-by: Jun Qiu <jun.qiu@jaguarmicro.com>
---
lib/hash/rte_cuckoo_hash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 62c762439a..829b79c89a 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -521,6 +521,7 @@ rte_hash_free(struct rte_hash *h)
rte_free(h->buckets_ext);
rte_free(h->tbl_chng_cnt);
rte_free(h->ext_bkt_to_free);
+ rte_free(h->hash_rcu_cfg);
rte_free(h);
rte_free(te);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-14 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 7:33 [PATCH] hash: fix memory leak of hash_rcu_cfg Jun Qiu
2022-11-04 9:51 Jun Qiu
2022-11-14 10:03 ` David Marchand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.