All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: qcom: llcc: make irq truly optional
@ 2022-11-04 15:30 Luca Weiss
  2022-11-07  3:12 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Luca Weiss @ 2022-11-04 15:30 UTC (permalink / raw)
  To: linux-arm-msm
  Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
	Bjorn Andersson, Konrad Dybcio, Venkata Narendra Kumar Gutta,
	Evan Green, linux-kernel

The function platform_get_irq prints an error message into the kernel
log when the irq isn't found.

Since the interrupt is actually optional and not provided by some SoCs,
use platform_get_irq_optional which does not print an error message.

Fixes: c081f3060fab ("soc: qcom: Add support to register LLCC EDAC driver")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
 drivers/soc/qcom/llcc-qcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 8b7e8118f3ce..82c3cfdcc560 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -849,7 +849,7 @@ static int qcom_llcc_probe(struct platform_device *pdev)
 	if (ret)
 		goto err;
 
-	drv_data->ecc_irq = platform_get_irq(pdev, 0);
+	drv_data->ecc_irq = platform_get_irq_optional(pdev, 0);
 	if (drv_data->ecc_irq >= 0) {
 		llcc_edac = platform_device_register_data(&pdev->dev,
 						"qcom_llcc_edac", -1, drv_data,
-- 
2.38.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] soc: qcom: llcc: make irq truly optional
  2022-11-04 15:30 [PATCH] soc: qcom: llcc: make irq truly optional Luca Weiss
@ 2022-11-07  3:12 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-11-07  3:12 UTC (permalink / raw)
  To: linux-arm-msm, luca.weiss
  Cc: ~postmarketos/upstreaming, evgreen, konrad.dybcio, linux-kernel,
	vnkgutta, phone-devel, Andy Gross

On Fri, 4 Nov 2022 16:30:41 +0100, Luca Weiss wrote:
> The function platform_get_irq prints an error message into the kernel
> log when the irq isn't found.
> 
> Since the interrupt is actually optional and not provided by some SoCs,
> use platform_get_irq_optional which does not print an error message.
> 
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: llcc: make irq truly optional
      commit: c882c899ead3545102a4d71b5fbe73b9e4bc2657

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-07  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 15:30 [PATCH] soc: qcom: llcc: make irq truly optional Luca Weiss
2022-11-07  3:12 ` Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.