* [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds
@ 2022-11-06 10:53 Fabrice Fontaine
2022-11-06 13:58 ` Yann E. MORIN
2022-11-06 18:03 ` Christian Stewart via buildroot
0 siblings, 2 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2022-11-06 10:53 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Fix the following musl and uclibc-ng build failures raised since the
addition of the package in commit
530d6f661e506a4774b7236cb93d65f669adbc92:
configure: error: *** argp functions not found - install libargp or argp_standalone
Fixes:
- http://autobuild.buildroot.org/results/55b283fa46a797253193fb752638ba88597a416b
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/crun/Config.in | 1 +
package/crun/crun.mk | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/package/crun/Config.in b/package/crun/Config.in
index 5aca10dcdb..5def7001c1 100644
--- a/package/crun/Config.in
+++ b/package/crun/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_CRUN
bool "crun"
+ select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
select BR2_PACKAGE_YAJL # libocispec
help
crun is a fast and low-memory OCI Container Runtime in C.
diff --git a/package/crun/crun.mk b/package/crun/crun.mk
index 4a0c150594..65f166e657 100644
--- a/package/crun/crun.mk
+++ b/package/crun/crun.mk
@@ -15,6 +15,10 @@ CRUN_CPE_ID_VENDOR = crun_project
CRUN_AUTORECONF = YES
CRUN_CONF_OPTS = --disable-embedded-yajl
+ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
+CRUN_DEPENDENCIES += argp-standalone
+endif
+
ifeq ($(BR2_PACKAGE_LIBCAP),y)
CRUN_DEPENDENCIES += libcap
CRUN_CONF_OPTS += --enable-caps
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds
2022-11-06 10:53 [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds Fabrice Fontaine
@ 2022-11-06 13:58 ` Yann E. MORIN
2022-11-06 18:03 ` Christian Stewart via buildroot
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-11-06 13:58 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Fabrice, All,
On 2022-11-06 11:53 +0100, Fabrice Fontaine spake thusly:
> Fix the following musl and uclibc-ng build failures raised since the
> addition of the package in commit
> 530d6f661e506a4774b7236cb93d65f669adbc92:
>
> configure: error: *** argp functions not found - install libargp or argp_standalone
>
> Fixes:
> - http://autobuild.buildroot.org/results/55b283fa46a797253193fb752638ba88597a416b
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/crun/Config.in | 1 +
> package/crun/crun.mk | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/package/crun/Config.in b/package/crun/Config.in
> index 5aca10dcdb..5def7001c1 100644
> --- a/package/crun/Config.in
> +++ b/package/crun/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_CRUN
> bool "crun"
> + select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
I find it a bit weirs that the select uses the uclibc||musl construct,
but that argp-standalone depends on !glibc.
Yes, the two conditions are technical equivalent, but still it is weird.
I looked at what we currently have, and it turns out that we have only
one case where the select uses !glibc (xen), 12 where we use
ublibc||musl, and 1 only uclibc (elfutils, which is glibc or uclibc
only).
so... Applied to master as-is, thanks.
Regards,
Yann E. MORIN.
> select BR2_PACKAGE_YAJL # libocispec
> help
> crun is a fast and low-memory OCI Container Runtime in C.
> diff --git a/package/crun/crun.mk b/package/crun/crun.mk
> index 4a0c150594..65f166e657 100644
> --- a/package/crun/crun.mk
> +++ b/package/crun/crun.mk
> @@ -15,6 +15,10 @@ CRUN_CPE_ID_VENDOR = crun_project
> CRUN_AUTORECONF = YES
> CRUN_CONF_OPTS = --disable-embedded-yajl
>
> +ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> +CRUN_DEPENDENCIES += argp-standalone
> +endif
> +
> ifeq ($(BR2_PACKAGE_LIBCAP),y)
> CRUN_DEPENDENCIES += libcap
> CRUN_CONF_OPTS += --enable-caps
> --
> 2.35.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds
2022-11-06 10:53 [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds Fabrice Fontaine
2022-11-06 13:58 ` Yann E. MORIN
@ 2022-11-06 18:03 ` Christian Stewart via buildroot
2022-11-06 18:55 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Christian Stewart via buildroot @ 2022-11-06 18:03 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Christian Stewart, buildroot
Hi Fabrice,
On Sun, Nov 6, 2022 at 2:53 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
> +ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> +CRUN_DEPENDENCIES += argp-standalone
> +endif
> +
Lgtm!
Reviewed-by: Christian Stewart <christian@paral.in>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds
2022-11-06 18:03 ` Christian Stewart via buildroot
@ 2022-11-06 18:55 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2022-11-06 18:55 UTC (permalink / raw)
To: Christian Stewart; +Cc: Fabrice Fontaine, buildroot
Christian, All,
On 2022-11-06 10:03 -0800, Christian Stewart via buildroot spake thusly:
> On Sun, Nov 6, 2022 at 2:53 AM Fabrice Fontaine
> <fontaine.fabrice@gmail.com> wrote:
> > +ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> > +CRUN_DEPENDENCIES += argp-standalone
> > +endif
> Lgtm!
>
> Reviewed-by: Christian Stewart <christian@paral.in>
Thanks for the feedback, but already applied. ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-06 18:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 10:53 [Buildroot] [PATCH 1/1] package/crun: fix musl and uclibc-ng builds Fabrice Fontaine
2022-11-06 13:58 ` Yann E. MORIN
2022-11-06 18:03 ` Christian Stewart via buildroot
2022-11-06 18:55 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.