Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

From: Guenter Roeck <linux@roeck-us.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Julia Lawall <Julia.Lawall@inria.fr>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()
Date: Sun, 6 Nov 2022 14:52:11 -0800	[thread overview]
Message-ID: <20221106225211.GB805009@roeck-us.net> (raw)
In-Reply-To: <CAHk-=whO5PXEzWwf=4=fvdqim6cGTczVoN4KJ5H+dabHo-OTHw@mail.gmail.com>

On Sun, Nov 06, 2022 at 02:40:14PM -0800, Linus Torvalds wrote:
> On Sun, Nov 6, 2022 at 1:52 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > I can update the change log to include:
> 
> Yup, full running instructions for coccinelle patches is probably a good idea.
> 
> I've done them semi-occasionally, but it's rare enough that I always
> have to look it up anyway, and I suspect many others have never done
> it, so having it in the commit message is probably a good idea.
> 
> >       when != ptr->timer.function = E;
> 
> I do think that you should just remove that E expression and the
> "function = E" part.
> 

Agreed. Removing this line does not make a difference. It looks like the
"when strict" takes care of the condition.

Guenter