Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()

From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Anna-Maria Gleixner <anna-maria@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Julia Lawall <Julia.Lawall@inria.fr>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()
Date: Sun, 6 Nov 2022 13:39:45 -0800	[thread overview]
Message-ID: <CAHk-=wjYY9k7TzyJvWOPSPLL+jHkdogyWuOUyStfE5h1=0Qk0w@mail.gmail.com> (raw)
In-Reply-To: <20221106160956.2414d73f@rorschach.local.home>

On Sun, Nov 6, 2022 at 1:10 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
>   ... when strict
>       when != ptr->timer.function = E;

.. and I tried this with just 'ptr->timer', and it doesn't seem to
make any difference, so apparently that NULL pointer initialization
was the only case.

And then - like you and Guenter - I went through the patch manually to
look for anything that looked odd, and didn't find anything.

So yes, I'm happy with this. It looks like a very reasonable "let's
handle the scripted trivial cases automatically", and then anything
more complicated can be left for 6.2.

And with that cocci script (and how to run it), people can see what
the script was, and even run it themselves to verify, and that just
makes me feel all warm and fuzzy about it.

                 Linus